Skip to content

[Security Solution] fix Build Block Alerts row background color#228226

Merged
agusruidiazgd merged 3 commits intoelastic:mainfrom
agusruidiazgd:fix/highlighted-building-block-alerts
Jul 22, 2025
Merged

[Security Solution] fix Build Block Alerts row background color#228226
agusruidiazgd merged 3 commits intoelastic:mainfrom
agusruidiazgd:fix/highlighted-building-block-alerts

Conversation

@agusruidiazgd
Copy link
Contributor

@agusruidiazgd agusruidiazgd commented Jul 16, 2025

Summary

Closes #212189

I've updated the building block alerts background color using a new EuiDataGrid component token (introduced in this PR

dataGridRowBackgroundMarked

Before

Screenshot 2025-07-17 at 08 52 04

After merging this PR

Light Mode
Screenshot 2025-07-16 at 15 21 46
Dark Mode
Screenshot 2025-07-16 at 15 22 11

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd self-assigned this Jul 16, 2025
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner July 16, 2025 13:38
@agusruidiazgd agusruidiazgd added release_note:fix v9.0.0 Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team backport:prev-minor ci:cloud-deploy Create or update a Cloud deployment v9.1.0 v9.2.0 labels Jul 16, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@agusruidiazgd
Copy link
Contributor Author

@elasticmachine merge upstream

@agusruidiazgd agusruidiazgd enabled auto-merge (squash) July 22, 2025 13:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 22, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB -16.0B
embeddableAlertsTable 941.0KB 940.9KB -16.0B
ml 5.4MB 5.4MB -18.0B
observability 1.3MB 1.3MB -16.0B
securitySolution 9.8MB 9.8MB -5.0B
triggersActionsUi 1.5MB 1.5MB -16.0B
total -87.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 135.0KB 134.9KB -62.0B
embeddableAlertsTable 5.9KB 5.9KB -62.0B
ml 85.6KB 85.5KB -63.0B
triggersActionsUi 105.7KB 105.6KB -62.0B
total -249.0B

History

cc @agusruidiazgd

@agusruidiazgd agusruidiazgd merged commit 836b8d9 into elastic:main Jul 22, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16449910592

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2025
…tic#228226)

## Summary

Closes elastic#212189

I've updated the building block alerts background color using a new
`EuiDataGrid` component token (introduced in [this
PR](elastic#226882)

 `dataGridRowBackgroundMarked`

 ### Before

<img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04"
src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d"
/>

  ### After merging this PR

| Light Mode |
| :--------: |
| <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46"
src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219"
/> |

| Dark Mode |
| :-------: |
| <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11"
src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258"
/> |

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 836b8d9)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- Fix reporting pollEnabled config (#228707)
- [Discover] Fix "Body cell lines" display option handling when default value is -1 (#228697)
- [Lens] Fix Firefox inline editor scroll (#228625)
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 228226

Questions ?

Please refer to the Backport tool documentation

tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Jul 22, 2025
…tic#228226)

## Summary

Closes elastic#212189

I've updated the building block alerts background color using a new
`EuiDataGrid` component token (introduced in [this
PR](elastic#226882)

 `dataGridRowBackgroundMarked`
 
 ### Before
 
<img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04"
src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d"
/>

  ### After merging this PR

| Light Mode |
| :--------: |
| <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46"
src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219"
/> |

| Dark Mode |
| :-------: |
| <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11"
src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258"
/> |



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request Jul 23, 2025
…tic#228226)

## Summary

Closes elastic#212189

I've updated the building block alerts background color using a new
`EuiDataGrid` component token (introduced in [this
PR](elastic#226882)

 `dataGridRowBackgroundMarked`
 
 ### Before
 
<img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04"
src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d"
/>

  ### After merging this PR

| Light Mode |
| :--------: |
| <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46"
src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219"
/> |

| Dark Mode |
| :-------: |
| <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11"
src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258"
/> |



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 24, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

@PhilippeOberti
Copy link
Contributor

hey @agusruidiazgd,
I see that the 9.0 backport failed here, please make sure to run the command manually sooner rather than later.
Also I see that we have 9.0 and 9.1 labels but we don't have 8.18 and 8.19, is that on purpose?

@agusruidiazgd
Copy link
Contributor Author

hey @agusruidiazgd, I see that the 9.0 backport failed here, please make sure to run the command manually sooner rather than later. Also I see that we have 9.0 and 9.1 labels but we don't have 8.18 and 8.19, is that on purpose?

Adding it - It seems I forgot to add those ones

kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…tic#228226)

## Summary

Closes elastic#212189

I've updated the building block alerts background color using a new
`EuiDataGrid` component token (introduced in [this
PR](elastic#226882)

 `dataGridRowBackgroundMarked`
 
 ### Before
 
<img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04"
src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d"
/>

  ### After merging this PR

| Light Mode |
| :--------: |
| <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46"
src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219"
/> |

| Dark Mode |
| :-------: |
| <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11"
src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258"
/> |



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jul 25, 2025
…tic#228226)

## Summary

Closes elastic#212189

I've updated the building block alerts background color using a new
`EuiDataGrid` component token (introduced in [this
PR](elastic#226882)

 `dataGridRowBackgroundMarked`
 
 ### Before
 
<img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04"
src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d"
/>

  ### After merging this PR

| Light Mode |
| :--------: |
| <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46"
src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219"
/> |

| Dark Mode |
| :-------: |
| <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11"
src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258"
/> |



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

@agusruidiazgd agusruidiazgd added backport:skip This PR does not require backporting and removed v9.0.0 v8.18.0 v9.1.0 v8.19.0 v9.2.0 labels Jul 28, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security Solution] Build Block Alerts have different color in 9.0.0 because of Boe

5 participants