Merged
Conversation
The markup now includes screen reader-only output, see elastic/eui#8839
Contributor
|
Pinging @elastic/eui-team (EUI) |
Contributor
Author
|
@elasticmachine merge upstream |
PhilippeOberti
approved these changes
Jul 11, 2025
AlexGPlay
approved these changes
Jul 11, 2025
jughosta
reviewed
Jul 11, 2025
...tform/packages/shared/kbn-unified-field-list/src/components/field_stats/field_stats.test.tsx
Outdated
Show resolved
Hide resolved
mistic
approved these changes
Jul 11, 2025
to use built-in labels from EuiProgress, while keeping the interface intact, including tooltips; tests are also updated
Contributor
Author
|
@elasticmachine merge upstream |
13 tasks
jughosta
reviewed
Jul 14, 2025
...ackages/shared/kbn-unified-field-list/src/components/field_stats/field_top_values_bucket.tsx
Show resolved
Hide resolved
jughosta
reviewed
Jul 14, 2025
rmyz
approved these changes
Jul 14, 2025
Contributor
rmyz
left a comment
There was a problem hiding this comment.
infra & services changes LGTM
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @acstll |
jedrazb
approved these changes
Jul 14, 2025
TattdCodeMonkey
approved these changes
Jul 14, 2025
delanni
approved these changes
Jul 14, 2025
1 task
Merged
16 tasks
jkelas
pushed a commit
that referenced
this pull request
Jul 18, 2025
…ing into input field (#228517) **Resolves: #227885** ## Summary Fixing Cypress test issue and unskipping the test. The fault was introduced most probably by the upgrade of EUI in the following commit. ``` commit eca0d1c (HEAD) Author: Arturo Castillo Delgado <arturo.castillo@elastic.co> Date: Mon Jul 14 16:25:22 2025 +0200 Upgrade EUI to v105.0.0 (#226882) ``` In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the `email` input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown). I am fixing it by forcing the `enter` key, like it is already done in other places in the code. # Testing: Run Cypress test `yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts ` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
`104.1.0` ⏩ `105.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v105.0.0`](https://github.com/elastic/eui/releases/v105.0.0) - Added marked row styling via the classes `euiDataGridRow--marked` and `euiTableRow--marked` for `EuiDataGrid` and `EuiBasicTable` ([elastic#8834](elastic/eui#8834)) - Added component tokens: ([elastic#8834](elastic/eui#8834)) - `dataGridRowBackgroundMarked` - `dataGridRowBackgroundMarkedHover` - `dataGridRowBorderActive` - `dataGridRowBorderHover` - `dataGridRowBorderMarked` - `tableRowBackgroundMarked` - `tableRowBackgroundMarkedHover` - Added `EuiFlyoutChild` and `EuiFlyoutSessionProvider` ([elastic#8771](elastic/eui#8771)) - Added `setListOptionRefs` prop on `EuiComboBoxList` ([elastic#8829](elastic/eui#8829)) **Breaking changes** - Removed `iInCircle` icon (use `info` instead) ([elastic#8841](elastic/eui#8841)) - Removed `questionInCircle` icon (use `question` instead) ([elastic#8841](elastic/eui#8841)) **Accessibility** - Improved the experience of `EuiProgress` by ensuring that determinate updates are read out immediately to screen readers ([elastic#8839](elastic/eui#8839)) - Fixed missing screen reader output for `EuiComboBox` with `options` that have custom `id` attributes ([elastic#8829](elastic/eui#8829)) ### `@elastic/eui-theme-borealis` #### [`v3.2.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v320) - Added component tokens: ([elastic#8834](elastic/eui#8834)) - `dataGridRowBackgroundMarked` - `dataGridRowBackgroundMarkedHover` - `dataGridRowBorderActive` - `dataGridRowBorderHover` - `dataGridRowBorderMarked` - `tableRowBackgroundMarked` - `tableRowBackgroundMarkedHover` ## Summary - **Marked row styling** for `EuiDataGrid` and `EuiBasicTable`: new CSS classes are available for consistent styling of marked rows (different from selected), including hover and cell outline styles (elastic/eui#8834) - **New flyout component**: `EuiFlyoutChild` allows side-by-side (grouped) flyout panels (elastic/eui#8771) - **Accessibility fixes:** - `EuiComboBox` now supports custom option `id`s (elastic/eui#8829) - Updates on `EuiProgress` are properly announced by screen readers (elastic/eui#8839) - **Icon updates** (breaking change): `iInCircle` and `questionInCircle` icons have been renamed to `info` and `question` respectively (elastic/eui#8841) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…ing into input field (elastic#228517) **Resolves: elastic#227885** ## Summary Fixing Cypress test issue and unskipping the test. The fault was introduced most probably by the upgrade of EUI in the following commit. ``` commit eca0d1c (HEAD) Author: Arturo Castillo Delgado <arturo.castillo@elastic.co> Date: Mon Jul 14 16:25:22 2025 +0200 Upgrade EUI to v105.0.0 (elastic#226882) ``` In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the `email` input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown). I am fixing it by forcing the `enter` key, like it is already done in other places in the code. # Testing: Run Cypress test `yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts ` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
agusruidiazgd
added a commit
that referenced
this pull request
Jul 22, 2025
) ## Summary Closes #212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 22, 2025
…tic#228226) ## Summary Closes elastic#212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](elastic#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 836b8d9)
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Jul 22, 2025
…tic#228226) ## Summary Closes elastic#212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](elastic#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kdelemme
pushed a commit
to kdelemme/kibana
that referenced
this pull request
Jul 23, 2025
…tic#228226) ## Summary Closes elastic#212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](elastic#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
`104.1.0` ⏩ `105.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v105.0.0`](https://github.com/elastic/eui/releases/v105.0.0) - Added marked row styling via the classes `euiDataGridRow--marked` and `euiTableRow--marked` for `EuiDataGrid` and `EuiBasicTable` ([elastic#8834](elastic/eui#8834)) - Added component tokens: ([elastic#8834](elastic/eui#8834)) - `dataGridRowBackgroundMarked` - `dataGridRowBackgroundMarkedHover` - `dataGridRowBorderActive` - `dataGridRowBorderHover` - `dataGridRowBorderMarked` - `tableRowBackgroundMarked` - `tableRowBackgroundMarkedHover` - Added `EuiFlyoutChild` and `EuiFlyoutSessionProvider` ([elastic#8771](elastic/eui#8771)) - Added `setListOptionRefs` prop on `EuiComboBoxList` ([elastic#8829](elastic/eui#8829)) **Breaking changes** - Removed `iInCircle` icon (use `info` instead) ([elastic#8841](elastic/eui#8841)) - Removed `questionInCircle` icon (use `question` instead) ([elastic#8841](elastic/eui#8841)) **Accessibility** - Improved the experience of `EuiProgress` by ensuring that determinate updates are read out immediately to screen readers ([elastic#8839](elastic/eui#8839)) - Fixed missing screen reader output for `EuiComboBox` with `options` that have custom `id` attributes ([elastic#8829](elastic/eui#8829)) ### `@elastic/eui-theme-borealis` #### [`v3.2.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v320) - Added component tokens: ([elastic#8834](elastic/eui#8834)) - `dataGridRowBackgroundMarked` - `dataGridRowBackgroundMarkedHover` - `dataGridRowBorderActive` - `dataGridRowBorderHover` - `dataGridRowBorderMarked` - `tableRowBackgroundMarked` - `tableRowBackgroundMarkedHover` ## Summary - **Marked row styling** for `EuiDataGrid` and `EuiBasicTable`: new CSS classes are available for consistent styling of marked rows (different from selected), including hover and cell outline styles (elastic/eui#8834) - **New flyout component**: `EuiFlyoutChild` allows side-by-side (grouped) flyout panels (elastic/eui#8771) - **Accessibility fixes:** - `EuiComboBox` now supports custom option `id`s (elastic/eui#8829) - Updates on `EuiProgress` are properly announced by screen readers (elastic/eui#8839) - **Icon updates** (breaking change): `iInCircle` and `questionInCircle` icons have been renamed to `info` and `question` respectively (elastic/eui#8841) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…ing into input field (elastic#228517) **Resolves: elastic#227885** ## Summary Fixing Cypress test issue and unskipping the test. The fault was introduced most probably by the upgrade of EUI in the following commit. ``` commit eca0d1c (HEAD) Author: Arturo Castillo Delgado <arturo.castillo@elastic.co> Date: Mon Jul 14 16:25:22 2025 +0200 Upgrade EUI to v105.0.0 (elastic#226882) ``` In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the `email` input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown). I am fixing it by forcing the `enter` key, like it is already done in other places in the code. # Testing: Run Cypress test `yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts ` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…tic#228226) ## Summary Closes elastic#212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](elastic#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jul 25, 2025
…tic#228226) ## Summary Closes elastic#212189 I've updated the building block alerts background color using a new `EuiDataGrid` component token (introduced in [this PR](elastic#226882) `dataGridRowBackgroundMarked` ### Before <img width="806" height="595" alt="Screenshot 2025-07-17 at 08 52 04" src="https://github.com/user-attachments/assets/e510835d-5323-41be-8383-6a3ec711631d" /> ### After merging this PR | Light Mode | | :--------: | | <img width="1378" height="240" alt="Screenshot 2025-07-16 at 15 21 46" src="https://github.com/user-attachments/assets/4dfb4094-45d5-4133-a5f0-2d6b9021b219" /> | | Dark Mode | | :-------: | | <img width="1375" height="274" alt="Screenshot 2025-07-16 at 15 22 11" src="https://github.com/user-attachments/assets/4ef73904-ab1d-424d-bae0-a75f3dfd4258" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
104.1.0⏩105.0.0Questions? Please see our Kibana upgrade FAQ.
Package updates
@elastic/euiv105.0.0euiDataGridRow--markedandeuiTableRow--markedforEuiDataGridandEuiBasicTable(#8834)dataGridRowBackgroundMarkeddataGridRowBackgroundMarkedHoverdataGridRowBorderActivedataGridRowBorderHoverdataGridRowBorderMarkedtableRowBackgroundMarkedtableRowBackgroundMarkedHoverEuiFlyoutChildandEuiFlyoutSessionProvider(#8771)setListOptionRefsprop onEuiComboBoxList(#8829)Breaking changes
iInCircleicon (useinfoinstead) (#8841)questionInCircleicon (usequestioninstead) (#8841)Accessibility
EuiProgressby ensuring that determinate updates are read out immediately to screen readers (#8839)EuiComboBoxwithoptionsthat have customidattributes (#8829)@elastic/eui-theme-borealisv3.2.0dataGridRowBackgroundMarkeddataGridRowBackgroundMarkedHoverdataGridRowBorderActivedataGridRowBorderHoverdataGridRowBorderMarkedtableRowBackgroundMarkedtableRowBackgroundMarkedHoverSummary
EuiDataGridandEuiBasicTable: new CSS classes are available for consistent styling of marked rows (different from selected), including hover and cell outline styles ([EuiBasicTable][EuiDataGrid] Add marked row styling eui#8834)EuiFlyoutChildallows side-by-side (grouped) flyout panels (Add EuiFlyoutChild for Grouped Flyouts eui#8771)EuiComboBoxnow supports custom optionids ([EuiComboBox][A11y] Prevent custom option ids from breaking accessibility eui#8829)EuiProgressare properly announced by screen readers ([EuiProgress][A11y] Announce determinate progress update to screen readers eui#8839)iInCircleandquestionInCircleicons have been renamed toinfoandquestionrespectively (Renaming icons (removing old handlers) eui#8841)