Fix reporting pollEnabled config by ersin-erdal · Pull Request #228707 · elastic/kibana

ersin-erdal · 2025-07-21T00:38:04Z

This PR fixes the bug: xpack.reporting.queue.pollEnabled config to be ignored by the mget claim strategy.

To verify:

Set xpack.reporting.queue.pollEnabled: false in your kibana.yml.
Then try to generate a report.
The task should be successfully created but its status should remain as pending on the reports page.

elasticmachine · 2025-07-21T13:10:12Z

Pinging @elastic/response-ops (Team:ResponseOps)

adcoelho · 2025-07-21T14:05:52Z

Set xpack.reporting.queue.pollEnabled: true in your kibana.yml.

Considering the original issue, shouldn't this be false? 😅

ymao1 · 2025-07-21T14:08:54Z

x-pack/platform/plugins/shared/task_manager/server/task_claimers/strategy_mget.ts

  const initialCapacity = getCapacity();
  const stopTaskTimer = startTaskTimer();

+  const taskTypes = new Set<string>();


I think the problem lies in

kibana/x-pack/platform/plugins/shared/task_manager/server/task_pool/cost_capacity.ts

Line 72 in 2e6f753

if (taskDefinition && taskDefinition.maxConcurrency) {

where we're just checking for taskDefinition.maxConcurrency, so not handling the max concurrency of 0 correctly. we're already getting the limited and unlimited batches in the buildClaimPartitions function below but the capacity is returning incorrectly when the maxConcurrency is 0

I didn't even check that part because update_by_query relies on the batches to filter out the skipped tasks, just applied the same logic here.
Thanks for pointing the above problem, moved the fix there.
I guess the same fix should be applied to worker_capacity as well. Fixed that too.

ersin-erdal · 2025-07-21T16:52:04Z

Set xpack.reporting.queue.pollEnabled: true in your kibana.yml.

Considering the original issue, shouldn't this be false? 😅

Correct, fixed it :)

…kibana into 226506-mget-polling-enabled

ymao1

LGTM. Verified report tasks are not claimed when pollEnabled is false and claimed when pollEnabled is true.

We should backport this fix as far back as possible. This bug was introduced in 8.16.

ymao1 · 2025-07-21T21:07:24Z

x-pack/platform/plugins/shared/task_manager/server/task_pool/cost_capacity.ts

  ): number {
    const allAvailableCapacity = this.capacity - this.usedCapacity(tasksInPool);
-    if (taskDefinition && taskDefinition.maxConcurrency) {
+    if (taskDefinition && !isNullish(taskDefinition.maxConcurrency)) {


could probably add a unit test for when maxConcurrency is 0 as well

ymao1 · 2025-07-21T21:12:38Z

x-pack/platform/plugins/shared/task_manager/server/task_claimers/strategy_mget.test.ts

+
+      const searchQueryMust = store.msearch.mock.calls[0]?.[0]?.[0].query?.bool?.must;
+
+      expect(Array.isArray(searchQueryMust) && searchQueryMust[1]).toEqual({


maybe another expect clause that the query does not contain sampleTaskZeroMaxConcurrency?

elasticmachine · 2025-07-21T21:20:55Z

💚 Build Succeeded

Buildkite Build
Commit: 9adad6b

Metrics [docs]

✅ unchanged

History

💛 Build #321405 was flaky 5ba89eb
💔 Build #321178 failed d49a030
💔 Build #321145 failed d49a030

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" /> (cherry picked from commit 8690830)

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" /> (cherry picked from commit 8690830) # Conflicts: # x-pack/platform/plugins/shared/task_manager/server/task_claimers/strategy_mget.test.ts # x-pack/platform/plugins/shared/task_manager/server/task_pool/cost_capacity.ts # x-pack/platform/plugins/shared/task_manager/server/task_pool/worker_capacity.ts

ersin-erdal · 2025-07-22T11:58:10Z

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	9.0
✅	8.19
✅	8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" /> (cherry picked from commit 8690830) # Conflicts: # x-pack/platform/plugins/shared/task_manager/server/task_claimers/strategy_mget.test.ts # x-pack/platform/plugins/shared/task_manager/server/task_pool/cost_capacity.ts # x-pack/platform/plugins/shared/task_manager/server/task_pool/worker_capacity.ts

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" /> (cherry picked from commit 8690830)

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" />

Fixes: #226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" />

# Backport This will backport the following commits from `main` to `8.18`: - [Fix reporting pollEnabled config (#228707)](#228707)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

# Backport This will backport the following commits from `main` to `8.19`: - [Fix reporting pollEnabled config (#228707)](#228707)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

# Backport This will backport the following commits from `main` to `9.0`: - [Fix reporting pollEnabled config (#228707)](#228707)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

# Backport This will backport the following commits from `main` to `9.1`: - [Fix reporting pollEnabled config (#228707)](#228707)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

Fixes: elastic#226506 This PR fixes the bug: `xpack.reporting.queue.pollEnabled` config to be ignored by the `mget` claim strategy. ## To verify: Set `xpack.reporting.queue.pollEnabled: false` in your kibana.yml. Then try to generate a report. The task should be successfully created but its status should remain as `pending` on the reports page. <img width="999" height="343" alt="Screenshot 2025-07-21 at 02 35 40" src="https://github.com/user-attachments/assets/0e7d5959-76c4-4519-ac3e-a3ca56f57f37" />

jstrassb · 2025-07-31T10:39:48Z

Thanks for fixing this @ersin-erdal!
I think the version labels in #228707 (comment) went a bit haywire, and old ones that the fixes did not make it into are still labelled here. Could you please review?

Fix reporting pollEnabled config

d49a030

ersin-erdal added release_note:fix backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Jul 21, 2025

Merge branch 'main' into 226506-mget-polling-enabled

c57803d

ersin-erdal marked this pull request as ready for review July 21, 2025 13:10

ersin-erdal requested a review from a team as a code owner July 21, 2025 13:10

Merge branch 'main' into 226506-mget-polling-enabled

5ba89eb

ymao1 requested changes Jul 21, 2025

View reviewed changes

ersin-erdal added 3 commits July 21, 2025 21:31

fix capacity check

e31b3f0

Merge branch '226506-mget-polling-enabled' of github.com:ersin-erdal/…

5109599

…kibana into 226506-mget-polling-enabled

fix worker_capacity

9adad6b

ymao1 approved these changes Jul 21, 2025

View reviewed changes

ymao1 reviewed Jul 21, 2025

View reviewed changes

Add unit tests

4b1ea42

ersin-erdal merged commit 8690830 into elastic:main Jul 22, 2025
12 checks passed

kibanamachine added the v9.2.0 label Jul 22, 2025

ersin-erdal mentioned this pull request Jul 22, 2025

[9.1] Fix reporting pollEnabled config (#228707) #228947

Merged

ersin-erdal mentioned this pull request Jul 22, 2025

[9.0] Fix reporting pollEnabled config (#228707) #228949

Merged

This was referenced Jul 22, 2025

[8.19] Fix reporting pollEnabled config (#228707) #228951

Merged

[8.18] Fix reporting pollEnabled config (#228707) #228953

Merged

This was referenced Jul 22, 2025

[Security Solution] fix Build Block Alerts row background color #228226

Merged

[ci] Move instead of copy es snapshot cache #228884

Merged

kibanamachine added the v8.18.4 label Jul 22, 2025

kibanamachine added the v8.19.0 label Jul 22, 2025

kibanamachine added v9.0.4 v9.1.0 labels Jul 22, 2025

ersin-erdal added v8.18.5 v8.19.0 v9.0.5 v9.1.0 v8.18.4 v9.0.4 and removed v9.1.0 v8.19.0 v8.18.4 v9.0.4 v8.18.5 v9.0.5 labels Jul 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix reporting pollEnabled config#228707

Fix reporting pollEnabled config#228707
ersin-erdal merged 7 commits intoelastic:mainfrom
ersin-erdal:226506-mget-polling-enabled

ersin-erdal commented Jul 21, 2025 •

edited

Loading

Uh oh!

elasticmachine commented Jul 21, 2025

Uh oh!

adcoelho commented Jul 21, 2025

Uh oh!

ymao1 Jul 21, 2025

Uh oh!

ersin-erdal Jul 21, 2025

Uh oh!

ersin-erdal commented Jul 21, 2025

Uh oh!

ymao1 left a comment

Uh oh!

ymao1 Jul 21, 2025

Uh oh!

ymao1 Jul 21, 2025

Uh oh!

elasticmachine commented Jul 21, 2025

Uh oh!

Uh oh!

ersin-erdal commented Jul 22, 2025

Uh oh!

jstrassb commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		const searchQueryMust = store.msearch.mock.calls[0]?.[0]?.[0].query?.bool?.must;

		expect(Array.isArray(searchQueryMust) && searchQueryMust[1]).toEqual({

Conversation

ersin-erdal commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To verify:

Uh oh!

elasticmachine commented Jul 21, 2025

Uh oh!

adcoelho commented Jul 21, 2025

Uh oh!

ymao1 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

ersin-erdal Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

ersin-erdal commented Jul 21, 2025

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

ymao1 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 21, 2025

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Uh oh!

ersin-erdal commented Jul 22, 2025

💚 All backports created successfully

Questions ?

Uh oh!

jstrassb commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ersin-erdal commented Jul 21, 2025 •

edited

Loading