Skip to content

[9.1] [SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)#228067

Merged
kibanamachine merged 4 commits intoelastic:9.1from
kibanamachine:backport/9.1/pr-227705
Jul 16, 2025
Merged

[9.1] [SharedUX Project Navigation] Fix issue with items in panel openers when side nav is collapsed (#227705)#228067
kibanamachine merged 4 commits intoelastic:9.1from
kibanamachine:backport/9.1/pr-227705

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…hen side nav is collapsed (elastic#227705)

Closes elastic#227616

The bug was caused some time around
elastic#210893 where support for the
landing pages of panel opener nav items ("four squares" design) was
removed. During that removal, the behavior changed when the side nav is
collapsed: panel opener items need to open as an accordion in that
scenario.

### Other changes
- Initially, I thought the root cause was due to styling, so I cleaned
up styles in `navigation_panel.tsx` and refactored them to use
`@emotion/react`.

### Release Note

Fixed a bug with the solution nav submenu items when the nav is
collapsed.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- ~~[ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~
- ~~[ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- ~~[ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~
- ~~[ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~~
- ~~[ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed~~
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

(cherry picked from commit d85f216)
@tsullivan tsullivan force-pushed the backport/9.1/pr-227705 branch from 848e857 to a314017 Compare July 15, 2025 23:57
@kibanamachine kibanamachine merged commit 3c07284 into elastic:9.1 Jul 16, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 22.8KB 22.7KB -159.0B
serverless 23.6KB 23.5KB -120.0B
total -279.0B

History

cc @tsullivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants