Skip to content

Renaming icons (removing old handlers) #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ek-so merged 2 commits into from
Jul 4, 2025
Merged

Renaming icons (removing old handlers) #8841

ek-so merged 2 commits into from
Jul 4, 2025

Conversation

@ek-so
Copy link
Contributor

@ek-so ek-so commented Jul 3, 2025 •
edited
Loading

Summary

This is the final phase of this issue.
I removed iInCircle and questionInCircle icons handlers in icon map file.
Glyphs remained and should be used now with new handlers (info and question), mentioned in changelog.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 4, 2025

💚 Build Succeeded

History

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 4, 2025

💚 Build Succeeded

History

@ek-so ek-so marked this pull request as ready for review July 4, 2025 08:28
@ek-so ek-so requested a review from a team as a code owner July 4, 2025 08:28
@weronikaolejniczak weronikaolejniczak added the breaking change PRs with breaking changes. (Don't delete - used for automation) label Jul 4, 2025
@github-actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited by ek-so
Loading

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

@ek-so
Copy link
Contributor Author

ek-so commented Jul 4, 2025

Kibana were usages replaced here: elastic/kibana#223142

@weronikaolejniczak weronikaolejniczak self-requested a review July 4, 2025 08:42
weronikaolejniczak
weronikaolejniczak approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM! Thank you, Kate! 😄

@ek-so ek-so merged commit 1cd6f96 into elastic:main Jul 4, 2025
8 checks passed
@ek-so ek-so deleted the ekso-deprecate-icons branch July 4, 2025 11:47
@acstll acstll mentioned this pull request Jul 7, 2025
Merged
acstll added a commit to elastic/kibana that referenced this pull request Jul 14, 2025
@acstll @elasticmachine @mgadewoll
Upgrade EUI to v105.0.0 (#226882)
eca0d1c 
`104.1.0` ⏩ `105.0.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v105.0.0`](https://github.com/elastic/eui/releases/v105.0.0)

- Added marked row styling via the classes `euiDataGridRow--marked` and
`euiTableRow--marked` for `EuiDataGrid` and `EuiBasicTable`
([#8834](elastic/eui#8834))
- Added component tokens:
([#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`
- Added `EuiFlyoutChild` and `EuiFlyoutSessionProvider`
([#8771](elastic/eui#8771))
- Added `setListOptionRefs` prop on `EuiComboBoxList`
([#8829](elastic/eui#8829))

**Breaking changes**

- Removed `iInCircle` icon (use `info` instead)
([#8841](elastic/eui#8841))
- Removed `questionInCircle` icon (use `question` instead)
([#8841](elastic/eui#8841))

**Accessibility**

- Improved the experience of `EuiProgress` by ensuring that determinate
updates are read out immediately to screen readers
([#8839](elastic/eui#8839))
- Fixed missing screen reader output for `EuiComboBox` with `options`
that have custom `id` attributes
([#8829](elastic/eui#8829))

### `@elastic/eui-theme-borealis`

####
[`v3.2.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v320)

- Added component tokens:
([#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`

## Summary

- **Marked row styling** for `EuiDataGrid` and `EuiBasicTable`: new CSS
classes are available for consistent styling of marked rows (different
from selected), including hover and cell outline styles
(elastic/eui#8834)
- **New flyout component**: `EuiFlyoutChild` allows side-by-side
(grouped) flyout panels (elastic/eui#8771)
- **Accessibility fixes:**
- `EuiComboBox` now supports custom option `id`s
(elastic/eui#8829)
- Updates on `EuiProgress` are properly announced by screen readers
(elastic/eui#8839)
- **Icon updates** (breaking change): `iInCircle` and `questionInCircle`
icons have been renamed to `info` and `question` respectively
(elastic/eui#8841)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Lene Gadewoll <[email protected]>
Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@acstll @elasticmachine
@mgadewoll @Bluefinger
Upgrade EUI to v105.0.0 (elastic#226882)
a15823b 
`104.1.0` ⏩ `105.0.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v105.0.0`](https://github.com/elastic/eui/releases/v105.0.0)

- Added marked row styling via the classes `euiDataGridRow--marked` and
`euiTableRow--marked` for `EuiDataGrid` and `EuiBasicTable`
([elastic#8834](elastic/eui#8834))
- Added component tokens:
([elastic#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`
- Added `EuiFlyoutChild` and `EuiFlyoutSessionProvider`
([elastic#8771](elastic/eui#8771))
- Added `setListOptionRefs` prop on `EuiComboBoxList`
([elastic#8829](elastic/eui#8829))

**Breaking changes**

- Removed `iInCircle` icon (use `info` instead)
([elastic#8841](elastic/eui#8841))
- Removed `questionInCircle` icon (use `question` instead)
([elastic#8841](elastic/eui#8841))

**Accessibility**

- Improved the experience of `EuiProgress` by ensuring that determinate
updates are read out immediately to screen readers
([elastic#8839](elastic/eui#8839))
- Fixed missing screen reader output for `EuiComboBox` with `options`
that have custom `id` attributes
([elastic#8829](elastic/eui#8829))

### `@elastic/eui-theme-borealis`

####
[`v3.2.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v320)

- Added component tokens:
([elastic#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`

## Summary

- **Marked row styling** for `EuiDataGrid` and `EuiBasicTable`: new CSS
classes are available for consistent styling of marked rows (different
from selected), including hover and cell outline styles
(elastic/eui#8834)
- **New flyout component**: `EuiFlyoutChild` allows side-by-side
(grouped) flyout panels (elastic/eui#8771)
- **Accessibility fixes:**
- `EuiComboBox` now supports custom option `id`s
(elastic/eui#8829)
- Updates on `EuiProgress` are properly announced by screen readers
(elastic/eui#8839)
- **Icon updates** (breaking change): `iInCircle` and `questionInCircle`
icons have been renamed to `info` and `question` respectively
(elastic/eui#8841)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Lene Gadewoll <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@acstll @elasticmachine
@mgadewoll @kertal
Upgrade EUI to v105.0.0 (elastic#226882)
aba9a87 
`104.1.0` ⏩ `105.0.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

### `@elastic/eui`

#### [`v105.0.0`](https://github.com/elastic/eui/releases/v105.0.0)

- Added marked row styling via the classes `euiDataGridRow--marked` and
`euiTableRow--marked` for `EuiDataGrid` and `EuiBasicTable`
([elastic#8834](elastic/eui#8834))
- Added component tokens:
([elastic#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`
- Added `EuiFlyoutChild` and `EuiFlyoutSessionProvider`
([elastic#8771](elastic/eui#8771))
- Added `setListOptionRefs` prop on `EuiComboBoxList`
([elastic#8829](elastic/eui#8829))

**Breaking changes**

- Removed `iInCircle` icon (use `info` instead)
([elastic#8841](elastic/eui#8841))
- Removed `questionInCircle` icon (use `question` instead)
([elastic#8841](elastic/eui#8841))

**Accessibility**

- Improved the experience of `EuiProgress` by ensuring that determinate
updates are read out immediately to screen readers
([elastic#8839](elastic/eui#8839))
- Fixed missing screen reader output for `EuiComboBox` with `options`
that have custom `id` attributes
([elastic#8829](elastic/eui#8829))

### `@elastic/eui-theme-borealis`

####
[`v3.2.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v320)

- Added component tokens:
([elastic#8834](elastic/eui#8834))
  - `dataGridRowBackgroundMarked`
  - `dataGridRowBackgroundMarkedHover`
  - `dataGridRowBorderActive`
  - `dataGridRowBorderHover`
  - `dataGridRowBorderMarked`
  - `tableRowBackgroundMarked`
  - `tableRowBackgroundMarkedHover`

## Summary

- **Marked row styling** for `EuiDataGrid` and `EuiBasicTable`: new CSS
classes are available for consistent styling of marked rows (different
from selected), including hover and cell outline styles
(elastic/eui#8834)
- **New flyout component**: `EuiFlyoutChild` allows side-by-side
(grouped) flyout panels (elastic/eui#8771)
- **Accessibility fixes:**
- `EuiComboBox` now supports custom option `id`s
(elastic/eui#8829)
- Updates on `EuiProgress` are properly announced by screen readers
(elastic/eui#8839)
- **Icon updates** (breaking change): `iInCircle` and `questionInCircle`
icons have been renamed to `info` and `question` respectively
(elastic/eui#8841)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Lene Gadewoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weronikaolejniczak weronikaolejniczak weronikaolejniczak approved these changes

Assignees

No one assigned

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ek-so @elasticmachine @weronikaolejniczak