Skip to content

[9.1] Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)#228557

Merged
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-226787
Jul 18, 2025
Merged

[9.1] Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule (#226787)#228557
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-226787

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…SLint rule (elastic#226787)

## Summary
This PR applies the auto-fix for the newly introduced
`@elastic/eui/consistent-is-invalid-props` ESLint rule across the
codebase. The rule ensures consistent validation state handling between
`EuiFormRow` components and their child form controls.

## Changes
- Auto-fixed instances where `isInvalid` prop values were inconsistent
between parent `EuiFormRow` components and their form control children

## Related
- elastic/eui#8843

---------

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 00082ef)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 18, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) July 18, 2025 08:26
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine kibanamachine merged commit 1935851 into elastic:9.1 Jul 18, 2025
22 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +147.0B
automaticImport 1.1MB 1.1MB +5.0B
cases 1.3MB 1.3MB +24.0B
contentConnectors 470.0KB 470.0KB +28.0B
datasetQuality 420.9KB 421.0KB +134.0B
dataViewFieldEditor 99.5KB 99.6KB +28.0B
dataVisualizer 681.3KB 681.3KB +38.0B
discover 1.1MB 1.1MB +134.0B
enterpriseSearch 1.1MB 1.1MB +53.0B
fileUpload 644.6KB 644.6KB +29.0B
fleet 2.1MB 2.1MB +283.0B
imageEmbeddable 110.3KB 110.3KB +14.0B
indexLifecycleManagement 161.9KB 161.9KB +14.0B
indexManagement 673.2KB 673.3KB +96.0B
infra 1.0MB 1.0MB +268.0B
ingestPipelines 359.7KB 359.7KB +12.0B
lens 1.5MB 1.5MB +37.0B
lists 124.7KB 124.7KB +27.0B
ml 5.4MB 5.4MB +918.0B
monitoring 630.7KB 631.0KB +252.0B
observability 1.3MB 1.3MB +134.0B
osquery 1.0MB 1.0MB +121.0B
searchInferenceEndpoints 92.3KB 92.3KB +12.0B
searchQueryRules 121.1KB 121.2KB +78.0B
securitySolution 9.8MB 9.8MB +427.0B
serverlessSearch 346.6KB 346.6KB +21.0B
slo 987.5KB 987.7KB +177.0B
snapshotRestore 249.2KB 249.9KB +662.0B
stackConnectors 614.3KB 614.6KB +367.0B
streamsApp 583.2KB 583.2KB +12.0B
synthetics 1.0MB 1.0MB +564.0B
transform 624.1KB 624.3KB +198.0B
triggersActionsUi 1.5MB 1.5MB +173.0B
uptime 491.2KB 491.4KB +176.0B
total +5.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 89.2KB 89.2KB +12.0B
fleet 168.9KB 168.9KB +14.0B
indexLifecycleManagement 26.5KB 26.5KB +14.0B
visDefaultEditor 30.0KB 30.0KB -11.0B
total +29.0B

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants