[Streams] Significant events view by dgieselaar · Pull Request #220197 · elastic/kibana

dgieselaar · 2025-05-06T07:47:52Z

Implements a CRUD-ui for significant events. Generated events will follow separately.

…nts-ui-crud

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'

github-actions · 2025-06-09T17:25:31Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kdelemme

I've done a first pass and tested locally, and overall works well.

Just a few comments around the indices used and the feature flag used for the tabs.

kdelemme · 2025-06-09T18:50:17Z

...plugins/shared/streams_app/public/components/stream_detail_significant_events_view/index.tsx

+        setQueryToEdit(undefined);
+      }}
+      query={queryToEdit}
+      name={definition?.stream.name ?? ''}


should not be undefined

kdelemme · 2025-06-09T18:50:42Z

...plugins/shared/streams_app/public/components/stream_detail_significant_events_view/index.tsx

+                {i18n.translate('xpack.streams.significantEvents.addSignificantEventButton', {
+                  defaultMessage: 'Add significant event query',
+                })}
+              </EuiButton>{' '}


Suggested change

</EuiButton>{' '}

</EuiButton>

kdelemme · 2025-06-09T18:51:02Z

...plugins/shared/streams_app/public/components/stream_detail_significant_events_view/index.tsx

+
+        <EuiFlexItem grow={false}>
+          <SignificantEventsTable
+            name={definition?.stream.name}


should be defined

kdelemme · 2025-06-09T19:11:34Z

x-pack/platform/plugins/shared/streams_app/public/components/stream_detail_view/index.tsx

+  const tabs =
+    features.significantEvents !== undefined
+      ? getStreamDetailTabs({ definition, router, features })
+      : undefined;


shouldn't it be

Suggested change

const tabs =

features.significantEvents !== undefined

? getStreamDetailTabs({ definition, router, features })

: undefined;

const tabs = getStreamDetailTabs({ definition, router, features });

I don't want the tabs to be displayed at all until we know whether sig events is available or not (which is async due to the license), otherwise there's a content change (2 tabs => 3 tabs) which I'd like to avoid.

kdelemme · 2025-06-09T19:36:07Z

...lugins/shared/streams/server/routes/streams/significant_events/preview_significant_events.ts

+  });
+
+  const response = (await scopedClusterClient.asCurrentUser.search({
+    index: name,


I think the preview should query child streams as well, since the ES|QL query searches them

Suggested change

index: name,

index: `${name},${name}.*`,

cheers, now calling a helper function that was already used in other places

kdelemme · 2025-06-09T19:40:43Z

...treams_app/public/components/stream_detail_significant_events_view/utils/discover_helpers.ts

+    },
+    dataViewSpec: {
+      id: v4(),
+      title: name,


same here when building the data view, we should include the child

Suggested change

title: name,

title: `${name},${name}.*`,

…nts-ui-crud

…bana into significant-events-ui-crud

…bana; branch 'main' of github.com:elastic/kibana into significant-events-ui-crud

dgieselaar · 2025-06-12T07:01:58Z

@elasticmachine merge upstream

…nts-ui-crud

kdelemme · 2025-07-03T15:21:33Z

@elastic/core-docs Can we get a review?

…nts-ui-crud

…bana into significant-events-ui-crud

elasticmachine · 2025-07-07T09:27:15Z

💚 Build Succeeded

Buildkite Build
Commit: 3ba7d81
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-220197-3ba7d819feb4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`streamsApp`	471	497	+26

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/streams-schema`	231	239	+8
`streams`	24	25	+1
total			+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`streamsApp`	556.8KB	577.9KB	+21.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/streams-schema`	16	15	-1
`streams`	26	27	+1
total			-0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`streams`	7.5KB	7.5KB	+22.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/streams-schema`	240	248	+8
`streams`	25	26	+1
total			+9

async chunk count

id	before	after	diff
`streamsApp`	19	21	+2

ESLint disabled line counts

id	before	after	diff
`streams`	3	4	+1

miscellaneous assets size

id	before	after	diff
`streamsApp`	304.0KB	349.6KB	+45.7KB

Total ESLint disabled count

id	before	after	diff
`streams`	7	8	+1

History

💚 Build #315511 succeeded f0485ae
💚 Build #315427 succeeded 75de44c
💛 Build #314312 was flaky fc7fbea
💔 Build #314215 failed 17fd864
💛 Build #314119 was flaky 5c1b076

cc @dgieselaar

kibanamachine · 2025-07-07T11:37:40Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16115871167

kibanamachine · 2025-07-07T11:37:58Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16115875291

kibanamachine · 2025-07-07T11:44:10Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.1	Backport failed because of merge conflicts You might need to backport the following PRs to 9.1: - [scout] adding ESLint rules for test package imports (#225791)

Manual backport

To create the backport manually run:

node scripts/backport --pr 220197

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2025-07-07T11:44:33Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.1	Backport failed because of merge conflicts You might need to backport the following PRs to 9.1: - [scout] adding ESLint rules for test package imports (#225791)

Manual backport

To create the backport manually run:

node scripts/backport --pr 220197

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2025-07-08T11:48:47Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 220197 locally
cc: @dgieselaar

kibanamachine · 2025-07-09T10:52:17Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16167374277

Implements a CRUD-ui for significant events. Generated events will follow separately. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co> (cherry picked from commit 1458854)

kibanamachine · 2025-07-09T10:58:52Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
✅	9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 220197

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `9.1`: - [[Streams] Significant events view (#220197)](#220197)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>

Implements a CRUD-ui for significant events. Generated events will follow separately. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>

[Streams] Significant events view

163c0db

dgieselaar self-assigned this May 6, 2025

dgieselaar added release_note:enhancement backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project v9.1.0 v8.19.0 labels May 6, 2025

dgieselaar and others added 6 commits June 8, 2025 15:19

Merge branch 'main' of github.com:elastic/kibana into significant-eve…

8060794

…nts-ui-crud

Fix type issues

55120bb

Expose feature flag to browser

6315313

Refactor

44f2884

Merge branch 'main' of github.com:elastic/kibana into significant-eve…

bca6a43

…nts-ui-crud

dgieselaar marked this pull request as ready for review June 9, 2025 17:23

dgieselaar requested review from a team as code owners June 9, 2025 17:23

jbudz approved these changes Jun 9, 2025

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 9, 2025

[CI] Auto-commit changed files from 'make api-docs'

c9aeaef

kdelemme reviewed Jun 9, 2025

View reviewed changes

dgieselaar added 4 commits June 10, 2025 09:29

Review feedback

67faed6

Merge branch 'main' of github.com:elastic/kibana into significant-eve…

4ac8127

…nts-ui-crud

Merge branch 'significant-events-ui-crud' of github.com:dgieselaar/ki…

63936ad

…bana into significant-events-ui-crud

Merge branch 'significant-events-ui-crud' of github.com:dgieselaar/ki…

b7b5f6f

…bana; branch 'main' of github.com:elastic/kibana into significant-events-ui-crud

Merge branch 'main' into significant-events-ui-crud

3d5d469

viduni94 approved these changes Jul 2, 2025

View reviewed changes

dgieselaar and others added 3 commits July 3, 2025 14:44

Merge branch 'main' of github.com:elastic/kibana into significant-eve…

7039258

…nts-ui-crud

Fix formatting

75de44c

Fix query input not displayed on first render

f0485ae

dgieselaar added 3 commits July 7, 2025 10:06

Merge branch 'main' of github.com:elastic/kibana into significant-eve…

bb02780

…nts-ui-crud

Make sure page doesn't crash while license etc is loading

64cb201

Merge branch 'significant-events-ui-crud' of github.com:dgieselaar/ki…

3ba7d81

…bana into significant-events-ui-crud

dgieselaar merged commit 1458854 into elastic:main Jul 7, 2025
12 checks passed

kibanamachine added the v9.2.0 label Jul 7, 2025

kibanamachine mentioned this pull request Jul 7, 2025

chore(security, tests): Add testCategory to cookie and shard missing tests #226786

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 8, 2025

kibanamachine mentioned this pull request Jul 9, 2025

[Streams 🌊] Prevent routing simulation timeout and improve cancellations #226374

Merged

tonyghiani added backport:version Backport to applied version labels and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Jul 9, 2025

kibanamachine mentioned this pull request Jul 9, 2025

[9.1] [Streams] Significant events view (#220197) #227207

Merged

dgieselaar added backport:skip This PR does not require backporting and removed v8.19.0 labels Jul 11, 2025

Conversation

dgieselaar commented May 6, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 9, 2025

🤖 GitHub comments

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgieselaar commented Jun 12, 2025

Uh oh!

kdelemme commented Jul 3, 2025

Uh oh!

elasticmachine commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

History

Uh oh!

Uh oh!

kibanamachine commented Jul 7, 2025

Uh oh!

kibanamachine commented Jul 7, 2025

Uh oh!

kibanamachine commented Jul 7, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jul 7, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jul 8, 2025

Uh oh!

kibanamachine commented Jul 9, 2025

Uh oh!

kibanamachine commented Jul 9, 2025

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

dgieselaar commented May 6, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Jul 7, 2025 •

edited

Loading