[scout] adding ESLint rules for test package imports#225791
Merged
dmlemeshko merged 12 commits intoelastic:mainfrom Jul 2, 2025
Merged
[scout] adding ESLint rules for test package imports#225791dmlemeshko merged 12 commits intoelastic:mainfrom
dmlemeshko merged 12 commits intoelastic:mainfrom
Conversation
csr
reviewed
Jun 30, 2025
dmlemeshko
added
v9.1.0
v8.19.0
v9.2.0
release_note:skip
dmlemeshko
force-pushed
the
scout/add-eslint-rules
branch
from
4f0625c to
e6f8960
Compare
Contributor
Author
I believe it works as expected now, I will push an update for this file |
Contributor
Author
|
@csr based on this error I think we are already guarded from solution packages being imported in |
Member
|
✅ Importing
✅ Importing
✅ I can see the error you reported in your last comment when importing the Scout Observability package in a platform test:
✅ Importing Playwright in an observability test throws an error:
|
csr
approved these changes
Jul 1, 2025
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
csr
approved these changes
Jul 1, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
cc @dmlemeshko |
jbudz
approved these changes
Jul 1, 2025
cesco-f
approved these changes
Jul 2, 2025
Contributor
cesco-f
left a comment
cesco-f
left a comment
There was a problem hiding this comment.
Changes in x-pack/solutions/observability/plugins/observability/tsconfig.json and x-pack/solutions/observability/plugins/observability/ui_tests/fixtures/generators.ts LGTM.
flash1293
approved these changes
Jul 2, 2025
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Just adding a comma, what could go wrong?
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16019965408 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 2, 2025
## Summary
Adding ESLint rules to control the proper test package is used for
testing:
- platform tests should import only from `@kbn/scout`
- solution tests should import only from solution-specific scout package
(e.g. security plugins => `@kbn/scout-security`)
example:
```
ERROR
/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts
7:1 error '@kbn/scout' import is restricted from being used by a pattern.
Observability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports
✖ 1 problem (1 error, 0 warnings)
```
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4c6ab87)
# Conflicts:
# x-pack/solutions/observability/plugins/observability/tsconfig.json
# x-pack/solutions/observability/plugins/observability/ui_tests/fixtures/generators.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 2, 2025
## Summary
Adding ESLint rules to control the proper test package is used for
testing:
- platform tests should import only from `@kbn/scout`
- solution tests should import only from solution-specific scout package
(e.g. security plugins => `@kbn/scout-security`)
example:
```
ERROR
/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts
7:1 error '@kbn/scout' import is restricted from being used by a pattern.
Observability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports
✖ 1 problem (1 error, 0 warnings)
```
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4c6ab87)
# Conflicts:
# x-pack/platform/plugins/shared/streams_app/tsconfig.json
# x-pack/solutions/observability/plugins/observability/tsconfig.json
# x-pack/solutions/observability/plugins/observability/ui_tests/fixtures/generators.ts
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
dmlemeshko
added a commit
that referenced
this pull request
Jul 7, 2025
…226138) # Backport This will backport the following commits from `main` to `9.1`: - [[scout] adding ESLint rules for test package imports (#225791)](#225791) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T08:23:16Z","message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","test:scout","v9.1.0","v8.19.0","v9.2.0"],"title":"[scout] adding ESLint rules for test package imports","number":225791,"url":"https://github.com/elastic/kibana/pull/225791","mergeCommit":{"message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225791","number":225791,"mergeCommit":{"message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
Jul 7, 2025
…#226146) # Backport This will backport the following commits from `main` to `8.19`: - [[scout] adding ESLint rules for test package imports (#225791)](#225791) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T08:23:16Z","message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","test:scout","v9.1.0","v8.19.0","v9.2.0"],"title":"[scout] adding ESLint rules for test package imports","number":225791,"url":"https://github.com/elastic/kibana/pull/225791","mergeCommit":{"message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226138","number":226138,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225791","number":225791,"mergeCommit":{"message":"[scout] adding ESLint rules for test package imports (#225791)\n\n## Summary\n\nAdding ESLint rules to control the proper test package is used for\ntesting:\n\n- platform tests should import only from `@kbn/scout`\n- solution tests should import only from solution-specific scout package\n(e.g. security plugins => `@kbn/scout-security`)\n\n\nexample: \n\n```\nERROR\n/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts\n 7:1 error '@kbn/scout' import is restricted from being used by a pattern.\nObservability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports\n\n ✖ 1 problem (1 error, 0 warnings)\n```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4c6ab87ddf409ca92db7f8278a851e3751c6bb99"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary
Adding ESLint rules to control the proper test package is used for
testing:
- platform tests should import only from `@kbn/scout`
- solution tests should import only from solution-specific scout package
(e.g. security plugins => `@kbn/scout-security`)
example:
```
ERROR
/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts
7:1 error '@kbn/scout' import is restricted from being used by a pattern.
Observability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports
✖ 1 problem (1 error, 0 warnings)
```
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding ESLint rules to control the proper test package is used for testing:
@kbn/scout@kbn/scout-security)example: