[9.1] [scout] adding ESLint rules for test package imports (#225791)#226138
Merged
dmlemeshko merged 5 commits intoelastic:9.1from Jul 7, 2025
Merged
[9.1] [scout] adding ESLint rules for test package imports (#225791)#226138dmlemeshko merged 5 commits intoelastic:9.1from
dmlemeshko merged 5 commits intoelastic:9.1from
Conversation
## Summary
Adding ESLint rules to control the proper test package is used for
testing:
- platform tests should import only from `@kbn/scout`
- solution tests should import only from solution-specific scout package
(e.g. security plugins => `@kbn/scout-security`)
example:
```
ERROR
/Users/dmle/github/kibana/x-pack/solutions/observability/plugins/apm/ui_tests/parallel_tests/service_inventory/service_inventory.spec.ts
7:1 error '@kbn/scout' import is restricted from being used by a pattern.
Observability solution tests should import from '@kbn/scout-oblt' instead no-restricted-imports
✖ 1 problem (1 error, 0 warnings)
```
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4c6ab87)
# Conflicts:
# x-pack/solutions/observability/plugins/observability/tsconfig.json
# x-pack/solutions/observability/plugins/observability/ui_tests/fixtures/generators.ts
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
fake-haris
approved these changes
Jul 7, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation