Skip to content

Comments

Remove playwright-chromium package from dependencies#225221

Merged
mykolaharmash merged 1 commit intoelastic:mainfrom
mykolaharmash:remove-playwright-chromium
Jun 25, 2025
Merged

Remove playwright-chromium package from dependencies#225221
mykolaharmash merged 1 commit intoelastic:mainfrom
mykolaharmash:remove-playwright-chromium

Conversation

@mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Jun 25, 2025 •
edited
Loading

This change remove playwright-chromium package from Kibana dependencies.

  • The package isn't used anywhere in the codebase
  • The package conflicts with @playwright/test by installing the same playwright executable which then misses a bunch of features, including the test command

@mykolaharmash mykolaharmash added ci:scout-ui-tests Run Scout UI tests release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jun 25, 2025
@mykolaharmash mykolaharmash force-pushed the remove-playwright-chromium branch from b243d36 to 4dd2e9d Compare June 25, 2025 08:47
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 25, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@dmlemeshko dmlemeshko requested review from Copilot and dmlemeshko June 25, 2025 11:33
Copilot AI reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR removes the unused playwright-chromium dependency to eliminate conflicts with @playwright/test and streamline the codebase.

  • Deleted the playwright-chromium entry from dependencies in package.json
Comments suppressed due to low confidence (1)

package.json:1905

  • Please regenerate the lockfile (e.g., package-lock.json or yarn.lock) after removing this dependency to avoid orphaned entries and ensure reproducible installs.
    "playwright": "1.53.1",

dmlemeshko
dmlemeshko approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mykolaharmash 👏

@mykolaharmash mykolaharmash added backport:skip This PR does not require backporting backport:version Backport to applied version labels v9.0.4 and removed backport:skip This PR does not require backporting labels Jun 25, 2025
@mykolaharmash mykolaharmash merged commit 4250dfb into elastic:main Jun 25, 2025
20 checks passed
mykolaharmash added a commit to mykolaharmash/kibana that referenced this pull request Jun 25, 2025
@mykolaharmash
Remove playwright-chromium package from dependencies (elastic#225221)
156f47a 
This change remove `playwright-chromium` package from Kibana
dependencies.
* The package isn't used anywhere in the codebase
* The package conflicts with `@playwright/test` by installing the same
`playwright` executable which then misses a bunch of features, including
the `test` command

(cherry picked from commit 4250dfb)

# Conflicts:
#	package.json
#	yarn.lock
@mykolaharmash mykolaharmash mentioned this pull request Jun 25, 2025
Closed
@mykolaharmash
Copy link
Contributor Author

mykolaharmash commented Jun 25, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Jun 26, 2025
Merged
Merged
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

3 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 2, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine kibanamachine mentioned this pull request Jul 3, 2025
Merged
1 task
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 3, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine kibanamachine mentioned this pull request Jul 21, 2025
Merged
1 task
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 21, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

23 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 22, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 23, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 25, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 28, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 29, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 30, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 1, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 5, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 6, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 7, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 8, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 11, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 12, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 13, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 14, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 15, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 18, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 19, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 20, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 21, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 22, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @mykolaharmash

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 26, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225221 locally
cc: @mykolaharmash

@mykolaharmash mykolaharmash added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:scout-ui-tests Run Scout UI tests release_note:skip Skip the PR/issue when compiling release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mykolaharmash @elasticmachine @kibanamachine @dmlemeshko