Skip to content

Comments

[SecuritySolution] Render the security solution's default empty page when no index is available#225282

Merged
machadoum merged 1 commit intoelastic:mainfrom
machadoum:siem-ea-privmon-page-no-index
Jun 26, 2025
Merged

[SecuritySolution] Render the security solution's default empty page when no index is available#225282
machadoum merged 1 commit intoelastic:mainfrom
machadoum:siem-ea-privmon-page-no-index

Conversation

@machadoum
Copy link
Member

@machadoum machadoum commented Jun 25, 2025 •
edited by kibanamachine
Loading

Render the EmptyPrompt from the priv mon page if no index is available.

@machadoum machadoum self-assigned this Jun 25, 2025
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team backport:version Backport to applied version labels v9.0.1 labels Jun 25, 2025
@machadoum machadoum marked this pull request as ready for review June 25, 2025 12:50
@machadoum machadoum requested a review from a team as a code owner June 25, 2025 12:50
@machadoum machadoum requested a review from hop-dev June 25, 2025 12:50
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 25, 2025

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 25, 2025

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

CAWilson94
CAWilson94 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! 🚀

lgestc
lgestc reviewed Jun 25, 2025
View reviewed changes
..._solution/public/entity_analytics/pages/entity_analytics_privileged_user_monitoring_page.tsx

const sourcererDataView = newDataViewPickerEnabled ? dataViewSpec : oldSourcererDataView;
const isSourcererLoading = useMemo(
() => (newDataViewPickerEnabled ? status !== 'ready' : oldIsSourcererLoading),
Copy link
Contributor

@lgestc lgestc Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the status is error?

Copy link
Member Author

@machadoum machadoum Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page will load normally, but many functionalities won't work correctly.

I copied and pasted this from other pages. Most security solution pages have the same issue. Most of them have the some form of newDataViewPickerEnabled logic duplicated.

lgestc
lgestc reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long term solution we are working for - has type safe hooks that will not require us to check loading / undefined state every time #225111

tiansivive
tiansivive approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machadoum machadoum merged commit 6a791fa into elastic:main Jun 26, 2025
27 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 26, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/15900371619

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 26, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- Remove playwright-chromium package from dependencies (#225221)
- Adds missing model Claude 3.7 to accepted models (#224943)

Manual backport

To create the backport manually run:

node scripts/backport --pr 225282

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jun 26, 2025
Merged
@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Jun 26, 2025

@machadoum I'm just seeing that you put a backport to v9.0.1 version, but shouldn't it be v8.19.0?

@kibanamachine kibanamachine mentioned this pull request Jun 26, 2025
Merged
@machadoum machadoum removed the v9.0.1 label Jun 27, 2025
@machadoum
Copy link
Member Author

machadoum commented Jun 27, 2025

Hey @PhilippeOberti, it was supposed to be v9.1.0 instead of v9.0.1. Luckily, the backport failed 😰

@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Jun 27, 2025

Hey @PhilippeOberti, it was supposed to be v9.1.0 instead of v9.0.1. Luckily, the backport failed 😰

We probably want this on 8.19 also no?

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@machadoum
Copy link
Member Author

machadoum commented Jun 30, 2025

@PhilippeOberti The privileged monitoring page is being released on 9.1.0. So we don't need to backport the fix to previous versions.

@machadoum machadoum removed the backport:version Backport to applied version labels label Jun 30, 2025
@machadoum
Copy link
Member Author

machadoum commented Jun 30, 2025

I removed the backport:version tag because the bot is confused

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

4 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@machadoum machadoum removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 8, 2025
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

3 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225282 locally
cc: @machadoum

@PhilippeOberti PhilippeOberti added the backport:skip This PR does not require backporting label Jul 14, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgestc lgestc lgestc left review comments

@tiansivive tiansivive tiansivive approved these changes

@CAWilson94 CAWilson94 CAWilson94 approved these changes

@hop-dev hop-dev Awaiting requested review from hop-dev hop-dev is a code owner automatically assigned from elastic/security-entity-analytics

Assignees

@machadoum machadoum

Labels

backport:skip This PR does not require backporting Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@machadoum @elasticmachine @kibanamachine @PhilippeOberti @tiansivive @CAWilson94 @lgestc