Skip to content

Comments

[Discover][Oblt] Enable Attributes tab by default#224894

Merged
kpatticha merged 6 commits intoelastic:mainfrom
kpatticha:224883-enable-attributes-tab
Jun 25, 2025
Merged

[Discover][Oblt] Enable Attributes tab by default#224894
kpatticha merged 6 commits intoelastic:mainfrom
kpatticha:224883-enable-attributes-tab

Conversation

@kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jun 23, 2025 •
edited by kibanamachine
Loading

Summary

closes #224883

@kpatticha kpatticha requested a review from a team as a code owner June 23, 2025 14:56
@kpatticha kpatticha requested a review from a team June 23, 2025 14:56
@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 23, 2025
@kpatticha kpatticha requested a review from a team as a code owner June 24, 2025 09:19
@kpatticha kpatticha enabled auto-merge (squash) June 24, 2025 17:15
davismcphee
davismcphee approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM, although if the attributes tab is no longer experimental, it's probably best to just move getDocViewer directly into the main o11y root profile. It's not really needed anymore since it was just to allow the attributes tab to remain disabled in prod while in development.

...ty/observability_root_profile/sub_profiles/observability_root_profile_with_attributes_tab.ts
extendProfileProvider(observabilityRootProfileProvider, {
profileId: 'observability-root-profile-with-attributes-tab',
isExperimental: true,
isExperimental: false,
Copy link
Contributor

@davismcphee davismcphee Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isExperimental: false,

Nit: this can be dropped entirely.

@kpatticha
Copy link
Contributor Author

kpatticha commented Jun 25, 2025

Data Discovery changes LGTM, although if the attributes tab is no longer experimental, it's probably best to just move getDocViewer directly into the main o11y root profile. It's not really needed anymore since it was just to allow the attributes tab to remain disabled in prod while in development.

Good point. As we're around FF I will merge this PR as it is and create a follow up to clean up

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 25, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / serverless observability UI - telemetry discover/observabilitySolution/context_awareness/telemetry telemetry contextual profiles should send EBT events when a different data source profile gets resolved
  • [job] [logs] FTR Configs #49 / serverless observability UI - telemetry discover/observabilitySolution/context_awareness/telemetry telemetry contextual profiles should send EBT events when a different data source profile gets resolved
  • [job] [logs] FTR Configs #47 / Stateful Observability - Deployment-agnostic API integration tests SyntheticsAPITests EnableDefaultAlerting deletes (and recreates) the default rule when settings are updated

History

@kpatticha kpatticha merged commit 0e932d0 into elastic:main Jun 25, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 25, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15878022474

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 25, 2025
@kpatticha
[Discover][Oblt] Enable Attributes tab by default (elastic#224894)
5dd520d 
## Summary

closes elastic#224883

(cherry picked from commit 0e932d0)
@kibanamachine kibanamachine mentioned this pull request Jun 25, 2025
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 25, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kpatticha kpatticha mentioned this pull request Jun 26, 2025
Closed
This was referenced Jun 26, 2025
Merged
Merged
@kpatticha kpatticha mentioned this pull request Jun 27, 2025
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @kpatticha

kpatticha added a commit that referenced this pull request Jun 30, 2025
@kpatticha
[Discover][Oblt] Move getDocViewer into the main observability root…
55b1ef5 
… profile (#225610)

close #225408
## Summary

Follow on
#224894 (comment)

Since the Attributes tab is now enabled by default, the separate
observability-root-profile-with-attributes-tab profile is no longer
needed. Moved getDocViewer into the main observability root profile to
simplify the code.

Functionality remains unchanged; this is a code cleanup.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2025
@kpatticha
[Discover][Oblt] Move getDocViewer into the main observability root…
e821d85 
… profile (elastic#225610)

close elastic#225408
## Summary

Follow on
elastic#224894 (comment)

Since the Attributes tab is now enabled by default, the separate
observability-root-profile-with-attributes-tab profile is no longer
needed. Moved getDocViewer into the main observability root profile to
simplify the code.

Functionality remains unchanged; this is a code cleanup.

(cherry picked from commit 55b1ef5)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2025
@kpatticha
[Discover][Oblt] Move getDocViewer into the main observability root…
6fe309f 
… profile (elastic#225610)

close elastic#225408
## Summary

Follow on
elastic#224894 (comment)

Since the Attributes tab is now enabled by default, the separate
observability-root-profile-with-attributes-tab profile is no longer
needed. Moved getDocViewer into the main observability root profile to
simplify the code.

Functionality remains unchanged; this is a code cleanup.

(cherry picked from commit 55b1ef5)
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @kpatticha

kibanamachine added a commit that referenced this pull request Jun 30, 2025
@kibanamachine @kpatticha
[9.1] [Discover][Oblt] Move getDocViewer into the main observabilit…
4e60f15 
…y root profile (#225610) (#225858)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Discover][Oblt] Move `getDocViewer` into the main observability root
profile (#225610)](#225610)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:56:19Z","message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][Oblt]
Move `getDocViewer` into the main observability root
profile","number":225610,"url":"https://github.com/elastic/kibana/pull/225610","mergeCommit":{"message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225610","number":225610,"mergeCommit":{"message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kpatticha added a commit that referenced this pull request Jul 1, 2025
@kpatticha
[8.19] [Discover][Oblt] Move getDocViewer into the main observabili…
4ecfb3b 
…ty root profile (#225610) (#225860)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Discover][Oblt] Move `getDocViewer` into the main observability root
profile (#225610)](#225610)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:56:19Z","message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][Oblt]
Move `getDocViewer` into the main observability root
profile","number":225610,"url":"https://github.com/elastic/kibana/pull/225610","mergeCommit":{"message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/225858","number":225858,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225610","number":225610,"mergeCommit":{"message":"[Discover][Oblt]
Move `getDocViewer` into the main observability root profile
(#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n##
Summary\n\nFollow
on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince
the Attributes tab is now enabled by default, the
separate\nobservability-root-profile-with-attributes-tab profile is no
longer\nneeded. Moved getDocViewer into the main observability root
profile to\nsimplify the code.\n\nFunctionality remains unchanged; this
is a code
cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}}]}]
BACKPORT-->
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @kpatticha

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 2, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

8 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224894 locally
cc: @kpatticha

@kpatticha kpatticha added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.19.0 labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbamparop gbamparop gbamparop approved these changes

@rmyz rmyz rmyz approved these changes

@davismcphee davismcphee davismcphee approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover][OTel] Enable attributes tab by default

7 participants

@kpatticha @elasticmachine @kibanamachine @gbamparop @rmyz @davismcphee @MiriamAparicio