[Discover][Oblt] Move getDocViewer into the main observability root profile#225610
Merged
kpatticha merged 3 commits intoelastic:mainfrom Jun 30, 2025
Merged
[Discover][Oblt] Move getDocViewer into the main observability root profile#225610kpatticha merged 3 commits intoelastic:mainfrom
getDocViewer into the main observability root profile#225610kpatticha merged 3 commits intoelastic:mainfrom
Conversation
kpatticha
added
backport:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
|
davismcphee
approved these changes
Jun 28, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Code-only review, Data Discovery changes LGTM 👍
Just heads up that if this doesn't get backported to 9.1/8.19, telemetry events for those releases will be logged with observability-root-profile-with-attributes-tab for the root profile instead of observability-root-profile, which might be a little annoying to manage. I'm not sure if it technically should be backported post FF, but IMO it's a low risk change that basically amounts to fixing the profile, so I think it would be safe to do if you'd like to avoid this.
Contributor
Author
That make sense. I will backport it |
kpatticha
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/15975833244 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/15975833434 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
… profile (elastic#225610) close elastic#225408 ## Summary Follow on elastic#224894 (comment) Since the Attributes tab is now enabled by default, the separate observability-root-profile-with-attributes-tab profile is no longer needed. Moved getDocViewer into the main observability root profile to simplify the code. Functionality remains unchanged; this is a code cleanup. (cherry picked from commit 55b1ef5)
Contributor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
… profile (elastic#225610) close elastic#225408 ## Summary Follow on elastic#224894 (comment) Since the Attributes tab is now enabled by default, the separate observability-root-profile-with-attributes-tab profile is no longer needed. Moved getDocViewer into the main observability root profile to simplify the code. Functionality remains unchanged; this is a code cleanup. (cherry picked from commit 55b1ef5)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2025
…y root profile (#225610) (#225858) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)](#225610) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:56:19Z","message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile","number":225610,"url":"https://github.com/elastic/kibana/pull/225610","mergeCommit":{"message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225610","number":225610,"mergeCommit":{"message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}}]}] BACKPORT--> Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kpatticha
added a commit
that referenced
this pull request
Jul 1, 2025
…ty root profile (#225610) (#225860) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)](#225610) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:56:19Z","message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile","number":225610,"url":"https://github.com/elastic/kibana/pull/225610","mergeCommit":{"message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/225858","number":225858,"state":"OPEN"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225610","number":225610,"mergeCommit":{"message":"[Discover][Oblt] Move `getDocViewer` into the main observability root profile (#225610)\n\nclose https://github.com/elastic/kibana/issues/225408\n## Summary\n\nFollow on\nhttps://github.com//pull/224894#issuecomment-3004090408\n\nSince the Attributes tab is now enabled by default, the separate\nobservability-root-profile-with-attributes-tab profile is no longer\nneeded. Moved getDocViewer into the main observability root profile to\nsimplify the code.\n\nFunctionality remains unchanged; this is a code cleanup.","sha":"55b1ef515f12f5bc9516143ce51ec07e4ad679dd"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #225408
Summary
Follow on #224894 (comment)
Since the Attributes tab is now enabled by default, the separate observability-root-profile-with-attributes-tab profile is no longer needed. Moved getDocViewer into the main observability root profile to simplify the code.
Functionality remains unchanged; this is a code cleanup.