Skip to content

[Discover][Oblt] Enable Attributes tab by default #224894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpatticha merged 6 commits into from
Jun 25, 2025
Merged

[Discover][Oblt] Enable Attributes tab by default #224894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40a5c81
[Discover][Oblt] Enable Attributes tab by default
kpatticha Jun 23, 2025
ab31af0
Fix test
kpatticha Jun 24, 2025
e52ff42
Fix tests
kpatticha Jun 24, 2025
5cf0c4e
Fix tests
kpatticha Jun 25, 2025
3d16b78
Merge branch 'main' into 224883-enable-attributes-tab
kpatticha Jun 25, 2025
07a8aba
Fix tests again
kpatticha Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...observability_root_profile/sub_profiles/observability_root_profile_with_attributes_tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const createObservabilityRootProfileProviderWithAttributesTab = (
) =>
extendProfileProvider(observabilityRootProfileProvider, {
profileId: 'observability-root-profile-with-attributes-tab',
isExperimental: true,
isExperimental: false,
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isExperimental: false,

Nit: this can be dropped entirely.

profile: {
getDocViewer,
},
Expand Down
8 changes: 4 additions & 4 deletions ...s/functional/test_suites/observability/discover/context_awareness/telemetry/_telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function ({ getService, getPageObjects }: ObservabilityTelemetryF
});

expect(events[events.length - 1].context.discoverProfiles).to.eql([
'observability-root-profile',
'observability-root-profile-with-attributes-tab',
'default-data-source-profile',
]);
});
Expand All @@ -83,7 +83,7 @@ export default function ({ getService, getPageObjects }: ObservabilityTelemetryF
});

expect(events[events.length - 1].context.discoverProfiles).to.eql([
'observability-root-profile',
'observability-root-profile-with-attributes-tab',
'observability-logs-data-source-profile',
]);

Expand Down Expand Up @@ -162,7 +162,7 @@ export default function ({ getService, getPageObjects }: ObservabilityTelemetryF

expect(events[0].properties).to.eql({
contextLevel: 'rootLevel',
profileId: 'observability-root-profile',
profileId: 'observability-root-profile-with-attributes-tab',
});

expect(events[1].properties).to.eql({
Expand Down Expand Up @@ -447,7 +447,7 @@ export default function ({ getService, getPageObjects }: ObservabilityTelemetryF
});

expect(event3.context.discoverProfiles).to.eql([
'observability-root-profile',
'observability-root-profile-with-attributes-tab',
'observability-logs-data-source-profile',
]);
});
Expand Down