[Discover] SCSS to Emotions migration part 3/4#222947
Merged
akowalska622 merged 14 commits intoelastic:mainfrom Jun 16, 2025
Merged
[Discover] SCSS to Emotions migration part 3/4#222947akowalska622 merged 14 commits intoelastic:mainfrom
akowalska622 merged 14 commits intoelastic:mainfrom
Conversation
akowalska622
changed the title
akowalska622
commented
Jun 6, 2025
akowalska622
commented
Jun 6, 2025
akowalska622
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
AlexGPlay
reviewed
Jun 10, 2025
...ugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table_cell_value.test.tsx
Show resolved
Hide resolved
AlexGPlay
approved these changes
Jun 10, 2025
afharo
reviewed
Jun 10, 2025
afharo
approved these changes
Jun 13, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15684515150 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Jun 16, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
akowalska622
added a commit
that referenced
this pull request
Jun 18, 2025
) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] SCSS to Emotions migration part 3/4 (#222947)](#222947) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ania Kowalska","email":"63072419+akowalska622@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-16T15:04:47Z","message":"[Discover] SCSS to Emotions migration part 3/4 (#222947)\n\n## Summary\n\nParent issue: [[DataDiscovery] Replace SCSS with\nCSS-in-JS](https://github.com/elastic/kibana/issues/209807#top)\n\nFollowed [Emotion standards\nguide](https://docs.google.com/document/d/1CPflY8yCc3lZDg2BQkaMTgIkZlqiAEyMcAAvZbsjcTc/edit?pli=1&tab=t.0#heading=h.4zj1jq66y5an)\n\nPart 3 of SCSS -> Emotion migration. Files included:\n\n### Part 3\n- `src/platform/plugins/shared/field_formats/public/index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_html_content_type.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_string.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/json_code_editor/json_code_editor.scss`","sha":"adffdde56d7af029432930638df4b9d2ee523d1f","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","technical debt","release_note:skip","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0"],"title":"[Discover] SCSS to Emotions migration part 3/4","number":222947,"url":"https://github.com/elastic/kibana/pull/222947","mergeCommit":{"message":"[Discover] SCSS to Emotions migration part 3/4 (#222947)\n\n## Summary\n\nParent issue: [[DataDiscovery] Replace SCSS with\nCSS-in-JS](https://github.com/elastic/kibana/issues/209807#top)\n\nFollowed [Emotion standards\nguide](https://docs.google.com/document/d/1CPflY8yCc3lZDg2BQkaMTgIkZlqiAEyMcAAvZbsjcTc/edit?pli=1&tab=t.0#heading=h.4zj1jq66y5an)\n\nPart 3 of SCSS -> Emotion migration. Files included:\n\n### Part 3\n- `src/platform/plugins/shared/field_formats/public/index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_html_content_type.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_string.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/json_code_editor/json_code_editor.scss`","sha":"adffdde56d7af029432930638df4b9d2ee523d1f"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222947","number":222947,"mergeCommit":{"message":"[Discover] SCSS to Emotions migration part 3/4 (#222947)\n\n## Summary\n\nParent issue: [[DataDiscovery] Replace SCSS with\nCSS-in-JS](https://github.com/elastic/kibana/issues/209807#top)\n\nFollowed [Emotion standards\nguide](https://docs.google.com/document/d/1CPflY8yCc3lZDg2BQkaMTgIkZlqiAEyMcAAvZbsjcTc/edit?pli=1&tab=t.0#heading=h.4zj1jq66y5an)\n\nPart 3 of SCSS -> Emotion migration. Files included:\n\n### Part 3\n- `src/platform/plugins/shared/field_formats/public/index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_html_content_type.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/content_types/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_index.scss`\n-\n`src/platform/plugins/shared/field_formats/public/lib/converters/_string.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scss`\n-\n`src/platform/plugins/shared/unified_doc_viewer/public/components/json_code_editor/json_code_editor.scss`","sha":"adffdde56d7af029432930638df4b9d2ee523d1f"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent issue: [DataDiscovery] Replace SCSS with CSS-in-JS
Followed Emotion standards guide
Part 3 of SCSS -> Emotion migration. Files included:
Part 3
src/platform/plugins/shared/field_formats/public/index.scsssrc/platform/plugins/shared/field_formats/public/lib/content_types/_html_content_type.scsssrc/platform/plugins/shared/field_formats/public/lib/content_types/_index.scsssrc/platform/plugins/shared/field_formats/public/lib/converters/_index.scsssrc/platform/plugins/shared/field_formats/public/lib/converters/_string.scsssrc/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_source/source.scsssrc/platform/plugins/shared/unified_doc_viewer/public/components/doc_viewer_table/table.scsssrc/platform/plugins/shared/unified_doc_viewer/public/components/json_code_editor/json_code_editor.scss