[Incident Management] Render suggested dashboards by cesco-f · Pull Request #223424 · elastic/kibana

cesco-f · 2025-06-11T15:17:23Z

This PR closes #221947.

Screen.Recording.2025-06-11.at.17.12.26.mov

The last part of the video is me trying to find the telemetry event fired when clicking the button.

Acceptance Criteria:

The list should appear on the Related Dashboards tab, under the Linked Dashboards ✅
Users should have the ability to add or "promote" a suggested dashboard to the list of linked dashboards stored on this rule, in a single click ✅
We are collecting telemetry so that we know how many times users click the button to promote a suggested dashboard to a linked dashboard ✅

elasticmachine · 2025-06-12T13:44:19Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

… dashboards tab

…cking on the button to add it

…oards only after loading

… dashboard number is increased

…_suggested_dashboards

…he button

…s toast

…ackend

…lated dashboards endpoint

…shboard

mgiota · 2025-06-13T11:06:55Z

Hey @mgiota, it's fixed already here 😊

Yep thanks a lot for this! I am doing the code review now and I see you already fixed it! Cool!

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx

mgiota · 2025-06-13T11:16:59Z

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx

    if (alertDetail) {
      setRuleTypeModel(ruleTypeRegistry.get(alertDetail?.formatted.fields[ALERT_RULE_TYPE_ID]!));
      setAlertStatus(alertDetail?.formatted?.fields[ALERT_STATUS] as AlertStatus);
-      setActiveTabId(OVERVIEW_TAB_ID);


What does this removal exactly do? Why did you remove it? Does it fix something specifically?

I am also curious about this change. This line was added to make sure overview tab is selected when user opens alert details page from "Related alerts" tab.

With that the tabId query parameter in the url is ignored, the user will always land in the overview tab.

Is that the expected behavior?

@cesco-f I noticed this as well while working on my PR and changed the line to be

if (passedTab === OVERVIEW_TAB_ID || passedTab === null) setActiveTabId(OVERVIEW_TAB_ID);

Granted passedTab is a new value added as part of my PR but it's a way to formally track the url state.

mgiota · 2025-06-13T11:18:07Z

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx

    }
  }, [onPageReady, alertDetail, isLoading, activeTabId]);

-  useEffect(() => {


Glad to see all this code being removed in favor of the new api!

mgiota · 2025-06-13T11:19:25Z

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx

+  const tabs: Array<Omit<EuiTabbedContentTab, 'id'> & { id: TabId }> = [
    {
-      id: OVERVIEW_TAB_ID,
+      id: 'overview',


I don't have any strong objection, but why did you replace the consts?

Before this change whenever we wanted to add a new tab we had to:

Create the constant

Use the constant to change the TabId type

Add the constant to the array we use to set the activeTabId

With my change by just adding the new tab string to the TAB_IDS array everything else will be done automatically.

mgiota · 2025-06-13T11:21:47Z

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx

-          },
-        ]
-      : []),
+    {


Before we were not showing the tab if there were no linked dashboards. With this change, I understand we will always show the tab, independent if we have related dashboards or not. Do we handle the empty state and what do we display in this case? I am half way through the review, so I might get the answer!

...rvability/plugins/observability/public/pages/alert_details/components/related_dashboards.tsx

mgiota · 2025-06-13T11:26:39Z

...ns/observability/public/pages/alert_details/components/related_dashboards/dashboard_tile.tsx

+  ruleType: string;
+}
+
+export function DashboardTile({


Is it DashboardTile or maybe you meant to write DashboardTitle?

Nope, I meant to write DashboardTile 😂

Is it not clear what a tile is in this case? I used this naming a lot in my previous job, maybe it's not that clear.

At first glance I thought it might refer to the title only, but it is clear. Just wanted to double check

mgiota · 2025-06-13T11:30:14Z

...s/observability/public/pages/alert_details/components/related_dashboards/dashboard_tiles.tsx

+    return wrapWithHeader(
+      <EuiText>
+        {i18n.translate('xpack.observability.relatedDashboards.noDashboardsTextLabel', {
+          defaultMessage: 'No dashboards',


Related to my comment above, I see you display the text No dashboards, which is fine for now I guess.

Similar to this issue, I think we need design input from @maciejforcone regarding Related Dashboards empty state.

...bility/plugins/observability/public/pages/alert_details/hooks/use_related_dashboards.test.ts

mgiota · 2025-06-13T11:59:45Z

@cesco-f Great work! I tested the feature and it works well! Other than a few comments/questions, I don't have anything blocking this PR.

Maybe I would like us to get @maciejforcone 's input regarding empty state as a follow up PR (similar to the empty state issue for Investigation guide). Here's how it looks right now. Do we want to describe the feature better? We could for example have a notification saying you can edit the rule to manually link dashboards. What do you think?

mgiota

LGTM!

kibanamachine · 2025-06-13T14:31:38Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15637044307

elasticmachine · 2025-06-13T14:32:08Z

💚 Build Succeeded

Buildkite Build
Commit: 14b02cd

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	1305	1308	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	1.3MB	1.3MB	+3.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	93.5KB	93.7KB	+120.0B

History

💚 Build #308179 succeeded 183d707

kibanamachine · 2025-06-13T14:37:44Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [Incident Management] [Related dashboards api] Handle missing lens attributes gracefully (#223619) - [Incident Management] [Suggested dashboards] Deduplicated linked dashboards from list of linked dashboards (#221972)

Manual backport

To create the backport manually run:

node scripts/backport --pr 223424

Questions ?

Please refer to the Backport tool documentation

This PR closes elastic#221947. https://github.com/user-attachments/assets/25beac10-5677-42ef-9544-b3ede0bf9fa1 The last part of the video is me trying to find the telemetry event fired when clicking the button. **Acceptance Criteria:** - The list should appear on the Related Dashboards tab, under the Linked Dashboards ✅ - Users should have the ability to add or "promote" a suggested dashboard to the list of linked dashboards stored on this rule, in a single click ✅ - We are collecting telemetry so that we know how many times users click the button to promote a suggested dashboard to a linked dashboard ✅ --------- Co-authored-by: Dominique Belcher <dominique.clarke@elastic.co>

kibanamachine · 2025-06-17T14:52:11Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 223424 locally
cc: @cesco-f

cesco-f · 2025-06-17T16:07:06Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…224298) # Backport This will backport the following commits from `main` to `8.19`: - [[Incident Management] Render suggested dashboards (#223424)](#223424)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Dominique Belcher <dominique.clarke@elastic.co>

cesco-f added release_note:feature Makes this part of the condensed release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 11, 2025

github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jun 11, 2025

cesco-f force-pushed the render-suggested-dashboards branch 2 times, most recently from 89bc9fa to 9738339 Compare June 12, 2025 09:40

cesco-f marked this pull request as ready for review June 12, 2025 10:01

cesco-f requested a review from a team as a code owner June 12, 2025 10:01

botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jun 12, 2025

cesco-f force-pushed the render-suggested-dashboards branch 2 times, most recently from 0616232 to 1c0f8c3 Compare June 12, 2025 14:11

cesco-f and others added 17 commits June 13, 2025 09:06

feat(suggested dashboards): suggested dashboards are shown in related…

ffc8622

… dashboards tab

feat(add suggested dashboard): added add suggested dashboard button

01975d6

feat(update rule): rule updated with the suggested dashboard when cli…

0e1ef1d

…cking on the button to add it

feat(optimistic update): removed optimistic update

3c871e9

feat(description): returning description for suggested dashboards

0ab9b53

refactor(rename): just renamed some components

137bb1d

fix(linked dashboards): linked dashboards are passed to related dashb…

7ee7e61

…oards only after loading

fix(related dashboard no): promoting a suggested dashboard the linked…

aee698d

… dashboard number is increased

test(hooks): added unit tests for use_add_suggested_dashboard and use…

66bf51b

…_suggested_dashboards

feat(telemetry): added page name and rule type to data-test-subj of t…

d1e0521

…he button

fix(design): changed add to linked dashboards button and added succes…

b0204da

…s toast

test(alert details): added a test in alert details tests

7ac4e6a

fix(suggested dashboards): suggested dashboards are filtered in the b…

34bb04c

…ackend

feat(linked dashboards): linked dashboards are now coming from the re…

e73845d

…lated dashboards endpoint

fix(refetch): dashboards are refetched when a suggested one is promoted

d7c409c

related dashboards api - handle missing dashboards gracefully'

3c95e2d

fix(refetch rule): rule is also refetched after adding a suggested da…

a5f10d2

…shboard

mgiota reviewed Jun 13, 2025

View reviewed changes

...k/solutions/observability/plugins/observability/public/pages/alert_details/alert_details.tsx Outdated Show resolved Hide resolved

mgiota reviewed Jun 13, 2025

View reviewed changes

...rvability/plugins/observability/public/pages/alert_details/components/related_dashboards.tsx Outdated Show resolved Hide resolved

mgiota reviewed Jun 13, 2025

View reviewed changes

...bility/plugins/observability/public/pages/alert_details/hooks/use_related_dashboards.test.ts Outdated Show resolved Hide resolved

fix(cr): cr comments

14b02cd

mgiota approved these changes Jun 13, 2025

View reviewed changes

cesco-f enabled auto-merge (squash) June 13, 2025 13:57

cesco-f merged commit 123091c into elastic:main Jun 13, 2025
10 checks passed

cesco-f deleted the render-suggested-dashboards branch June 13, 2025 14:34

kibanamachine mentioned this pull request Jun 13, 2025

[Observability Alerting] Refetch alert detail rule data on edit flyout submit #222118

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2025

cesco-f mentioned this pull request Jun 17, 2025

[8.19] [Incident Management] Render suggested dashboards (#223424) #224298

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2025

jasonrhodes mentioned this pull request Jun 30, 2025

[Incident Management] Update text for the success callout when linking a suggested dashboard #225914

Closed

mgiota mentioned this pull request Jul 30, 2025

[Rules Management] Use Related Dashboards api in the rule configuration form #229936

Open

benakansara mentioned this pull request Aug 28, 2025

[Internal][Observability][UX Management][9.1/8.19/Serverless]: Document related alerts, related dashboards, and investigation guides elastic/docs-content#2721

Closed

Conversation

cesco-f commented Jun 11, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 12, 2025

Uh oh!

mgiota commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

baileycash-elastic Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cesco-f Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cesco-f Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgiota Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mgiota commented Jun 13, 2025

Uh oh!

mgiota left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 13, 2025

Uh oh!

elasticmachine commented Jun 13, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Jun 13, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Jun 17, 2025

Uh oh!

cesco-f commented Jun 17, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cesco-f commented Jun 11, 2025 •

edited by kibanamachine

Loading

mgiota commented Jun 13, 2025 •

edited

Loading

baileycash-elastic Jun 13, 2025 •

edited

Loading

cesco-f Jun 13, 2025 •

edited

Loading

cesco-f Jun 13, 2025 •

edited

Loading

mgiota Jun 13, 2025 •

edited

Loading