[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully #223619
Merged
dominiqueclarke merged 5 commits intoelastic:mainfrom Jun 12, 2025
Conversation
dominiqueclarke
added
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
github-actions
bot
added
the
author:obs-ux-management
dominiqueclarke
force-pushed
the
fix/related-dashboard-api-gracefully-handle-lens-attributes
branch
from
e22f3a0 to
9aa8c39
Compare
dominiqueclarke
commented
Jun 12, 2025
...k/solutions/observability/plugins/observability/server/services/related_dashboards_client.ts
Outdated
Show resolved
Hide resolved
…rvices/related_dashboards_client.ts
dominiqueclarke
commented
Jun 12, 2025
...k/solutions/observability/plugins/observability/server/services/related_dashboards_client.ts
Outdated
Show resolved
Hide resolved
…rvices/related_dashboards_client.ts
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15622920552 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
…tributes gracefully (elastic#223619) ## Summary Relates to elastic#212125 When a Lens panel is saved to a dashboards, it is either saved by value or by reference. If it's saved by reference, the attributes will not be available. This was creating a reference error when attempting to inspect the lens configuration to make suggestions. This PR confirms that the attributes are available. A follow up PR will fetch the values for the references to include them in the evaluation.
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
Jun 19, 2025
…tributes gracefully (elastic#223619) ## Summary Relates to elastic#212125 When a Lens panel is saved to a dashboards, it is either saved by value or by reference. If it's saved by reference, the attributes will not be available. This was creating a reference error when attempting to inspect the lens configuration to make suggestions. This PR confirms that the attributes are available. A follow up PR will fetch the values for the references to include them in the evaluation. (cherry picked from commit f6da3f2)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dominiqueclarke
added a commit
that referenced
this pull request
Jun 19, 2025
…lens attributes gracefully (#223619) (#224545) # Backport This will backport the following commits from `main` to `8.19`: - [[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully (#223619)](#223619) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2025-06-12T23:32:34Z","message":"[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully (#223619)\n\n## Summary\n\nRelates to https://github.com/elastic/kibana/issues/212125\n\nWhen a Lens panel is saved to a dashboards, it is either saved by value\nor by reference. If it's saved by reference, the attributes will not be\navailable. This was creating a reference error when attempting to\ninspect the lens configuration to make suggestions.\n\nThis PR confirms that the attributes are available. \n\nA follow up PR will fetch the values for the references to include them\nin the evaluation.","sha":"f6da3f2cbc604c73b9d756306cf0226865b544d8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management"],"title":"[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully ","number":223619,"url":"https://github.com/elastic/kibana/pull/223619","mergeCommit":{"message":"[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully (#223619)\n\n## Summary\n\nRelates to https://github.com/elastic/kibana/issues/212125\n\nWhen a Lens panel is saved to a dashboards, it is either saved by value\nor by reference. If it's saved by reference, the attributes will not be\navailable. This was creating a reference error when attempting to\ninspect the lens configuration to make suggestions.\n\nThis PR confirms that the attributes are available. \n\nA follow up PR will fetch the values for the references to include them\nin the evaluation.","sha":"f6da3f2cbc604c73b9d756306cf0226865b544d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223619","number":223619,"mergeCommit":{"message":"[Incident Management] [Related dashboards api] Handle missing lens attributes gracefully (#223619)\n\n## Summary\n\nRelates to https://github.com/elastic/kibana/issues/212125\n\nWhen a Lens panel is saved to a dashboards, it is either saved by value\nor by reference. If it's saved by reference, the attributes will not be\navailable. This was creating a reference error when attempting to\ninspect the lens configuration to make suggestions.\n\nThis PR confirms that the attributes are available. \n\nA follow up PR will fetch the values for the references to include them\nin the evaluation.","sha":"f6da3f2cbc604c73b9d756306cf0226865b544d8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #212125
When a Lens panel is saved to a dashboards, it is either saved by value or by reference. If it's saved by reference, the attributes will not be available. This was creating a reference error when attempting to inspect the lens configuration to make suggestions.
This PR confirms that the attributes are available.
A follow up PR will fetch the values for the references to include them in the evaluation.