Skip to content

[Observability Alerting] Refetch alert detail rule data on edit flyout submit#222118

Merged
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:221428/refetch-on-edit-rule
Jun 13, 2025
Merged

[Observability Alerting] Refetch alert detail rule data on edit flyout submit#222118
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:221428/refetch-on-edit-rule

Conversation

@justinkambic
Copy link
Contributor

@justinkambic justinkambic commented May 30, 2025

Summary

Resolves #221428.

We noticed recently when we added the Investigation Guide that, if the user edits the values in the guide using the edit flyout, the data on the main page will not refresh when they submit.

This patch would add an onUpdate handler prop to the Header Actions component that would enable it to trigger the refresh on the parent component when the user submits the form in the edit flyout.

Example:

20250530164523

@justinkambic justinkambic self-assigned this May 30, 2025
@justinkambic justinkambic requested a review from a team as a code owner May 30, 2025 20:46
@justinkambic justinkambic added release_note:enhancement Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.1.0 v8.19.0 labels May 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label May 30, 2025
@justinkambic justinkambic added the backport:version Backport to applied version labels label May 30, 2025
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic enabled auto-merge (squash) June 13, 2025 13:59
…0.1` to `2.0.2` (elastic#223589)

Bump `brace-expansion` from `1.1.11` to `1.11.12` and `2.0.1` to `2.0.2`.
@justinkambic justinkambic requested review from a team as code owners June 13, 2025 17:52
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Jun 13, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@justinkambic justinkambic force-pushed the 221428/refetch-on-edit-rule branch from 55aed86 to da60f4a Compare June 13, 2025 17:53
@justinkambic justinkambic removed request for a team June 13, 2025 17:53
@justinkambic justinkambic removed Team:Obs AI Assistant Observability AI Assistant ci:project-deploy-observability Create an Observability project labels Jun 13, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 13, 2025

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: da60f4a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-222118-da60f4a522af

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / EQL Tab rendering pagination should load notes for current page only

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +76.0B

History

cc @justinkambic

@justinkambic justinkambic merged commit 1886697 into elastic:main Jun 13, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15642933162

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Incident Management] Render suggested dashboards (#223424)

Manual backport

To create the backport manually run:

node scripts/backport --pr 222118

Questions ?

Please refer to the Backport tool documentation

iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
…t submit (elastic#222118)

## Summary

Resolves elastic#221428.

We noticed recently when we added the Investigation Guide that, if the
user edits the values in the guide using the edit flyout, the data on
the main page will not refresh when they submit.

This patch would add an `onUpdate` handler prop to the Header Actions
component that would enable it to trigger the refresh on the parent
component when the user submits the form in the edit flyout.

Example:


![20250530164523](https://github.com/user-attachments/assets/bd796824-e0d6-464d-b10e-89537d9b590e)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222118 locally
cc: @justinkambic

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222118 locally
cc: @justinkambic

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222118 locally
cc: @justinkambic

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222118 locally
cc: @justinkambic

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222118 locally
cc: @justinkambic

justinkambic added a commit to justinkambic/kibana that referenced this pull request Jun 24, 2025
…t submit (elastic#222118)

## Summary

Resolves elastic#221428.

We noticed recently when we added the Investigation Guide that, if the
user edits the values in the guide using the edit flyout, the data on
the main page will not refresh when they submit.

This patch would add an `onUpdate` handler prop to the Header Actions
component that would enable it to trigger the refresh on the parent
component when the user submits the form in the edit flyout.

Example:

![20250530164523](https://github.com/user-attachments/assets/bd796824-e0d6-464d-b10e-89537d9b590e)

(cherry picked from commit 1886697)
@justinkambic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

justinkambic added a commit that referenced this pull request Jun 24, 2025
…t flyout submit (#222118) (#225131)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Observability Alerting] Refetch alert detail rule data on edit
flyout submit (#222118)](#222118)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2025-06-13T19:58:44Z","message":"[Observability
Alerting] Refetch alert detail rule data on edit flyout submit
(#222118)\n\n## Summary\n\nResolves #221428.\n\nWe noticed recently when
we added the Investigation Guide that, if the\nuser edits the values in
the guide using the edit flyout, the data on\nthe main page will not
refresh when they submit.\n\nThis patch would add an `onUpdate` handler
prop to the Header Actions\ncomponent that would enable it to trigger
the refresh on the parent\ncomponent when the user submits the form in
the edit
flyout.\n\nExample:\n\n\n![20250530164523](https://github.com/user-attachments/assets/bd796824-e0d6-464d-b10e-89537d9b590e)","sha":"188669773e9cc1981b5e89f24afcfdc379ad3058","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport
missing","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management"],"title":"[Observability
Alerting] Refetch alert detail rule data on edit flyout
submit","number":222118,"url":"https://github.com/elastic/kibana/pull/222118","mergeCommit":{"message":"[Observability
Alerting] Refetch alert detail rule data on edit flyout submit
(#222118)\n\n## Summary\n\nResolves #221428.\n\nWe noticed recently when
we added the Investigation Guide that, if the\nuser edits the values in
the guide using the edit flyout, the data on\nthe main page will not
refresh when they submit.\n\nThis patch would add an `onUpdate` handler
prop to the Header Actions\ncomponent that would enable it to trigger
the refresh on the parent\ncomponent when the user submits the form in
the edit
flyout.\n\nExample:\n\n\n![20250530164523](https://github.com/user-attachments/assets/bd796824-e0d6-464d-b10e-89537d9b590e)","sha":"188669773e9cc1981b5e89f24afcfdc379ad3058"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222118","number":222118,"mergeCommit":{"message":"[Observability
Alerting] Refetch alert detail rule data on edit flyout submit
(#222118)\n\n## Summary\n\nResolves #221428.\n\nWe noticed recently when
we added the Investigation Guide that, if the\nuser edits the values in
the guide using the edit flyout, the data on\nthe main page will not
refresh when they submit.\n\nThis patch would add an `onUpdate` handler
prop to the Header Actions\ncomponent that would enable it to trigger
the refresh on the parent\ncomponent when the user submits the form in
the edit
flyout.\n\nExample:\n\n\n![20250530164523](https://github.com/user-attachments/assets/bd796824-e0d6-464d-b10e-89537d9b590e)","sha":"188669773e9cc1981b5e89f24afcfdc379ad3058"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:enhancement Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Alerting] Re-fetch rule information when committing edits on Alert Details page

5 participants