Skip to content

[APM] Add 'logging_level' agent configuration setting for EDOT Node.js#222883

Merged
trentm merged 9 commits intoelastic:mainfrom
trentm:trentm-edot-nodejs-central-config1
Jun 12, 2025
Merged

[APM] Add 'logging_level' agent configuration setting for EDOT Node.js#222883
trentm merged 9 commits intoelastic:mainfrom
trentm:trentm-edot-nodejs-central-config1

Conversation

@trentm
Copy link
Member

@trentm trentm commented Jun 5, 2025

This makes the existing 'logging_level' agent configuration setting
available to EDOT Node.js agents ('opentelemetry/nodejs/elastic').

@trentm trentm self-assigned this Jun 5, 2025
This makes the existing 'logging_level' agent configuration setting
available to EDOT Node.js agents ('opentelemetry/nodejs/elastic').
@trentm trentm force-pushed the trentm-edot-nodejs-central-config1 branch from eefc225 to 7d5432e Compare June 5, 2025 19:55
@trentm trentm marked this pull request as ready for review June 5, 2025 21:02
@trentm trentm requested a review from a team June 5, 2025 21:02
@trentm trentm requested a review from a team as a code owner June 5, 2025 21:02
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jun 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@trentm trentm added backport:version Backport to applied version labels and removed Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Jun 5, 2025
@trentm
Copy link
Member Author

trentm commented Jun 5, 2025

(I'm not confident on my label selection. I was mostly copying what I saw for #219722)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jun 6, 2025
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trentm
Copy link
Member Author

trentm commented Jun 11, 2025

@elasticmachine merge upstream

@trentm
Copy link
Member Author

trentm commented Jun 11, 2025

ping @elastic/obs-ux-logs-team: Would someone be able to review this PR? Thanks.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +93.0B

History

cc @trentm

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay!

@trentm trentm merged commit 056426b into elastic:main Jun 12, 2025
11 checks passed
@trentm trentm deleted the trentm-edot-nodejs-central-config1 branch June 12, 2025 15:25
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15614691552

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222883

Questions ?

Please refer to the Backport tool documentation

@sorenlouv
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sorenlouv pushed a commit to sorenlouv/kibana that referenced this pull request Jun 12, 2025
elastic#222883)

This makes the existing 'logging_level' agent configuration setting
available to EDOT Node.js agents ('opentelemetry/nodejs/elastic').

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
(cherry picked from commit 056426b)

# Conflicts:
#	x-pack/solutions/observability/plugins/apm/server/lib/apm_telemetry/collect_data_telemetry/__snapshots__/tasks.test.ts.snap
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
elastic#222883)

This makes the existing 'logging_level' agent configuration setting
available to EDOT Node.js agents ('opentelemetry/nodejs/elastic').

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 16, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222883 locally
cc: @trentm

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222883 locally
cc: @trentm

@trentm
Copy link
Member Author

trentm commented Jun 18, 2025

^^ decision is to not backport tech-preview central-config work to 8.19.

@trentm trentm removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2025
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 19, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222883 locally
cc: @trentm

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222883 locally
cc: @trentm

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222883 locally
cc: @trentm

@trentm trentm removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Jun 24, 2025
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:enhancement Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants