[APM] Add 'deactivate_...' agent configuration settings for EDOT Node.js#224502
[APM] Add 'deactivate_...' agent configuration settings for EDOT Node.js#224502trentm merged 2 commits intoelastic:mainfrom
Conversation
5a77bce to
3b11cd3
Compare
| 'Comma-separated list of instrumentation names to disable. When an instrumentation is disabled, no telemetry will be collected for the library/module it instruments. ' + | ||
| 'The list of supported instrumentation names is language specific:\n' + | ||
| '- [EDOT Java](https://ela.st/otel-agent-instructions): for example "akka-http,grpc"\n' + | ||
| '- [EDOT Node.js](https://ela.st/edot-node-disable-instrs): for example "net,dns,http"', |
There was a problem hiding this comment.
@jackshirazi Are you okay with the re-wording here?
@intuibase @SergeyKleyman In the APM agents meeting yesterday, my understanding was that EDOT PHP was going to want deactivate_instrumentations and deactivate_all_instrumentations settings. Shall I add PHP to this PR as well?
If so, can you provide an appropriate link listing supported instrumentation names? For:
- [EDOT PHP](https://ela.st/???): for example "???"|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
….js (elastic#224502) This makes the existing 'deactivate_all_instrumentations' and 'deactivate_instrumentations' agent configuration settings available to EDOT Node.js agents (`agent.name: opentelemetry/nodejs/elastic`).
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
This makes the existing 'deactivate_all_instrumentations' and 'deactivate_instrumentations' agent configuration settings
available to EDOT Node.js agents (
agent.name: opentelemetry/nodejs/elastic). (This follows on the recent #222883 that did the same for another config setting.)This makes use of the newly added
https://ela.st/edot-node-disable-instrsshort URL that points to the current relevant anchor in the EDOT Node.js docs.Screenshot of Agent Configuration section in Kibana showing to two newly available settings for an EDOT Node.js SDK configuration:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.