[Response Ops][Connectors][Email] `xpack.actions.email.services.ses.host/port` kibana config by jcger · Pull Request #221389 · elastic/kibana

jcger · 2025-05-23T16:18:59Z

Summary

Closes #220286

Release note

New AWS SES Email configuration options xpack.actions.email.services.ses.host and xpack.actions.email.services.ses.port.

elasticmachine · 2025-05-26T11:25:40Z

Pinging @elastic/response-ops (Team:ResponseOps)

kibanamachine · 2025-05-26T11:31:07Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8296

[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/with_aws_ses_kibana_config/config.ts: 100/100 tests passed.
[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 100/100 tests passed.

see run history

…ana into issue-220286-email-ses-kbn-cfg

docs/settings-gen/source/kibana-alert-action-settings.yml

docs/reference/configuration-reference/alerting-settings.md

docs/settings-gen/source/kibana-alert-action-settings.yml

docs/reference/configuration-reference/alerting-settings.md

jbudz · 2025-05-27T14:03:07Z

Can we add this to src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker too?

src/platform/test/plugin_functional/test_suites/core_plugins/rendering.ts

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

jcger · 2025-05-29T14:23:34Z

Can we add this to src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker too?

Done in 5b776e7

cnasikas

I tested the creation of the connector with the new configuration and it works as expected. I left some comments. Also:

I noticed that based on the docs, if the service is set and is a well-known service, nodemailer will override the host and port even if they are passed. Should we handle that before sending the email?
Could you please run the flaky test runner?

x-pack/platform/plugins/shared/actions/server/config.ts

cnasikas · 2025-06-03T08:15:15Z

x-pack/platform/plugins/shared/actions/server/config.test.ts

    expect(result.email?.domain_allowlist).toEqual(['a.com', 'b.c.com', 'd.e.f.com']);
  });
+
+  test('email.services.ses', () => {


nit: Let's create one test for each assertion. I know this is what we did above, but I think it is more readable and better to reason about the tests if each assertion is on its own test.

done in c5c13f1

cnasikas · 2025-06-03T08:17:35Z

x-pack/platform/plugins/shared/actions/server/actions_config.ts

Could you please add some tests in x-pack/platform/plugins/shared/actions/server/actions_config.test.ts?

done in c5c13f1

.../platform/plugins/shared/stack_connectors/server/routes/get_well_known_email_service.test.ts

cnasikas · 2025-06-03T11:14:44Z

x-pack/platform/plugins/shared/stack_connectors/server/connector_types/email/index.ts

    if (config.tenantId == null) {
      throw new Error('[tenantId] is required');
    }
+  } else if (config.service === AdditionalEmailServices.AWS_SES) {


This validation here is a breaking change. Before this PR I could create the following connector without issues:

{ "name": "test", "config": { "from": "foo@foo.com", "service": "ses", "host": "foo.com", "port": 123, "secure": true, "hasAuth": false }, "secrets": {}, "connector_type_id": ".email" }

Should we validate only if the configuration is set or even not at all? @pmuellr wdyt?

But what's the point then in having defaults for this service? Also, in the UI that was not possible. Shouldn't you use "other" for that?

You can validate only when the configuration is set. This is not a breaking change. Here we validate even if the validation is not set (aside the defaults), right?

done in 7707502

x-pack/platform/plugins/shared/stack_connectors/common/index.ts

cnasikas · 2025-06-03T11:18:44Z

docs/reference/configuration-reference/alerting-settings.md

    Data type: `string`

+`xpack.actions.email.services.ses.host` ![logo cloud](https://doc-icons.s3.us-east-2.amazonaws.com/logo_cloud.svg "Supported on {{ech}}")
+:    The hostname for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.


Suggested change

: The hostname for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.

: The SMTP endpoint for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.

Monstly to emphasize that HTTPS is not supported and to be more inline with the AWS terminology.

you mean HTTP? done in c5c13f1

jcger · 2025-06-05T12:22:54Z

docs/reference/configuration-reference/alerting-settings.md

+:    The SMTP endpoint for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.
+
+    ::::{warning}
+    This setting alone is insufficient to override system defaults for the SES SMTP endpoint. You must also configure the `xpack.actions.email.services.ses.port` setting


Hey @nastasha-solomon, could you review it again, please? I did some changes + this warning section is new

Just a couple minor edits - thanks!

Suggested change

This setting alone is insufficient to override system defaults for the SES SMTP endpoint. You must also configure the `xpack.actions.email.services.ses.port` setting

This setting alone is insufficient for overriding system defaults for the SES SMTP endpoint. You must also configure the `xpack.actions.email.services.ses.port` setting.

done in 269bc6b

…l-ses-kbn-cfg

cnasikas

LGTM! I tested various scenarios with and without configuration and everything is working as expected!

kibanamachine · 2025-06-11T11:14:33Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8363

[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/with_aws_ses_kibana_config/config.ts: 100/100 tests passed.

see run history

elasticmachine · 2025-06-11T16:40:33Z

💚 Build Succeeded

Buildkite Build
Commit: d252714

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	60.5KB	60.5KB	+16.0B

History

💚 Build #306946 succeeded 8ad367a
💚 Build #306540 succeeded 2b1c75b
💚 Build #305749 succeeded 7707502
💔 Build #304044 failed 7bfacf8
💛 Build #303406 was flaky b79fecc
💛 Build #302398 was flaky 4404ff8

lcawl

Docs LGTM too

kibanamachine · 2025-06-12T15:38:30Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15614985008

kibanamachine · 2025-06-12T15:44:49Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [APM] Add 'logging_level' agent configuration setting for EDOT Node.js (#222883) - [ResponseOps] Enable scrolling in `ConnectorAddModal` (#223270) - [Security Solution] Add Connector Selector tests (#212385) - [Security Solution] Rename isPreview prop to isRulePreview (#214639) - [Core] Rename o11y essentials tier to logs_essential (#223546) - [Obs AI Assistant] Avoid adding tool instructions to the system message when tools are disabled (#223278) - [Elastic Assistant] React to FF updates (#223429) - [Rules] Enable versatile EBT (#221163) - fix(streams): fix flakiness in scout test (#223271) - Audit Synthetics plugin log levels (#218399)

Manual backport

To create the backport manually run:

node scripts/backport --pr 221389

Questions ?

Please refer to the Backport tool documentation

jcger · 2025-06-13T08:37:22Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ost/port` kibana config (elastic#221389) ## Summary Closes elastic#220286 ## Release note New AWS SES Email configuration options `xpack.actions.email.services.ses.host` and `xpack.actions.email.services.ses.port`. --------- Co-authored-by: Lisa Cawley <lcawley@elastic.co> (cherry picked from commit f5b6aa2) # Conflicts: # docs/reference/configuration-reference/alerting-settings.md # docs/settings-gen/source/kibana-alert-action-settings.yml

…s.ses.host/port` kibana config (#221389) (#223870) # Backport This will backport the following commits from `main` to `8.19`: - [[Response Ops][Connectors][Email] `xpack.actions.email.services.ses.host/port` kibana config (#221389)](#221389)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>

…ost/port` kibana config (elastic#221389) ## Summary Closes elastic#220286 ## Release note New AWS SES Email configuration options `xpack.actions.email.services.ses.host` and `xpack.actions.email.services.ses.port`. --------- Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Available since 9.1 - 8.19 - #223363 - #221389 - #221389 - #222507

…c#228215) Available since 9.1 - 8.19 - elastic#223363 - elastic#221389 - elastic#221389 - elastic#222507 (cherry picked from commit 39dda35)

…c#228215) Available since 9.1 - 8.19 - elastic#223363 - elastic#221389 - elastic#221389 - elastic#222507

jcger added 5 commits May 23, 2025 18:16

first commit

7de0239

add route test

29e0381

remove not needed test config

f8a076c

last changes + tests + docs

b30634a

Merge branch 'main' into issue-220286-email-ses-kbn-cfg

b006802

jcger marked this pull request as ready for review May 26, 2025 11:24

jcger requested review from a team as code owners May 26, 2025 11:24

jcger added backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// release_note:feature Makes this part of the condensed release notes v9.1.0 v8.19.0 labels May 26, 2025

jcger added 3 commits May 26, 2025 15:36

fix tests

8e518be

Merge branch 'main' into issue-220286-email-ses-kbn-cfg

7a986ee

Merge branch 'issue-220286-email-ses-kbn-cfg' of github.com:jcger/kib…

4404ff8

…ana into issue-220286-email-ses-kbn-cfg

jcger requested a review from a team as a code owner May 26, 2025 13:37

lcawl reviewed May 26, 2025

View reviewed changes

jeramysoucy self-requested a review May 27, 2025 12:37

jeramysoucy reviewed May 28, 2025

View reviewed changes

src/platform/test/plugin_functional/test_suites/core_plugins/rendering.ts Show resolved Hide resolved

jcger and others added 2 commits May 29, 2025 16:19

Apply suggestions from code review

d9c88cd

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

add missing configs to kibana-docker

5b776e7

jbudz approved these changes May 29, 2025

View reviewed changes

jeramysoucy approved these changes May 30, 2025

View reviewed changes

cnasikas reviewed Jun 3, 2025

View reviewed changes

jcger force-pushed the issue-220286-email-ses-kbn-cfg branch from 7bfacf8 to 7707502 Compare June 5, 2025 12:15

jcger commented Jun 5, 2025

View reviewed changes

Merge branch 'main' into issue-220286-email-ses-kbn-cfg

2b1c75b

jcger added backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting labels Jun 9, 2025

Merge branch 'main' of github.com:jcger/kibana into issue-220286-emai…

8ad367a

…l-ses-kbn-cfg

cnasikas approved these changes Jun 11, 2025

View reviewed changes

jcger added 2 commits June 11, 2025 17:02

fix docs

269bc6b

Merge branch 'main' into issue-220286-email-ses-kbn-cfg

d252714

jcger enabled auto-merge (squash) June 11, 2025 15:03

nastasha-solomon self-requested a review June 11, 2025 19:02

nastasha-solomon approved these changes Jun 11, 2025

View reviewed changes

lcawl approved these changes Jun 12, 2025

View reviewed changes

jcger merged commit f5b6aa2 into elastic:main Jun 12, 2025
10 checks passed

kibanamachine mentioned this pull request Jun 12, 2025

[ML] Fixes overflow of cards in Machine Learning Overview page #223431

Merged

9 tasks

jcger mentioned this pull request Jun 13, 2025

[8.19] [Response Ops][Connectors][Email] xpack.actions.email.services.ses.host/port kibana config (#221389) #223870

Merged

jcger mentioned this pull request Jul 16, 2025

[Response Ops][Docs] Add missing actions settings in ECH docs #228215

Merged

jcger added a commit that referenced this pull request Jul 18, 2025

[Response Ops][Docs] Add missing actions settings in ECH docs (#228215)

39dda35

Available since 9.1 - 8.19 - #223363 - #221389 - #221389 - #222507

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025

[Response Ops][Docs] Add missing actions settings in ECH docs (elasti…

8323742

…c#228215) Available since 9.1 - 8.19 - elastic#223363 - elastic#221389 - elastic#221389 - elastic#222507

kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025

[Response Ops][Docs] Add missing actions settings in ECH docs (elasti…

49e0e69

…c#228215) Available since 9.1 - 8.19 - elastic#223363 - elastic#221389 - elastic#221389 - elastic#222507

florent-leborgne added a commit to florent-leborgne/kibana that referenced this pull request Jul 25, 2025

Missed applies_to in elastic#221389

6dc9039

	: The hostname for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.
	: The SMTP endpoint for an Amazon Simple Email Service (SES) service provider that can be used by email connectors.

	This setting alone is insufficient to override system defaults for the SES SMTP endpoint. You must also configure the `xpack.actions.email.services.ses.port` setting
	This setting alone is insufficient for overriding system defaults for the SES SMTP endpoint. You must also configure the `xpack.actions.email.services.ses.port` setting.

Conversation

jcger commented May 23, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release note

Uh oh!

elasticmachine commented May 26, 2025

Uh oh!

kibanamachine commented May 26, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8296

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbudz commented May 27, 2025

Uh oh!

Uh oh!

jcger commented May 29, 2025

Uh oh!

cnasikas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcger Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 11, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8363

Uh oh!

elasticmachine commented Jun 11, 2025

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

lcawl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 12, 2025

Uh oh!

kibanamachine commented Jun 12, 2025

💔 All backports failed

jcger commented May 23, 2025 •

edited by kibanamachine

Loading

cnasikas left a comment •

edited

Loading

jcger Jun 4, 2025 •

edited

Loading

cnasikas Jun 4, 2025 •

edited

Loading