Skip to content

Comments

[Query Rules UI] Query rules flyout document selector.#222541

Merged
efegurkan merged 54 commits intoelastic:mainfrom
efegurkan:query-flyout-document-selector
Jun 12, 2025
Merged

[Query Rules UI] Query rules flyout document selector.#222541
efegurkan merged 54 commits intoelastic:mainfrom
efegurkan:query-flyout-document-selector

Conversation

@efegurkan
Copy link
Member

@efegurkan efegurkan commented Jun 4, 2025 •
edited by kibanamachine
Loading

Summary

Adds a Document selector to the Query Rules Flyout
Adds a create mode to the flyout too.

Screen.Recording.2025-06-04.at.13.43.10.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

efegurkan and others added 25 commits April 10, 2025 16:01
@efegurkan
Add Query Rules Detail Page with Draggable list
9d6714b
@efegurkan
Add some unit test coverage
911b860
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-rules-det…
4508d34 
…ails-page
@efegurkan
Review changes
db3de31
@efegurkan
Add custom heading element to draggable list
064b5d0
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-rules-det…
3819a0f 
…ails-page
@efegurkan
Review changes
39dcc10
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into tmp/query-rule-…
e6bc496 
…flyout
@efegurkan
Add metadata editor basics
1fee4cc
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into tmp/query-rule-…
4d59722 
…flyout
@efegurkan
WIP
9c65289
@efegurkan
Fixed rendering update issue and updated metadata editor
fb614a3
@efegurkan
Add a flyout tests and remove extra files
b89446e
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-rule-flyout
1fb47c5
@elasticmachine
Merge branch 'main' into query-rule-flyout
bc2b4a2
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
d5b8a1b 
…-fix'
@efegurkan
Review changes
e37d4a1
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-rule-flyout
1deb5a4
@efegurkan
Fix issues created by wrongfully merged button
534465b
@efegurkan
Fix type errors
626518a
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-rule-flyout
55c00cc
@efegurkan
Add query rule document editor.
0a2b96b
@efegurkan
Merge branch 'main' of github.com:elastic/kibana into query-flyout-do…
9779f01 
…cument-selector
@efegurkan
Add put handler in save button
121b4f2
@efegurkan
i18n fixes
8a43a89
@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:Search ci:cloud-deploy Create or update a Cloud deployment v9.1.0 v8.19.0 labels Jun 4, 2025
@efegurkan
Copy link
Member Author

efegurkan commented Jun 11, 2025

@elasticmachine merge upstream

Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looking forward for the follow-up PRs.

src/platform/packages/shared/kbn-try-in-console/components/try_in_console_button.tsx Outdated
Comment on lines 31 to 40
color?:
| 'primary'
| 'text'
| 'danger'
| 'success'
| 'accent'
| 'warning'
| 'accentSecondary'
| 'neutral'
| 'risk';
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use EuiButtonColor?

x-pack/solutions/search/plugins/search_query_rules/public/hooks/use_run_query_ruleset.tsx Outdated
Comment on lines 17 to 26
color?:
| 'primary'
| 'text'
| 'danger'
| 'accent'
| 'accentSecondary'
| 'success'
| 'warning'
| 'neutral'
| 'risk';
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@efegurkan efegurkan enabled auto-merge (squash) June 12, 2025 08:29
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 12, 2025

⏳ Build in-progress

History

@efegurkan efegurkan merged commit 1c7a9da into elastic:main Jun 12, 2025
11 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 12, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15607533448

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 12, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222541

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jun 12, 2025
Merged
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
@efegurkan @elasticmachine
@kibanamachine @JoseLuisGJ @iblancof
[Query Rules UI] Query rules flyout document selector. (elastic#222541)
7a4bc32 
## Summary

Adds a Document selector to the Query Rules Flyout
Adds a create mode to the flyout too. 



https://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037




### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: José Luis González <joseluisgj@gmail.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 16, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222541 locally
cc: @efegurkan

2 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222541 locally
cc: @efegurkan

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 222541 locally
cc: @efegurkan

@kibanamachine kibanamachine mentioned this pull request Jun 18, 2025
Merged
4 tasks
@efegurkan efegurkan mentioned this pull request Jun 18, 2025
Merged
@efegurkan
Copy link
Member Author

efegurkan commented Jun 18, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

efegurkan added a commit to efegurkan/kibana that referenced this pull request Jun 18, 2025
@efegurkan
[Query Rules UI] Query rules flyout document selector. (elastic#222541)
1b61b35 
## Summary

Adds a Document selector to the Query Rules Flyout
Adds a create mode to the flyout too.

https://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: José Luis González <joseluisgj@gmail.com>
(cherry picked from commit 1c7a9da)

# Conflicts:
#	src/platform/packages/shared/kbn-try-in-console/components/try_in_console_button.tsx
#	x-pack/solutions/search/packages/kbn-search-index-documents/components/result/editable_result.tsx
efegurkan added a commit that referenced this pull request Jun 18, 2025
@efegurkan
[8.19] [Query Rules UI] Query rules flyout document selector. (#222541)…
635fcc1 
… (#224463)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Query Rules UI] Query rules flyout document selector.
(#222541)](#222541)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2025-06-12T10:01:56Z","message":"[Query
Rules UI] Query rules flyout document selector. (#222541)\n\n##
Summary\n\nAdds a Document selector to the Query Rules Flyout\nAdds a
create mode to the flyout too.
\n\n\n\nhttps://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: José
Luis González
<joseluisgj@gmail.com>","sha":"1c7a9da647e0eaf55bb4cac9a5eb536e67e54bda","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Search","ci:cloud-deploy","backport:version","v9.1.0","v8.19.0"],"title":"[Query
Rules UI] Query rules flyout document
selector.","number":222541,"url":"https://github.com/elastic/kibana/pull/222541","mergeCommit":{"message":"[Query
Rules UI] Query rules flyout document selector. (#222541)\n\n##
Summary\n\nAdds a Document selector to the Query Rules Flyout\nAdds a
create mode to the flyout too.
\n\n\n\nhttps://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: José
Luis González
<joseluisgj@gmail.com>","sha":"1c7a9da647e0eaf55bb4cac9a5eb536e67e54bda"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222541","number":222541,"mergeCommit":{"message":"[Query
Rules UI] Query rules flyout document selector. (#222541)\n\n##
Summary\n\nAdds a Document selector to the Query Rules Flyout\nAdds a
create mode to the flyout too.
\n\n\n\nhttps://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [x] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: José
Luis González
<joseluisgj@gmail.com>","sha":"1c7a9da647e0eaf55bb4cac9a5eb536e67e54bda"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efegurkan @JoseLuisGJ @elasticmachine @kibanamachine @Samiul-TheSoccerFan