Skip to content

[8.19] [Query Rules UI] Query rules flyout document selector. (#222541)#224463

Merged
efegurkan merged 2 commits intoelastic:8.19from
efegurkan:backport/8.19/pr-222541
Jun 18, 2025
Merged

[8.19] [Query Rules UI] Query rules flyout document selector. (#222541)#224463
efegurkan merged 2 commits intoelastic:8.19from
efegurkan:backport/8.19/pr-222541

Conversation

@efegurkan
Copy link
Member

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Adds a Document selector to the Query Rules Flyout
Adds a create mode to the flyout too.

https://github.com/user-attachments/assets/83212760-31ba-4f84-ba4b-dd8d2e000037

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: José Luis González <joseluisgj@gmail.com>
(cherry picked from commit 1c7a9da)

# Conflicts:
#	src/platform/packages/shared/kbn-try-in-console/components/try_in_console_button.tsx
#	x-pack/solutions/search/packages/kbn-search-index-documents/components/result/editable_result.tsx
@efegurkan efegurkan requested a review from kibanamachine as a code owner June 18, 2025 15:50
@efegurkan efegurkan added the backport This PR is a backport of another PR label Jun 18, 2025
@efegurkan efegurkan enabled auto-merge (squash) June 18, 2025 15:50
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2272 2273 +1
searchIndices 322 323 +1
searchPlayground 329 330 +1
searchQueryRules 116 150 +34
serverlessSearch 388 389 +1
total +38

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-index-documents 34 36 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.5MB 2.5MB +16.0B
indexManagement 738.8KB 738.9KB +16.0B
searchIndices 161.2KB 161.2KB +16.0B
searchQueryRules 102.2KB 117.0KB +14.9KB
serverlessSearch 330.3KB 330.4KB +16.0B
total +14.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/search-index-documents 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchQueryRules 5.4KB 5.7KB +281.0B
Unknown metric groups

API count

id before after diff
@kbn/search-index-documents 36 38 +2

ESLint disabled line counts

id before after diff
searchQueryRules 3 4 +1

Total ESLint disabled count

id before after diff
searchQueryRules 3 4 +1

History

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber-stamp:

@efegurkan efegurkan merged commit 635fcc1 into elastic:8.19 Jun 18, 2025
8 checks passed
@efegurkan efegurkan deleted the backport/8.19/pr-222541 branch June 18, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants