Query rules create mode by efegurkan · Pull Request #223613 · elastic/kibana

efegurkan · 2025-06-12T16:59:09Z

Summary

Updates create flow and fixes some bugs.

Screen.Recording.2025-06-16.at.22.44.46.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Add a ruleset exist check endpoint. Add a utility function to check common permissions in routes. Add a new hook for query rule check. Add new route for create mode in Ruleset Detail page. Modify the Query Rule creation modal to give navigation option to the user when ruleset already exists. Add tests for hook and utility function.

kibanamachine · 2025-06-15T11:16:34Z

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/243

Fixes various bugs.

efegurkan · 2025-06-16T20:47:25Z

@elasticmachine merge upstream

Samiul-TheSoccerFan

Mostly look good, left some small comments. This is a large PR to review at once. I will do another round of review tomorrow.

x-pack/solutions/search/plugins/search_query_rules/common/api_routes.ts

...ic/components/query_ruleset_detail/query_rule_flyout/document_selector/document_selector.tsx

sphilipse

two nitpicks but looks good overall

sphilipse · 2025-06-18T08:21:15Z

...uery_ruleset_detail/query_rule_draggable_list/query_rule_draggable_item_criteria_display.tsx

    <EuiText size="s">
-      <EuiBadge>{criteria.metadata}</EuiBadge>&nbsp;
-      <EuiTextColor color={euiTheme.colors.textPrimary}>{criteria.type}</EuiTextColor>&nbsp;
+      {criteria.metadata && (


this should be Boolean(criteria.metadata) or it'll show the metadata inline with eh...more metadata

sphilipse · 2025-06-18T08:24:38Z

x-pack/solutions/search/plugins/search_query_rules/server/utils/privilege_check.ts

+    response.forbidden({
+      body: i18n.translate('xpack.search.queryRules.api.routes.permissionError', {
+        defaultMessage:
+          "Your user doesn't have manage_search_query_rules privilegesUser does not have the required privileges to access this resource",


nitpick: this error message should probably lose everything from 'User' onwards

elasticmachine · 2025-06-18T12:08:47Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #75

Test Failures

[job] [logs] FTR Configs #75 / console app misc console behavior keyboard shortcuts should execute the request when Ctrl+Enter is pressed

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchQueryRules`	133	140	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`searchQueryRules`	107.0KB	110.8KB	+3.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`searchQueryRules`	5.6KB	5.7KB	+87.0B

History

💔 Build #309829 failed 643ab30
💛 Build #309074 was flaky 08c66f1
💔 Build #308565 failed 4a61c42

Samiul-TheSoccerFan

LGTM, thank you for the explanations.

kibanamachine · 2025-06-18T15:21:48Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15736934691

kibanamachine · 2025-06-18T15:28:24Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [Query Rules UI] Query rules flyout document selector. (#222541)

Manual backport

To create the backport manually run:

node scripts/backport --pr 223613

Questions ?

Please refer to the Backport tool documentation

TattdCodeMonkey · 2025-06-17T21:26:13Z

...ch/plugins/search_query_rules/public/components/empty_prompt/ruleset_detail_empty_prompt.tsx

+  });
+
+  return (
+    <EuiPanel hasShadow={false} hasBorder={false} paddingSize="l">


Why use a panel here vs EuiEmptyPrompt

TattdCodeMonkey · 2025-06-17T21:29:58Z

...uery_ruleset_detail/query_rule_draggable_list/query_rule_draggable_item_criteria_display.tsx

+        </>
+      )}
+      {criteria.type === 'always' ? (
+        <EuiBadge> {criteria.type}</EuiBadge>


Is the extra space at the beginning intentional here? What about this one not having a   after the badge like the other cases here?

kibanamachine · 2025-06-18T19:10:25Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15741516701

## Summary Updates create flow and fixes some bugs. https://github.com/user-attachments/assets/b3525b50-df3f-42b5-9ede-13df53bd7bfb ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 32e3374)

kibanamachine · 2025-06-18T19:16:33Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.19`: - [Query rules create mode (#223613)](#223613)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

efegurkan added ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 12, 2025

efegurkan force-pushed the query-rules-create-mode branch 3 times, most recently from 3308f12 to 4a61c42 Compare June 14, 2025 12:55

Make create ruleset work as a template until first save

c7031bd

Fixes various bugs.

efegurkan force-pushed the query-rules-create-mode branch from 4a61c42 to c7031bd Compare June 15, 2025 13:41

efegurkan added 3 commits June 15, 2025 18:20

Add tests

08dc163

Split components into smaller testable pieces

20f9588

Split query rule flyout state and add tests

5128608

efegurkan marked this pull request as ready for review June 16, 2025 20:47

efegurkan requested a review from a team as a code owner June 16, 2025 20:47

Merge branch 'main' into query-rules-create-mode

08c66f1

Samiul-TheSoccerFan reviewed Jun 17, 2025

View reviewed changes

x-pack/solutions/search/plugins/search_query_rules/common/api_routes.ts Show resolved Hide resolved

...ic/components/query_ruleset_detail/query_rule_flyout/document_selector/document_selector.tsx Show resolved Hide resolved

sphilipse reviewed Jun 18, 2025

View reviewed changes

Review changes

de456f1

efegurkan force-pushed the query-rules-create-mode branch from d251120 to de456f1 Compare June 18, 2025 11:26

Samiul-TheSoccerFan approved these changes Jun 18, 2025

View reviewed changes

efegurkan merged commit 32e3374 into elastic:main Jun 18, 2025
11 checks passed

TattdCodeMonkey reviewed Jun 18, 2025

View reviewed changes

efegurkan removed the backport:version Backport to applied version labels label Jun 18, 2025

efegurkan added the backport:version Backport to applied version labels label Jun 18, 2025

kibanamachine mentioned this pull request Jun 18, 2025

[8.19] Query rules create mode (#223613) #224486

Merged

Conversation

efegurkan commented Jun 12, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

kibanamachine commented Jun 15, 2025

Uh oh!

efegurkan commented Jun 16, 2025

Uh oh!

Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sphilipse left a comment

Choose a reason for hiding this comment

Uh oh!

sphilipse Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

sphilipse Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 18, 2025

Uh oh!

kibanamachine commented Jun 18, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

TattdCodeMonkey Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

TattdCodeMonkey Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 18, 2025

Uh oh!

kibanamachine commented Jun 18, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

efegurkan commented Jun 12, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Jun 18, 2025 •

edited

Loading