Skip to content

[8.19] [TSVB/SCSS] Migrate _markdown_editor.scss file (#220903) #222360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariairiartef merged 1 commit into from
Jun 3, 2025
Merged

[8.19] [TSVB/SCSS] Migrate _markdown_editor.scss file (#220903) #222360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .../plugins/private/vis_types/timeseries/public/application/components/_markdown_editor.scss
View file
Open in desktop

This file was deleted.

36 changes: 32 additions & 4 deletions ...orm/plugins/private/vis_types/timeseries/public/application/components/markdown_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import PropTypes from 'prop-types';

import React, { Component } from 'react';
import { css } from '@emotion/react';
import { createTickFormatter } from './lib/tick_formatter';
import { convertSeriesToVars } from './lib/convert_series_to_vars';
import _ from 'lodash';
Expand All @@ -25,7 +26,33 @@ import { FormattedMessage } from '@kbn/i18n-react';
import { getDataViewsStart } from '../../services';
import { fetchIndexPattern } from '../../../common/index_patterns_utils';

import './_markdown_editor.scss';
const editorStyle = ({ euiTheme }) => css`
display: flex;
background-color: ${euiTheme.colors.emptyShade};
height: 500px;
`;

const panelStyle = css`
width: 50%;
flex: 1 0 auto;
`;

const editorPanelStyle = ({ euiTheme }) => css`
border-right: 2px solid ${euiTheme.colors.lightestShade};
`;

const variablesPanelStyle = ({ euiTheme }) => css`
padding: ${euiTheme.size.s};
overflow: auto;
`;

const noVariablesStyle = ({ euiTheme }) => css`
display: block;
padding-bottom: ${euiTheme.size.xxl};
padding-top: calc(${euiTheme.size.xxl} - ${euiTheme.size.l});
text-align: center;
border-bottom: ${euiTheme.border.thin};
`;

export class MarkdownEditor extends Component {
constructor(props) {
Expand Down Expand Up @@ -122,8 +149,8 @@ export class MarkdownEditor extends Component {
walk(variables);

return (
<div className="tvbMarkdownEditor">
<div className="tvbMarkdownEditor__editor">
<div className="tvbMarkdownEditor" css={editorStyle}>
<div className="tvbMarkdownEditor__editor" css={[panelStyle, editorPanelStyle]}>
<CodeEditor
editorDidMount={this.handleOnLoad}
languageId={MarkdownLang}
Expand All @@ -135,7 +162,7 @@ export class MarkdownEditor extends Component {
onChange={this.handleChange}
/>
</div>
<div className="tvbMarkdownEditor__variables">
<div className="tvbMarkdownEditor__variables" css={[panelStyle, variablesPanelStyle]}>
<EuiText>
<p>
<FormattedMessage
Expand Down Expand Up @@ -184,6 +211,7 @@ export class MarkdownEditor extends Component {
size="xxs"
className="tsvbMarkdownVariablesTable__noVariables"
data-test-subj="tvbMarkdownEditor__noVariables"
css={noVariablesStyle}
>
<span>
<FormattedMessage
Expand Down