Skip to content

[8.19] [Discover] Add Actions header to unified data table (#214366) (#220824)#222323

Merged
kibanamachine merged 8 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-220824
Jun 10, 2025
Merged

[8.19] [Discover] Add Actions header to unified data table (#214366) (#220824)#222323
kibanamachine merged 8 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-220824

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 3, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) June 3, 2025 10:13
…lastic#220824)

## Summary

For accesibility reasons we need to label all the headers. At this point
in time the actions from the unified data table have an empty header,
for that we are grouping them in a column and labeling them as
"Actions".

| Scenario | Before | After (only icon) |
|----------|--------|-----------------|
| 1 icon | <img width="1035" alt="image"
src="https://github.com/user-attachments/assets/2884904b-42ce-432f-9cf7-90140c349ca2"
/> | <img width="1036" alt="image"
src="https://github.com/user-attachments/assets/84947522-0426-4317-a642-1fb6cab27306"
/> |
| Multiple icons | <img width="558" alt="image"
src="https://github.com/user-attachments/assets/fe4be017-116d-4586-888d-0e81b0b0395e"
/> | <img width="557" alt="image"
src="https://github.com/user-attachments/assets/58ea3261-703e-4d17-906c-29ee5a40569f"
/> |

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
(cherry picked from commit b4b49ac)
@AlexGPlay AlexGPlay force-pushed the backport/8.19/pr-220824 branch from 9b3a9ef to a16b91e Compare June 5, 2025 10:51
@kibanamachine kibanamachine merged commit 7fea362 into elastic:8.19 Jun 10, 2025
8 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / Actions and Triggers app create alert should create an alert with composite query in filter for conditional action

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 717 720 +3
discover 1346 1349 +3
esqlDataGrid 446 449 +3
lens 1449 1452 +3
securitySolution 7417 7420 +3
slo 1213 1216 +3
total +18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-utils 312 310 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 508.7KB 509.7KB +1012.0B
discover 1.1MB 1.1MB +785.0B
esqlDataGrid 165.4KB 166.4KB +1009.0B
logsExplorer 204.9KB 204.7KB -167.0B
securitySolution 9.3MB 9.3MB +1010.0B
slo 1015.8KB 1016.8KB +1017.0B
total +4.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esqlDataGrid 9.8KB 9.8KB -1.0B
Unknown metric groups

API count

id before after diff
@kbn/discover-utils 362 360 -2

History

cc @AlexGPlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants