Skip to content

[8.19] Make option list with stats accessible with keyboard (#221729)#221951

Merged
SoniaSanzV merged 1 commit intoelastic:8.19from
SoniaSanzV:backport/8.19/pr-221729
May 30, 2025
Merged

[8.19] Make option list with stats accessible with keyboard (#221729)#221951
SoniaSanzV merged 1 commit intoelastic:8.19from
SoniaSanzV:backport/8.19/pr-221729

Conversation

@SoniaSanzV
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Done manually due merge conflicts

Fixes elastic#219516

The Transform plugin has some text fields that are not keyboard
accessible and those fields are using the `OptionListWithFieldStats`
component. This PR adds the `onKeyDown` event for that component, fixing
the problem for Transform plugin.

https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311
(cherry picked from commit d6178cd)
@SoniaSanzV SoniaSanzV self-assigned this May 29, 2025
@SoniaSanzV SoniaSanzV requested a review from kibanamachine as a code owner May 29, 2025 15:06
@SoniaSanzV SoniaSanzV added the backport This PR is a backport of another PR label May 29, 2025
@SoniaSanzV SoniaSanzV requested a review from a team May 29, 2025 15:06
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / aiops change point detection in cases attaches change point charts to a case
  • [job] [logs] FTR Configs #33 / Alerting builtin alertTypes circuit_breakers index threshold rule that hits max alerts circuit breaker persist existing alerts to next execution if circuit breaker is hit
  • [job] [logs] FTR Configs #57 / Upgrade Assistant ES deprecation logs flyout Shows no warnings callout if there are no deprecations

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.5MB 5.5MB +112.0B
transform 630.1KB 630.2KB +112.0B
total +224.0B

cc @SoniaSanzV

@SoniaSanzV SoniaSanzV merged commit 573670f into elastic:8.19 May 30, 2025
11 checks passed
@SoniaSanzV SoniaSanzV deleted the backport/8.19/pr-221729 branch June 19, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants