[Elastic Assistant] React to FF updates#223429
Merged
afharo merged 9 commits intoelastic:mainfrom Jun 12, 2025
Merged
Conversation
afharo
commented
Jun 11, 2025
| 'my-overridden-flag': true, | ||
| 'myPlugin.myOverriddenFlag': true, | ||
| myDestructuredObjPlugin: { myOverriddenFlag: true }, | ||
| 'myDestructuredObjPlugin.myOverriddenFlag': true, |
Member
Author
There was a problem hiding this comment.
we're now flattening the object as we receive the overrides to make sure that we capture all flag names
afharo
added
backport:version
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
added
backport:version
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @afharo |
rudolf
reviewed
Jun 12, 2025
| * @param enabled If the feature flag is enabled or not. | ||
| * @return `true` if susbscription needs to stay active, `false` if it can be unsubscribed. | ||
| */ | ||
| fn: (enabled: boolean) => boolean | Promise<boolean>; |
Contributor
There was a problem hiding this comment.
The subscription/unsubscribe feels a bit complex and easy to get wrong, is it necessary or could we just keep the subscription always?
Member
Author
There was a problem hiding this comment.
We covered it on Slack.
The 2 current use cases should stop the subscription as soon as the flag is true because they can't re-run the same code twice and they don't provide a path to unregister for the false path.
But this doesn't mean that future feature flags will follow this approach. The security team is free to simplify it, though, if they want to.
rudolf
approved these changes
Jun 12, 2025
Contributor
rudolf
left a comment
rudolf
left a comment
There was a problem hiding this comment.
Core changes lgtm but the code consuming it feels rather complex.
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15613479735 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 12, 2025
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 52a016f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 12, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Elastic Assistant] React to FF updates (#223429)](#223429) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2025-06-12T14:34:24Z","message":"[Elastic Assistant] React to FF updates (#223429)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52a016fc35b9f509b4398129a8354f71f20b7461","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0"],"title":"[Elastic Assistant] React to FF updates","number":223429,"url":"https://github.com/elastic/kibana/pull/223429","mergeCommit":{"message":"[Elastic Assistant] React to FF updates (#223429)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52a016fc35b9f509b4398129a8354f71f20b7461"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223429","number":223429,"mergeCommit":{"message":"[Elastic Assistant] React to FF updates (#223429)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52a016fc35b9f509b4398129a8354f71f20b7461"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
rudolf
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Elastic Assistant currently evaluates 2 feature flags during Kibana startup. If the flag is
false, it skips the registration of some features (like alerting rules). Since it's not subscribed to updates, it doesn't react if the flag is later switched totrue. This PR changes the usage from the single-evaluation API to the observable subscription.Additional fix
The Feature flags service now reacts to live changes to the dynamic config overrides.