[AI4DSOC] Fix logic that renders the group title when grouping by integrations#219430
Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom Apr 28, 2025
Merged
Conversation
PhilippeOberti
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
stephmilovic
approved these changes
Apr 28, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…egrations (elastic#219430) ## Summary This PR makes a small changes to the logic originally introduced in [this PR](elastic#216744). Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the `related_integrations` field of the rule and check that it has the package (integration) name that we expect. This is a more robust solution, and this logic is actually already being use in [this other hook](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_integrations.ts#L75), so it seems that it was an oversight on my end... If the rule name is not identical, the UI falls back to rendering the id of the rule  But with this change, this is how the UI will look  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Relates to elastic/security-team#11973
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 30, 2025
…egrations (elastic#219430) ## Summary This PR makes a small changes to the logic originally introduced in [this PR](elastic#216744). Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the `related_integrations` field of the rule and check that it has the package (integration) name that we expect. This is a more robust solution, and this logic is actually already being use in [this other hook](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_integrations.ts#L75), so it seems that it was an oversight on my end... If the rule name is not identical, the UI falls back to rendering the id of the rule  But with this change, this is how the UI will look  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Relates to elastic/security-team#11973 (cherry picked from commit 07be70d)
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 30, 2025
…egrations (elastic#219430) ## Summary This PR makes a small changes to the logic originally introduced in [this PR](elastic#216744). Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the `related_integrations` field of the rule and check that it has the package (integration) name that we expect. This is a more robust solution, and this logic is actually already being use in [this other hook](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_integrations.ts#L75), so it seems that it was an oversight on my end... If the rule name is not identical, the UI falls back to rendering the id of the rule  But with this change, this is how the UI will look  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Relates to elastic/security-team#11973 (cherry picked from commit 07be70d)
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Jun 4, 2025
…egrations (elastic#219430) ## Summary This PR makes a small changes to the logic originally introduced in [this PR](elastic#216744). Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the `related_integrations` field of the rule and check that it has the package (integration) name that we expect. This is a more robust solution, and this logic is actually already being use in [this other hook](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_integrations.ts#L75), so it seems that it was an oversight on my end... If the rule name is not identical, the UI falls back to rendering the id of the rule  But with this change, this is how the UI will look  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Relates to elastic/security-team#11973 (cherry picked from commit 07be70d)
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Jun 4, 2025
…egrations (elastic#219430) ## Summary This PR makes a small changes to the logic originally introduced in [this PR](elastic#216744). Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the `related_integrations` field of the rule and check that it has the package (integration) name that we expect. This is a more robust solution, and this logic is actually already being use in [this other hook](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/detections/hooks/alert_summary/use_integrations.ts#L75), so it seems that it was an oversight on my end... If the rule name is not identical, the UI falls back to rendering the id of the rule  But with this change, this is how the UI will look  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Relates to elastic/security-team#11973 (cherry picked from commit 07be70d)
PhilippeOberti
added a commit
that referenced
this pull request
Jun 4, 2025
…) (#222074) # Backport This will backport the following commits from `main` to `8.19`: - [[AI4DSOC] Alert summary page routing and initialization (#214889)](#214889) - [[AI4DSOC] Alert summary landing page (#215246)](#215246) - [[AI4DSOC] Alert summary dataview (#215265)](#215265) - [[AI4DSOC] Alert summary KQL bar [#215586]](#215586) - [[AI4DSOC] Alert summary KPI charts [#215585]](#215585) - [[AI4DSOR] Alert summary integrations section [#215266]](#215266) - [[AI4DSOC] Fix issue with filtering by integrations [#216574]](#216574) - [[AI4DSOC] Alert summary table setup [#216744]](#216744) - [Alerty summary table flyout setup [#217421]](#217421) - [[AI4DSOC] Alert summary alert actions in table and flyout [#217696]](#217696) - [[AI4DSOC] Alert summary table custom cell renderers [#217124]](#217124) - [[AI4DSOC] Alert summary table and flyout ai assistant [#217744]](#217744) - [[AI4DSOC] Alert summary page performance improvements [#218632]](#218632) - [[AI4DSOC] Change the Attack Discovery page to use the AI for SOC alerts table [#218736]](#218736) - [[AI4DSOC] Change the Cases page to use the AI for SOC alerts table [#218742]](#218742) - [[AI4DSOC] Fix spacing issue on alert summary landing page integration card [#218868]](#218868) - [[AI4DSOC][ResponseOps] Fix alerts table not handling undefined maintenanceWindow capability [#218999]](#218999) - [[AI4DSOC] Fix link to the new integrations page [#219030]](#219030) - [[AI4DSOC] Disable CellActions and PreviewLinks on the Attack discovery page [#219033]](#219033) - [[AI4DSOC] Add cell renderer for datetime fields to the alert summary table [#219126]](#219126) - [[AI4DSOC] Remove Assistant icon from row action in alert summary table [#219141]](#219141) - [[AI4DSOC] Add checkboxes to the alert summary table [#219169]](#219169) - [[Security Solution][AI4DSOC] Fix table not applying alert tags for Attack discovery and Cases pages in AI4DSOC [#219410]](#219410) - [[AI4DSOC] Fix logic that renders the group title when grouping by integrations [#219430]](#219430) - [[AI4DSOC] Alert summary table truncates long values and display the field/value pair in tooltip [#219438]](#219438) - [[Security Solution] Fix alerts table potentially not applying alert assignees [#219460]](#219460) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a small changes to the logic originally introduced in this PR. Previously we were expecting the rule to have its name being identical to the name of the integration it would be installed along with. This was a bad assumption. Instead we should look at the
related_integrationsfield of the rule and check that it has the package (integration) name that we expect.This is a more robust solution, and this logic is actually already being use in this other hook, so it seems that it was an oversight on my end...
If the rule name is not identical, the UI falls back to rendering the id of the rule
But with this change, this is how the UI will look
Checklist
Relates to https://github.com/elastic/security-team/issues/11973