Skip to content

[AI4DSOC][ResponseOps] Fix alerts table not handling undefined maintenanceWindow capability#218999

Merged
PhilippeOberti merged 6 commits intoelastic:mainfrom
PhilippeOberti:alerts-table-maintenanceWindow-capability
Apr 23, 2025
Merged

[AI4DSOC][ResponseOps] Fix alerts table not handling undefined maintenanceWindow capability#218999
PhilippeOberti merged 6 commits intoelastic:mainfrom
PhilippeOberti:alerts-table-maintenanceWindow-capability

Conversation

@PhilippeOberti
Copy link
Contributor

Summary

This PR fixes an issue with the ResponseOps alerts table not handling the maintenanceWindow capability being undefined. In the AI4DSOC effort, we recently disabled the maintenanceWindow capability which cause the useBulkGetMaintenanceWindowsQuery hook to crash.

Current behavior

Screen.Recording.2025-04-23.at.11.22.21.AM.mov

Fixed behavior

Screen.Recording.2025-04-23.at.11.21.36.AM.mov

Checklist

relates to https://github.com/elastic/security-team/issues/11973

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Security Generative AI Security Generative AI v9.1.0 labels Apr 23, 2025
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner April 23, 2025 16:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti enabled auto-merge (squash) April 23, 2025 17:55
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner April 23, 2025 19:33
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for updating tests, LGTM!

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner April 23, 2025 19:39
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner April 23, 2025 19:45
const { isAtLeastPlatinum } = useLicense({ licensing });
const hasLicense = isAtLeastPlatinum();

// In AI4DSOC (searchAiLake tier) the maintenanceWindow capability is disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment!

@PhilippeOberti PhilippeOberti force-pushed the alerts-table-maintenanceWindow-capability branch from be31dbe to 7eeab5d Compare April 23, 2025 20:04
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB +47.0B
embeddableAlertsTable 796.7KB 796.7KB +47.0B
ml 5.3MB 5.3MB +47.0B
observability 1.3MB 1.3MB +47.0B
securitySolution 9.1MB 9.1MB -101.0B
triggersActionsUi 1.4MB 1.4MB +47.0B
total +134.0B

History

@PhilippeOberti PhilippeOberti merged commit 23ad755 into elastic:main Apr 23, 2025
9 checks passed
@PhilippeOberti PhilippeOberti deleted the alerts-table-maintenanceWindow-capability branch April 23, 2025 22:29
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…nanceWindow capability (elastic#218999)

## Summary

This PR fixes an issue with the ResponseOps alerts table not handling
the `maintenanceWindow` capability being `undefined`. In the AI4DSOC
effort, [we recently
disabled](elastic#214586) the
`maintenanceWindow` capability which cause the
`useBulkGetMaintenanceWindowsQuery` hook to crash.

Current behavior


https://github.com/user-attachments/assets/8ab8c97f-04a0-45cb-95e7-cc9114e87190

Fixed behavior


https://github.com/user-attachments/assets/0749bda3-7838-47b7-a65b-5c9b6a92a245

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

relates to elastic/security-team#11973

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request May 30, 2025
…nanceWindow capability (elastic#218999)

## Summary

This PR fixes an issue with the ResponseOps alerts table not handling
the `maintenanceWindow` capability being `undefined`. In the AI4DSOC
effort, [we recently
disabled](elastic#214586) the
`maintenanceWindow` capability which cause the
`useBulkGetMaintenanceWindowsQuery` hook to crash.

Current behavior

https://github.com/user-attachments/assets/8ab8c97f-04a0-45cb-95e7-cc9114e87190

Fixed behavior

https://github.com/user-attachments/assets/0749bda3-7838-47b7-a65b-5c9b6a92a245

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

relates to elastic/security-team#11973

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 23ad755)
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request May 30, 2025
…nanceWindow capability (elastic#218999)

## Summary

This PR fixes an issue with the ResponseOps alerts table not handling
the `maintenanceWindow` capability being `undefined`. In the AI4DSOC
effort, [we recently
disabled](elastic#214586) the
`maintenanceWindow` capability which cause the
`useBulkGetMaintenanceWindowsQuery` hook to crash.

Current behavior

https://github.com/user-attachments/assets/8ab8c97f-04a0-45cb-95e7-cc9114e87190

Fixed behavior

https://github.com/user-attachments/assets/0749bda3-7838-47b7-a65b-5c9b6a92a245

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

relates to elastic/security-team#11973

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 23ad755)
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Jun 4, 2025
…nanceWindow capability (elastic#218999)

## Summary

This PR fixes an issue with the ResponseOps alerts table not handling
the `maintenanceWindow` capability being `undefined`. In the AI4DSOC
effort, [we recently
disabled](elastic#214586) the
`maintenanceWindow` capability which cause the
`useBulkGetMaintenanceWindowsQuery` hook to crash.

Current behavior

https://github.com/user-attachments/assets/8ab8c97f-04a0-45cb-95e7-cc9114e87190

Fixed behavior

https://github.com/user-attachments/assets/0749bda3-7838-47b7-a65b-5c9b6a92a245

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

relates to elastic/security-team#11973

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 23ad755)
PhilippeOberti added a commit that referenced this pull request Jun 4, 2025
…) (#222074)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[AI4DSOC] Alert summary page routing and initialization
(#214889)](#214889)
- [[AI4DSOC] Alert summary landing page
(#215246)](#215246)
- [[AI4DSOC] Alert summary dataview
(#215265)](#215265)
- [[AI4DSOC] Alert summary KQL bar
[#215586]](#215586)
- [[AI4DSOC] Alert summary KPI charts
[#215585]](#215585)
- [[AI4DSOR] Alert summary integrations section
[#215266]](#215266)
- [[AI4DSOC] Fix issue with filtering by integrations
[#216574]](#216574)
- [[AI4DSOC] Alert summary table setup
[#216744]](#216744)
- [Alerty summary table flyout setup
[#217421]](#217421)
- [[AI4DSOC] Alert summary alert actions in table and flyout
[#217696]](#217696)
- [[AI4DSOC] Alert summary table custom cell renderers
[#217124]](#217124)
- [[AI4DSOC] Alert summary table and flyout ai assistant
[#217744]](#217744)
- [[AI4DSOC] Alert summary page performance improvements
[#218632]](#218632)
- [[AI4DSOC] Change the Attack Discovery page to use the AI for SOC
alerts table [#218736]](#218736)
- [[AI4DSOC] Change the Cases page to use the AI for SOC alerts table
[#218742]](#218742)
- [[AI4DSOC] Fix spacing issue on alert summary landing page integration
card [#218868]](#218868)
- [[AI4DSOC][ResponseOps] Fix alerts table not handling undefined
maintenanceWindow capability
[#218999]](#218999)
- [[AI4DSOC] Fix link to the new integrations page
[#219030]](#219030)
- [[AI4DSOC] Disable CellActions and PreviewLinks on the Attack
discovery page [#219033]](#219033)
- [[AI4DSOC] Add cell renderer for datetime fields to the alert summary
table [#219126]](#219126)
- [[AI4DSOC] Remove Assistant icon from row action in alert summary
table [#219141]](#219141)
- [[AI4DSOC] Add checkboxes to the alert summary table
[#219169]](#219169)
- [[Security Solution][AI4DSOC] Fix table not applying alert tags for
Attack discovery and Cases pages in AI4DSOC
[#219410]](#219410)
- [[AI4DSOC] Fix logic that renders the group title when grouping by
integrations [#219430]](#219430)
- [[AI4DSOC] Alert summary table truncates long values and display the
field/value pair in tooltip
[#219438]](#219438)
- [[Security Solution] Fix alerts table potentially not applying alert
assignees [#219460]](#219460)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Team:Security Generative AI Security Generative AI Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants