Skip to content

[AI4DSOC] Fix spacing issue on alert summary landing page integration card#218868

Merged
PhilippeOberti merged 1 commit intoelastic:mainfrom
PhilippeOberti:fix-ui-issue-integration-card
Apr 22, 2025
Merged

[AI4DSOC] Fix spacing issue on alert summary landing page integration card#218868
PhilippeOberti merged 1 commit intoelastic:mainfrom
PhilippeOberti:fix-ui-issue-integration-card

Conversation

@PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Apr 22, 2025 •
edited
Loading

Summary

This PR a small UI issue with the AI4DSOC alert summary landing page. Originally added via this PR, some of that logic was changed in this more recent PR, where the IntegrationIcon logic was extracted into a reusable component, packages with a EuiSkeletonText component, which somehow breaks the inlineMargingEnd value applied to the icon...

This PR fixes the spacing issue now seen on the integration card.

Before After
Screenshot 2025-04-22 at 12 42 54 PM Screenshot 2025-04-22 at 12 38 19 PM

How to test

This needs to be ran in Serverless:

  • yarn es serverless --projectType security
  • yarn serverless-security --no-base-path

You also need to enable the AI for SOC tier, by adding the following to your serverless.security.dev.yaml file:

xpack.securitySolutionServerless.productTypes:
  [
    { product_line: 'ai_soc', product_tier: 'search_ai_lake' },
  ]

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Security Generative AI Security Generative AI v9.1.0 labels Apr 22, 2025
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner April 22, 2025 17:47
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 22, 2025

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 22, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.0MB 9.0MB +119.0B

History

@PhilippeOberti PhilippeOberti merged commit 0a4268c into elastic:main Apr 22, 2025
20 checks passed
@PhilippeOberti PhilippeOberti deleted the fix-ui-issue-integration-card branch April 22, 2025 22:57
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@PhilippeOberti @akowalska622
[AI4DSOC] Fix spacing issue on alert summary landing page integration…
2a9368a 
… card (elastic#218868)

## Summary

This PR a small UI issue with the AI4DSOC alert summary landing page.
Originally added via [this
PR](elastic#215246), some of that logic
was changed in [this more recent
PR](elastic#218632), where the
`IntegrationIcon` logic was extracted into a reusable component,
packages with a `EuiSkeletonText` component, which somehow breaks the
`inlineMargingEnd` value applied to the icon...

This PR fixes the spacing issue now seen on the integration card.

| Before | After |
| ------------- | ------------- |
| ![Screenshot 2025-04-22 at 12 42
54 PM](https://github.com/user-attachments/assets/402af5e9-69ef-46db-9d53-faf8d617a307)
| ![Screenshot 2025-04-22 at 12 38
19 PM](https://github.com/user-attachments/assets/3c290f46-8c79-424c-b478-e55736917429)
|
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request May 30, 2025
@PhilippeOberti
[AI4DSOC] Fix spacing issue on alert summary landing page integration…
a6b3dbd 
… card (elastic#218868)

## Summary

This PR a small UI issue with the AI4DSOC alert summary landing page.
Originally added via [this
PR](elastic#215246), some of that logic
was changed in [this more recent
PR](elastic#218632), where the
`IntegrationIcon` logic was extracted into a reusable component,
packages with a `EuiSkeletonText` component, which somehow breaks the
`inlineMargingEnd` value applied to the icon...

This PR fixes the spacing issue now seen on the integration card.

| Before | After |
| ------------- | ------------- |
| ![Screenshot 2025-04-22 at 12 42
54 PM](https://github.com/user-attachments/assets/402af5e9-69ef-46db-9d53-faf8d617a307)
| ![Screenshot 2025-04-22 at 12 38
19 PM](https://github.com/user-attachments/assets/3c290f46-8c79-424c-b478-e55736917429)
|

(cherry picked from commit 0a4268c)
@PhilippeOberti PhilippeOberti mentioned this pull request May 30, 2025
Merged
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request May 30, 2025
@PhilippeOberti
[AI4DSOC] Fix spacing issue on alert summary landing page integration…
3ad8b70 
… card (elastic#218868)

## Summary

This PR a small UI issue with the AI4DSOC alert summary landing page.
Originally added via [this
PR](elastic#215246), some of that logic
was changed in [this more recent
PR](elastic#218632), where the
`IntegrationIcon` logic was extracted into a reusable component,
packages with a `EuiSkeletonText` component, which somehow breaks the
`inlineMargingEnd` value applied to the icon...

This PR fixes the spacing issue now seen on the integration card.

| Before | After |
| ------------- | ------------- |
| ![Screenshot 2025-04-22 at 12 42
54 PM](https://github.com/user-attachments/assets/402af5e9-69ef-46db-9d53-faf8d617a307)
| ![Screenshot 2025-04-22 at 12 38
19 PM](https://github.com/user-attachments/assets/3c290f46-8c79-424c-b478-e55736917429)
|

(cherry picked from commit 0a4268c)
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this pull request Jun 4, 2025
@PhilippeOberti
[AI4DSOC] Fix spacing issue on alert summary landing page integration…
3002358 
… card (elastic#218868)

## Summary

This PR a small UI issue with the AI4DSOC alert summary landing page.
Originally added via [this
PR](elastic#215246), some of that logic
was changed in [this more recent
PR](elastic#218632), where the
`IntegrationIcon` logic was extracted into a reusable component,
packages with a `EuiSkeletonText` component, which somehow breaks the
`inlineMargingEnd` value applied to the icon...

This PR fixes the spacing issue now seen on the integration card.

| Before | After |
| ------------- | ------------- |
| ![Screenshot 2025-04-22 at 12 42
54 PM](https://github.com/user-attachments/assets/402af5e9-69ef-46db-9d53-faf8d617a307)
| ![Screenshot 2025-04-22 at 12 38
19 PM](https://github.com/user-attachments/assets/3c290f46-8c79-424c-b478-e55736917429)
|

(cherry picked from commit 0a4268c)
PhilippeOberti added a commit that referenced this pull request Jun 4, 2025
@PhilippeOberti @kibanamachine @elasticmachine
[8.19] [AI4DSOC] Backport of AI4DSOC alert summary related PRs (#214889…
87d17ac 
…) (#222074)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[AI4DSOC] Alert summary page routing and initialization
(#214889)](#214889)
- [[AI4DSOC] Alert summary landing page
(#215246)](#215246)
- [[AI4DSOC] Alert summary dataview
(#215265)](#215265)
- [[AI4DSOC] Alert summary KQL bar
[#215586]](#215586)
- [[AI4DSOC] Alert summary KPI charts
[#215585]](#215585)
- [[AI4DSOR] Alert summary integrations section
[#215266]](#215266)
- [[AI4DSOC] Fix issue with filtering by integrations
[#216574]](#216574)
- [[AI4DSOC] Alert summary table setup
[#216744]](#216744)
- [Alerty summary table flyout setup
[#217421]](#217421)
- [[AI4DSOC] Alert summary alert actions in table and flyout
[#217696]](#217696)
- [[AI4DSOC] Alert summary table custom cell renderers
[#217124]](#217124)
- [[AI4DSOC] Alert summary table and flyout ai assistant
[#217744]](#217744)
- [[AI4DSOC] Alert summary page performance improvements
[#218632]](#218632)
- [[AI4DSOC] Change the Attack Discovery page to use the AI for SOC
alerts table [#218736]](#218736)
- [[AI4DSOC] Change the Cases page to use the AI for SOC alerts table
[#218742]](#218742)
- [[AI4DSOC] Fix spacing issue on alert summary landing page integration
card [#218868]](#218868)
- [[AI4DSOC][ResponseOps] Fix alerts table not handling undefined
maintenanceWindow capability
[#218999]](#218999)
- [[AI4DSOC] Fix link to the new integrations page
[#219030]](#219030)
- [[AI4DSOC] Disable CellActions and PreviewLinks on the Attack
discovery page [#219033]](#219033)
- [[AI4DSOC] Add cell renderer for datetime fields to the alert summary
table [#219126]](#219126)
- [[AI4DSOC] Remove Assistant icon from row action in alert summary
table [#219141]](#219141)
- [[AI4DSOC] Add checkboxes to the alert summary table
[#219169]](#219169)
- [[Security Solution][AI4DSOC] Fix table not applying alert tags for
Attack discovery and Cases pages in AI4DSOC
[#219410]](#219410)
- [[AI4DSOC] Fix logic that renders the group title when grouping by
integrations [#219430]](#219430)
- [[AI4DSOC] Alert summary table truncates long values and display the
field/value pair in tooltip
[#219438]](#219438)
- [[Security Solution] Fix alerts table potentially not applying alert
assignees [#219460]](#219460)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christineweng christineweng christineweng approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PhilippeOberti @elasticmachine @christineweng