[APM][OTel] Change the alerts query to include environment not defined value#219228
Merged
jennypavlova merged 8 commits intoelastic:mainfrom Apr 29, 2025
Conversation
jennypavlova
added
release_note:fix
v9.0.0
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
force-pushed
the
217914-make-alerts-compatible-with-undefined-serviceenvironment
branch
from
6866bf6 to
ebacefc
Compare
…-serviceenvironment
…-serviceenvironment
bryce-b
approved these changes
Apr 25, 2025
…-serviceenvironment
…-serviceenvironment
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14728845025 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jennypavlova
added a commit
that referenced
this pull request
Apr 29, 2025
## Summary Follow up: #219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 30, 2025
…d value (elastic#219228) Closes elastic#217914 ## Summary This PR fixes the issue with the alerts filtering when the service environment is not defined.  ## Testing - Using synthtrace (any scenario) inject some data: for example: ``` node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds ``` - Change the scenario - the same one, so the same services have one synthrace env and one `undefined` (set the environment to `undefined`) - Run the scenario again in a different terminal (also using `live` without closing the previous one) - Configure some alert rules (that will generate alerts for both), for example, latency > 1ms or error count > 0 - Check the environment drop-down and the alerts tab (should behave the same as in the description example here - the env filter should be applied to the table results and the alert count badge - similar on the service inventory page - there we should retest with the elastic#217899 changes when merged ) 
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 30, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
…d value (elastic#219228) Closes elastic#217914 ## Summary This PR fixes the issue with the alerts filtering when the service environment is not defined.  ## Testing - Using synthtrace (any scenario) inject some data: for example: ``` node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds ``` - Change the scenario - the same one, so the same services have one synthrace env and one `undefined` (set the environment to `undefined`) - Run the scenario again in a different terminal (also using `live` without closing the previous one) - Configure some alert rules (that will generate alerts for both), for example, latency > 1ms or error count > 0 - Check the environment drop-down and the alerts tab (should behave the same as in the description example here - the env filter should be applied to the table results and the alert count badge - similar on the service inventory page - there we should retest with the elastic#217899 changes when merged )  (cherry picked from commit bb025a8) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/environment_filter_values.ts
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
…d value (elastic#219228) Closes elastic#217914 ## Summary This PR fixes the issue with the alerts filtering when the service environment is not defined.  ## Testing - Using synthtrace (any scenario) inject some data: for example: ``` node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds ``` - Change the scenario - the same one, so the same services have one synthrace env and one `undefined` (set the environment to `undefined`) - Run the scenario again in a different terminal (also using `live` without closing the previous one) - Configure some alert rules (that will generate alerts for both), for example, latency > 1ms or error count > 0 - Check the environment drop-down and the alerts tab (should behave the same as in the description example here - the env filter should be applied to the table results and the alert count badge - similar on the service inventory page - there we should retest with the elastic#217899 changes when merged )  (cherry picked from commit bb025a8) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/environment_filter_values.ts
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing (cherry picked from commit 0a60ccc) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.test.ts # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.ts
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing (cherry picked from commit 0a60ccc) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.test.ts # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.ts
crespocarlos
added a commit
that referenced
this pull request
May 5, 2025
… defined value (#219228) (#219955) # Backport This will backport the following commits from `main` to `8.19`: - [[APM][OTel] Change the alerts query to include environment not defined value (#219228)](#219228) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-29T10:16:58Z","message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM][OTel] Change the alerts query to include environment not defined value","number":219228,"url":"https://github.com/elastic/kibana/pull/219228","mergeCommit":{"message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219228","number":219228,"mergeCommit":{"message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
crespocarlos
added a commit
that referenced
this pull request
May 5, 2025
…defined value (#219228) (#219953) # Backport This will backport the following commits from `main` to `9.0`: - [[APM][OTel] Change the alerts query to include environment not defined value (#219228)](#219228) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-29T10:16:58Z","message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM][OTel] Change the alerts query to include environment not defined value","number":219228,"url":"https://github.com/elastic/kibana/pull/219228","mergeCommit":{"message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219228","number":219228,"mergeCommit":{"message":"[APM][OTel] Change the alerts query to include environment not defined value (#219228)\n\nCloses #217914 \n\n## Summary\n\nThis PR fixes the issue with the alerts filtering when the service\nenvironment is not defined.\n\n\n\n\n## Testing\n- Using synthtrace (any scenario) inject some data: for example: \n```\n node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds\n```\n- Change the scenario - the same one, so the same services have one\nsynthrace env and one `undefined` (set the environment to `undefined`)\n- Run the scenario again in a different terminal (also using `live`\nwithout closing the previous one)\n- Configure some alert rules (that will generate alerts for both), for\nexample, latency > 1ms or error count > 0\n- Check the environment drop-down and the alerts tab (should behave the\nsame as in the description example here - the env filter should be\napplied to the table results and the alert count badge - similar on the\nservice inventory page - there we should retest with the\nhttps://github.com//pull/217899 changes when merged )\n \n\n","sha":"bb025a82c94ef46105e914bf33a79cc7e13c3acc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
kibanamachine
removed
the
backport missing
Contributor
|
This PR didn't make it into the latest 9.0.1 BC. Updating the labels. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…d value (elastic#219228) Closes elastic#217914 ## Summary This PR fixes the issue with the alerts filtering when the service environment is not defined.  ## Testing - Using synthtrace (any scenario) inject some data: for example: ``` node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds ``` - Change the scenario - the same one, so the same services have one synthrace env and one `undefined` (set the environment to `undefined`) - Run the scenario again in a different terminal (also using `live` without closing the previous one) - Configure some alert rules (that will generate alerts for both), for example, latency > 1ms or error count > 0 - Check the environment drop-down and the alerts tab (should behave the same as in the description example here - the env filter should be applied to the table results and the alert count badge - similar on the service inventory page - there we should retest with the elastic#217899 changes when merged ) 
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217914
Summary
This PR fixes the issue with the alerts filtering when the service environment is not defined.
Testing
undefined(set the environment toundefined)livewithout closing the previous one)