Skip to content

[9.0] [APM][OTel] Change the alerts query to include environment not defined value (#219228)#219953

Merged
crespocarlos merged 2 commits intoelastic:9.0from
crespocarlos:backport/9.0/pr-219228
May 5, 2025
Merged

[9.0] [APM][OTel] Change the alerts query to include environment not defined value (#219228)#219953
crespocarlos merged 2 commits intoelastic:9.0from
crespocarlos:backport/9.0/pr-219228

Conversation

@crespocarlos
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

…d value (elastic#219228)

Closes elastic#217914

## Summary

This PR fixes the issue with the alerts filtering when the service
environment is not defined.

![output](https://github.com/user-attachments/assets/05ef791a-1de4-4d06-bb2d-3b99b5f8afc4)

## Testing
- Using synthtrace (any scenario) inject some data: for example:
```
 node scripts/synthtrace simple_trace --scenarioOpts pipeline=apmToOtel --live --uniqueIds
```
- Change the scenario - the same one, so the same services have one
synthrace env and one `undefined` (set the environment to `undefined`)
- Run the scenario again in a different terminal (also using `live`
without closing the previous one)
- Configure some alert rules (that will generate alerts for both), for
example, latency > 1ms or error count > 0
- Check the environment drop-down and the alerts tab (should behave the
same as in the description example here - the env filter should be
applied to the table results and the alert count badge - similar on the
service inventory page - there we should retest with the
elastic#217899 changes when merged )

![output1](https://github.com/user-attachments/assets/f77e6da1-8e60-4c8e-a1ee-c0e0e4a632e7)

(cherry picked from commit bb025a8)

# Conflicts:
#	x-pack/solutions/observability/plugins/apm/common/environment_filter_values.ts
@crespocarlos crespocarlos added the backport This PR is a backport of another PR label May 2, 2025
@crespocarlos crespocarlos enabled auto-merge (squash) May 2, 2025 14:44
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label May 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / useBulkFetchFleetIntegrationPolicies() should allow use of ignoreMissing request property

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.4MB 2.4MB -9.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 35.6KB 35.6KB -7.0B

History

@crespocarlos crespocarlos merged commit 2c54091 into elastic:9.0 May 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants