[APM] Fix Alerts environment query follow up#219571
Merged
jennypavlova merged 3 commits intoelastic:mainfrom Apr 29, 2025
Merged
[APM] Fix Alerts environment query follow up#219571jennypavlova merged 3 commits intoelastic:mainfrom
jennypavlova merged 3 commits intoelastic:mainfrom
Conversation
jennypavlova
added
release_note:fix
backport:version
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
force-pushed
the
fix-env-query
branch
from
6ca32da to
4719468
Compare
miloszmarcinkowski
approved these changes
Apr 29, 2025
Contributor
miloszmarcinkowski
left a comment
miloszmarcinkowski
left a comment
There was a problem hiding this comment.
LGTM (code review only)
Contributor
|
Starting backport for target branches: 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14737460043 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 30, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing
1 task
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing (cherry picked from commit 0a60ccc) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.test.ts # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.ts
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
May 2, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing (cherry picked from commit 0a60ccc) # Conflicts: # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.test.ts # x-pack/solutions/observability/plugins/apm/common/utils/environment_query.ts
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
crespocarlos
added a commit
that referenced
this pull request
May 5, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[APM] Fix Alerts environment query follow up (#219571)](#219571) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-29T17:24:08Z","message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM] Fix Alerts environment query follow up","number":219571,"url":"https://github.com/elastic/kibana/pull/219571","mergeCommit":{"message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219571","number":219571,"mergeCommit":{"message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
crespocarlos
added a commit
that referenced
this pull request
May 5, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[APM] Fix Alerts environment query follow up (#219571)](#219571) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-29T17:24:08Z","message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[APM] Fix Alerts environment query follow up","number":219571,"url":"https://github.com/elastic/kibana/pull/219571","mergeCommit":{"message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219571","number":219571,"mergeCommit":{"message":"[APM] Fix Alerts environment query follow up (#219571)\n\n## Summary\n\nFollow up: https://github.com/elastic/kibana/pull/219228/\n\nTo ensure the filtering is correct, I am adding this change as the\nprevious alerts change might break other functionality where the not\ndefined is missing","sha":"0a60ccce642f787b97901c45e3d4848bb2381ae8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
kibanamachine
removed
the
backport missing
Contributor
|
This PR didn't make it into the latest 9.0.1 BC. Updating the labels. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Follow up: elastic#219228 To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up: #219228
To ensure the filtering is correct, I am adding this change as the previous alerts change might break other functionality where the not defined is missing