Skip to content

Audit Logs Levels - Obs Ux Logs Team #218413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awahab07 merged 8 commits into from
May 7, 2025
Merged

Audit Logs Levels - Obs Ux Logs Team #218413

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5022637
[Dataset Quality] Audit log level ERROR.
awahab07 Apr 16, 2025
12a1ad4
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 Apr 16, 2025
21d4b39
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 Apr 22, 2025
431e383
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 Apr 28, 2025
c5bca31
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 May 2, 2025
a4eb57a
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 May 4, 2025
5afdd1e
Use `debug` for `4xx` error codes as well.
awahab07 May 4, 2025
23d7b72
Merge remote-tracking branch 'origin/main' into observability-de-4373…
awahab07 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions x-pack/platform/plugins/shared/dataset_quality/server/routes/register_routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,13 @@ export function registerRoutes({
return response.ok({ body: data });
} catch (error) {
if (Boom.isBoom(error)) {
logger.error(error.output.payload.message);
logRouteError(logger, error);
return response.customError({
statusCode: error.output.statusCode,
body: { message: error.output.payload.message },
});
}

logger.error(error);

const opts = {
statusCode: 500,
body: {
Expand All @@ -100,9 +98,25 @@ export function registerRoutes({
opts.body.message = 'Client closed request';
}

logRouteError(logger, opts);

return response.customError(opts);
}
}
);
});
}

function logRouteError(
logger: Logger,
error: { statusCode: number; body: { message: string } } | Boom.Boom
) {
const errorStatusCode = 'statusCode' in error ? error.statusCode : error.output.statusCode;
const errorMessage = Boom.isBoom(error) ? error.output.payload.message : error.body.message;

if (errorStatusCode >= 500) {
logger.error(errorMessage);
} else {
logger.debug(errorMessage);
}
}