[Console] Add ESQL autocomplete support in single quotes#224601
Merged
ElenaStoeva merged 5 commits intoelastic:mainfrom Jun 20, 2025
Merged
[Console] Add ESQL autocomplete support in single quotes#224601ElenaStoeva merged 5 commits intoelastic:mainfrom
ElenaStoeva merged 5 commits intoelastic:mainfrom
Conversation
ElenaStoeva
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
commented
Jun 19, 2025
| /* | ||
| * This function returns an array of completion items for the esql suggestions | ||
| */ | ||
| export const getEsqlCompletionItems = ( |
Contributor
Author
There was a problem hiding this comment.
This was unnecessarily added in #219980 but it's not used anywhere so safe to remove.
stratoula
reviewed
Jun 20, 2025
Contributor
There was a problem hiding this comment.
Something goes wrong with the suggestions when there is in single quotes. It should not re-suggest from
Contributor
Author
|
Thanks for reviewing @stratoula! I think one of my last commits caused this this issue - I just fixed it in cea4aac! |
Dosant
approved these changes
Jun 20, 2025
SoniaSanzV
approved these changes
Jun 20, 2025
Contributor
SoniaSanzV
left a comment
SoniaSanzV
left a comment
There was a problem hiding this comment.
tested locally, lgtm :)
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @ElenaStoeva |
stratoula
approved these changes
Jun 20, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Seems good now, I did a very brief testing but we can fix bugs as a follow up. Thanx Elena, I love it more than the triple quotes 👼
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15781785111 |
This was referenced Jun 20, 2025
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ElenaStoeva
added a commit
to ElenaStoeva/kibana
that referenced
this pull request
Jun 20, 2025
) Closes elastic#223954 Closes elastic#223921 ## Summary This PR adds support for ESQL autocompletion inside single quotes, which allows suggestions that include triple quotes such as `KQL(``````)`. <img width="1165" alt="Screenshot 2025-06-19 at 13 39 51" src="https://github.com/user-attachments/assets/8ff59bf7-534e-4539-8cf8-2a1145dbf842" /> **Changes include:** - The lexer rules have been updated to recognize single-quote query as ESQL so that the highlighting is correct - We escape and unescape characters that are invalid in a Console string when we suggest inside single quotes so that we don't cause errors in Console **How to test:** Make sure that ESQL suggestions are displayed inside both `"query": "...` and `"query": """...` and that suggestions that contain quotes are correctly escaped inside single-quote queries. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 88ef1ac) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/console/index.ts # src/platform/plugins/shared/console/public/application/containers/editor/monaco_editor_actions_provider.ts
ElenaStoeva
added a commit
that referenced
this pull request
Jun 23, 2025
) (#224733) # Backport This will backport the following commits from `main` to `8.19`: - [[Console] Add ESQL autocomplete support in single quotes (#224601)](#224601) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-20T14:58:54Z","message":"[Console] Add ESQL autocomplete support in single quotes (#224601)\n\nCloses https://github.com/elastic/kibana/issues/223954\nCloses https://github.com/elastic/kibana/issues/223921\n\n## Summary\n\nThis PR adds support for ESQL autocompletion inside single quotes, which\nallows suggestions that include triple quotes such as `KQL(``````)`.\n \n<img width=\"1165\" alt=\"Screenshot 2025-06-19 at 13 39 51\"\nsrc=\"https://github.com/user-attachments/assets/8ff59bf7-534e-4539-8cf8-2a1145dbf842\"\n/>\n\n**Changes include:**\n- The lexer rules have been updated to recognize single-quote query as\nESQL so that the highlighting is correct\n- We escape and unescape characters that are invalid in a Console string\nwhen we suggest inside single quotes so that we don't cause errors in\nConsole\n\n**How to test:**\nMake sure that ESQL suggestions are displayed inside both `\"query\":\n\"...` and `\"query\": \"\"\"...` and that suggestions that contain quotes are\ncorrectly escaped inside single-quote queries.\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"88ef1ac8b2a5a77803c3102d3124c23e3d3bc6e9","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[Console] Add ESQL autocomplete support in single quotes","number":224601,"url":"https://github.com/elastic/kibana/pull/224601","mergeCommit":{"message":"[Console] Add ESQL autocomplete support in single quotes (#224601)\n\nCloses https://github.com/elastic/kibana/issues/223954\nCloses https://github.com/elastic/kibana/issues/223921\n\n## Summary\n\nThis PR adds support for ESQL autocompletion inside single quotes, which\nallows suggestions that include triple quotes such as `KQL(``````)`.\n \n<img width=\"1165\" alt=\"Screenshot 2025-06-19 at 13 39 51\"\nsrc=\"https://github.com/user-attachments/assets/8ff59bf7-534e-4539-8cf8-2a1145dbf842\"\n/>\n\n**Changes include:**\n- The lexer rules have been updated to recognize single-quote query as\nESQL so that the highlighting is correct\n- We escape and unescape characters that are invalid in a Console string\nwhen we suggest inside single quotes so that we don't cause errors in\nConsole\n\n**How to test:**\nMake sure that ESQL suggestions are displayed inside both `\"query\":\n\"...` and `\"query\": \"\"\"...` and that suggestions that contain quotes are\ncorrectly escaped inside single-quote queries.\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"88ef1ac8b2a5a77803c3102d3124c23e3d3bc6e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224601","number":224601,"mergeCommit":{"message":"[Console] Add ESQL autocomplete support in single quotes (#224601)\n\nCloses https://github.com/elastic/kibana/issues/223954\nCloses https://github.com/elastic/kibana/issues/223921\n\n## Summary\n\nThis PR adds support for ESQL autocompletion inside single quotes, which\nallows suggestions that include triple quotes such as `KQL(``````)`.\n \n<img width=\"1165\" alt=\"Screenshot 2025-06-19 at 13 39 51\"\nsrc=\"https://github.com/user-attachments/assets/8ff59bf7-534e-4539-8cf8-2a1145dbf842\"\n/>\n\n**Changes include:**\n- The lexer rules have been updated to recognize single-quote query as\nESQL so that the highlighting is correct\n- We escape and unescape characters that are invalid in a Console string\nwhen we suggest inside single quotes so that we don't cause errors in\nConsole\n\n**How to test:**\nMake sure that ESQL suggestions are displayed inside both `\"query\":\n\"...` and `\"query\": \"\"\"...` and that suggestions that contain quotes are\ncorrectly escaped inside single-quote queries.\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"88ef1ac8b2a5a77803c3102d3124c23e3d3bc6e9"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
) Closes elastic#223954 Closes elastic#223921 ## Summary This PR adds support for ESQL autocompletion inside single quotes, which allows suggestions that include triple quotes such as `KQL(``````)`. <img width="1165" alt="Screenshot 2025-06-19 at 13 39 51" src="https://github.com/user-attachments/assets/8ff59bf7-534e-4539-8cf8-2a1145dbf842" /> **Changes include:** - The lexer rules have been updated to recognize single-quote query as ESQL so that the highlighting is correct - We escape and unescape characters that are invalid in a Console string when we suggest inside single quotes so that we don't cause errors in Console **How to test:** Make sure that ESQL suggestions are displayed inside both `"query": "...` and `"query": """...` and that suggestions that contain quotes are correctly escaped inside single-quote queries. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223954
Closes #223921
Summary
This PR adds support for ESQL autocompletion inside single quotes, which allows suggestions that include triple quotes such as
KQL(``````).Changes include:
How to test:
Make sure that ESQL suggestions are displayed inside both
"query": "...and"query": """...and that suggestions that contain quotes are correctly escaped inside single-quote queries.