[Unzyme] src/core/packages/apps by TinaHeiligers · Pull Request #217599 · elastic/kibana

TinaHeiligers · 2025-04-08T23:49:38Z

Summary

Migrates metric_tiles and status_table unit tests from enzyme snapshot tests to explicit assertions using RTL. Explicit assertions have the advantage of being more readable, targeted, reducing noise due to unrelated changes (e.g. EUI updates) and to make debugging easier.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2025-04-08T23:49:40Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2025-04-09T01:24:22Z

💚 Build Succeeded

Buildkite Build
Commit: dfa0f4e

Metrics [docs]

✅ unchanged

afharo · 2025-04-09T13:47:38Z

src/core/packages/apps/browser-internal/src/status/components/status_table.test.tsx


 import React from 'react';
-import { shallow } from 'enzyme';
+import { mountWithIntl } from '@kbn/test-jest-helpers';


This library uses enzyme under the hood. @Dosant, are we planning to migrate @kbn/test-jest-helpers to RTL?

I am not sure how this will look like, but we likely won't be able to internally migrate this helper without touching the actual test case code.
We should probably create a separate package for most common react testing library cases (if doesn't exist yet) and deprecate these functions.

For now, I'd either use react testing library directly or this wrapper

kibana/src/platform/packages/shared/kbn-test-jest-helpers/src/testing_library_react_helpers.tsx

Lines 21 to 25 in 6a7c904

export const renderReactTestingLibraryWithI18n = (...args: Parameters<typeof render>) => {

const [ui, ...remainingRenderArgs] = args;

// Avoid using { wrapper: I18nProvider } in case the caller adds a custom wrapper.

return render(<I18nProvider>{ui}</I18nProvider>, ...remainingRenderArgs);

};

@Bamieh, @TinaHeiligers,

LGTM we should be using @kbn/test-jest-helpers anyways since it has the custom centralized code written by the core team for testing i18n

I don't think we should.
I don't think we will be able to migrate mountWithIntl internally to use testing library without rewriting the test cases.

imo, mountWithIntl should be marked as deprecated just as any other enzyme api and another common util needs to be created and used instead ( or maybe just

kibana/src/platform/packages/shared/kbn-test-jest-helpers/src/testing_library_react_helpers.tsx

Lines 21 to 25 in 6a7c904

export const renderReactTestingLibraryWithI18n = (...args: Parameters<typeof render>) => {

const [ui, ...remainingRenderArgs] = args;

// Avoid using { wrapper: I18nProvider } in case the caller adds a custom wrapper.

return render(<I18nProvider>{ui}</I18nProvider>, ...remainingRenderArgs);

};

, but we should name it nicer since it will be a default)

Bamieh

LGTM we should be using @kbn/test-jest-helpers anyways since it has the custom centralized code written by the core team for testing i18n

kibanamachine · 2025-04-09T14:57:50Z

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14360397839

## Summary Fix elastic#217589 Related to elastic#217387 Migrates `metric_tiles` and `status_table` unit tests from `enzyme` snapshot tests to explicit assertions using `RTL`. Explicit assertions have the advantage of being more readable, targeted, reducing noise due to unrelated changes (e.g. EUI updates) and to make debugging easier. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 50ddab4)

kibanamachine · 2025-04-09T15:03:56Z

💚 All backports created successfully

Status	Branch	Result
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `9.0`: - [[Unzyme] src/core/packages/apps (#217599)](#217599)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>

## Summary fix #217589 again The implementation in #217599 for the status table still relied on enzyme indirectly by using `mountWithI18n`. This PR refactors the test from implementing the enzyme-reliant helper to using `renderReactTestingLibraryWithI18n` that doesn't. ## Note to reviewers: If `renderReactTestingLibraryWithI18n` becomes the standard, renaming it to something shorter (e.g. `renderWithI18n`) would be nicer. ATM, the helper's only used in 13 files and it would be better to do so now that when adoption becomes wide-spread. The package is owned by `shared-ux` and renaming the function would require code-reviews from too many teams to justify doing so in this PR. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

## Summary fix elastic#217589 again The implementation in elastic#217599 for the status table still relied on enzyme indirectly by using `mountWithI18n`. This PR refactors the test from implementing the enzyme-reliant helper to using `renderReactTestingLibraryWithI18n` that doesn't. ## Note to reviewers: If `renderReactTestingLibraryWithI18n` becomes the standard, renaming it to something shorter (e.g. `renderWithI18n`) would be nicer. ATM, the helper's only used in 13 files and it would be better to do so now that when adoption becomes wide-spread. The package is owned by `shared-ux` and renaming the function would require code-reviews from too many teams to justify doing so in this PR. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit c45f791)

## Summary fix elastic#217589 again The implementation in elastic#217599 for the status table still relied on enzyme indirectly by using `mountWithI18n`. This PR refactors the test from implementing the enzyme-reliant helper to using `renderReactTestingLibraryWithI18n` that doesn't. ## Note to reviewers: If `renderReactTestingLibraryWithI18n` becomes the standard, renaming it to something shorter (e.g. `renderWithI18n`) would be nicer. ATM, the helper's only used in 13 files and it would be better to do so now that when adoption becomes wide-spread. The package is owned by `shared-ux` and renaming the function would require code-reviews from too many teams to justify doing so in this PR. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…218491) # Backport This will backport the following commits from `main` to `9.0`: - [[Unzyme] Migrates status_table of enzyme completely (#218361)](#218361)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>

## Summary fix elastic#217589 again The implementation in elastic#217599 for the status table still relied on enzyme indirectly by using `mountWithI18n`. This PR refactors the test from implementing the enzyme-reliant helper to using `renderReactTestingLibraryWithI18n` that doesn't. ## Note to reviewers: If `renderReactTestingLibraryWithI18n` becomes the standard, renaming it to something shorter (e.g. `renderWithI18n`) would be nicer. ATM, the helper's only used in 13 files and it would be better to do so now that when adoption becomes wide-spread. The package is owned by `shared-ux` and renaming the function would require code-reviews from too many teams to justify doing so in this PR. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

TinaHeiligers added 4 commits April 8, 2025 13:24

Converts metric_tiles test to RTL

46f060b

Converts status_table test to RTL

b1d8fe9

migrate metric_tiles unit test from enzyme to RTL

13cfdf4

removes obsolete snapshots

dfa0f4e

TinaHeiligers added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Apr 8, 2025

TinaHeiligers requested a review from a team as a code owner April 8, 2025 23:49

TinaHeiligers added backport:prev-minor and removed backport:all-open Backport to all branches that could still receive a release labels Apr 8, 2025

TinaHeiligers mentioned this pull request Apr 8, 2025

[Meta] Migrate Core UI tests from enzyme to react testing library #217387

Closed

9 tasks

afharo reviewed Apr 9, 2025

View reviewed changes

Bamieh approved these changes Apr 9, 2025

View reviewed changes

TinaHeiligers merged commit 50ddab4 into elastic:main Apr 9, 2025
19 checks passed

kibanamachine added the v9.1.0 label Apr 9, 2025

TinaHeiligers mentioned this pull request Apr 9, 2025

Migrate @kbn/test-jest-helpers from enzyme to RTL #217703

Closed

kibanamachine mentioned this pull request Apr 9, 2025

[9.0] [Unzyme] src/core/packages/apps (#217599) #217705

Merged

kibanamachine mentioned this pull request Apr 9, 2025

Update preconfigured connector name #217570

Merged

9 tasks

kibanamachine added the v9.0.0 label Apr 9, 2025

afharo mentioned this pull request Apr 11, 2025

src/core/packages/apps #217589

Closed

mistic added v9.0.1 v9.0.0 and removed v9.0.0 v9.0.1 labels Apr 15, 2025

TinaHeiligers mentioned this pull request Apr 15, 2025

[Unzyme] Migrates status_table of enzyme completely #218361

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unzyme] src/core/packages/apps#217599

[Unzyme] src/core/packages/apps#217599
TinaHeiligers merged 4 commits intoelastic:mainfrom
TinaHeiligers:unzyme_core_packages_apps

TinaHeiligers commented Apr 8, 2025 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Apr 8, 2025

Uh oh!

elasticmachine commented Apr 9, 2025

Uh oh!

afharo Apr 9, 2025 •

edited

Loading

Uh oh!

Dosant Apr 9, 2025

Uh oh!

Dosant Apr 9, 2025 •

edited

Loading

Uh oh!

Bamieh left a comment

Uh oh!

Uh oh!

kibanamachine commented Apr 9, 2025

Uh oh!

kibanamachine commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	export const renderReactTestingLibraryWithI18n = (...args: Parameters<typeof render>) => {
	const [ui, ...remainingRenderArgs] = args;
	// Avoid using { wrapper: I18nProvider } in case the caller adds a custom wrapper.
	return render(<I18nProvider>{ui}</I18nProvider>, ...remainingRenderArgs);
	};

Conversation

TinaHeiligers commented Apr 8, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Apr 8, 2025

Uh oh!

elasticmachine commented Apr 9, 2025

💚 Build Succeeded

Metrics [docs]

Uh oh!

afharo Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dosant Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

Dosant Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Apr 9, 2025

Uh oh!

kibanamachine commented Apr 9, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TinaHeiligers commented Apr 8, 2025 •

edited by kibanamachine

Loading

afharo Apr 9, 2025 •

edited

Loading

Dosant Apr 9, 2025 •

edited

Loading