[9.0] [Unzyme] Migrates status_table of enzyme completely (#218361)#218491
Merged
jbudz merged 1 commit intoelastic:9.0from Apr 17, 2025
Merged
[9.0] [Unzyme] Migrates status_table of enzyme completely (#218361)#218491jbudz merged 1 commit intoelastic:9.0from
jbudz merged 1 commit intoelastic:9.0from
Conversation
## Summary fix elastic#217589 again The implementation in elastic#217599 for the status table still relied on enzyme indirectly by using `mountWithI18n`. This PR refactors the test from implementing the enzyme-reliant helper to using `renderReactTestingLibraryWithI18n` that doesn't. ## Note to reviewers: If `renderReactTestingLibraryWithI18n` becomes the standard, renaming it to something shorter (e.g. `renderWithI18n`) would be nicer. ATM, the helper's only used in 13 files and it would be better to do so now that when adoption becomes wide-spread. The package is owned by `shared-ux` and renaming the function would require code-reviews from too many teams to justify doing so in this PR. ### Checklist Check the PR satisfies following conditions. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit c45f791)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation