[Core][UA] Forward-port 8.18 changes into main#214996
Conversation
Bamieh
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Left a comment about enterprise_search, otherwise looking good! We should probably get someone from @elastic/kibana-management to also take a look!
There was a problem hiding this comment.
We should exclude this whole enterprise_search folder
There was a problem hiding this comment.
We are removing enterprise search nodes at the end of 8 and so I think it won't be necessary to address again... but I don't think keeping this logic will cause harm. So I'll leave it up to you!
There was a problem hiding this comment.
Ahh correct. It'll need some code rewiring as well not just file deletions. I created an issue for kibana management to handle later on #215495
| values={{ | ||
| learnMoreHtml: ( | ||
| <EuiLink | ||
| href={`${links.elasticsearch.docsBase}data-stream-reindex-api.html#reindex-data-stream-api-settings`} |
There was a problem hiding this comment.
href={`${links.elasticsearch.docsBase}data-stream-reindex-api.html#reindex-data-stream-api-settings`}
Instead of putting the URL together like this, can you please create a new keyword in get_doc_links.ts with the full URL? This URL will break when we shift (imminently) to the new style of links for V9+
There was a problem hiding this comment.
This needs to be fixed in a separate PR since the fix needs to also be backported to 8.18 and 8.x. I created an issue to tackle it next. I created the issue #215227 and please take another look on this PR disregarding this one
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Did not test locally but changes lgtm. Thanks for taking this on! Approving to unblock progress
## Summary We've done a lot of UA changes against 8.18 and 8.x but we did not port them to `main`. The reason we did not do the active development against `main` is because UA is disabled on main and we need those features in 8.last not on `9.0` initially. This port is to keep the codebase consistent and to be able to use these new UA features in the future post `9.0`. Any issues that that are caused from this port we should wrap them in a config and disabled them on main and enable this new flag on `8.x`. What is being ported? - [x] Upgrade assistant plugin (`x-pack/platform/plugins/private/upgrade_assistant`) - [x] Integration test changes (`x-pack/test/upgrade_assistant_integration`) - [x] new UA doc links (`src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts`) - [x] localization files sync (`x-pack/platform/plugins/private/translations/translations/*.json`) - [x] Unfreeze is no longer supported after `8.x`. So removed it from data streams readonly migration step and throw an error for regular indices migration. Closes elastic#210490 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary We've done a lot of UA changes against 8.18 and 8.x but we did not port them to `main`. The reason we did not do the active development against `main` is because UA is disabled on main and we need those features in 8.last not on `9.0` initially. This port is to keep the codebase consistent and to be able to use these new UA features in the future post `9.0`. Any issues that that are caused from this port we should wrap them in a config and disabled them on main and enable this new flag on `8.x`. What is being ported? - [x] Upgrade assistant plugin (`x-pack/platform/plugins/private/upgrade_assistant`) - [x] Integration test changes (`x-pack/test/upgrade_assistant_integration`) - [x] new UA doc links (`src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts`) - [x] localization files sync (`x-pack/platform/plugins/private/translations/translations/*.json`) - [x] Unfreeze is no longer supported after `8.x`. So removed it from data streams readonly migration step and throw an error for regular indices migration. Closes elastic#210490 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
7 participants
Summary
We've done a lot of UA changes against 8.18 and 8.x but we did not port them to
main. The reason we did not do the active development againstmainis because UA is disabled on main and we need those features in 8.last not on9.0initially. This port is to keep the codebase consistent and to be able to use these new UA features in the future post9.0.Any issues that that are caused from this port we should wrap them in a config and disabled them on main and enable this new flag on
8.x.What is being ported?
x-pack/platform/plugins/private/upgrade_assistant)x-pack/test/upgrade_assistant_integration)src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts)x-pack/platform/plugins/private/translations/translations/*.json)8.x. So removed it from data streams readonly migration step and throw an error for regular indices migration.Closes #210490