Use new security URLs in doc link service by lcawl · Pull Request #219005 · elastic/kibana

lcawl · 2025-04-23T17:43:22Z

Summary

Relates to #217722

This PR updates the Kibana doc link service with the appropriate URLs for the security, siem, and securityServerless URLs in the new docs system.

The following commands were run to pass the jest failures and update the snapshots:

yarn test:jest -u x-pack/platform/plugins/shared/security/public/management/roles/edit_role/privileges/es/elasticsearch_privileges.test.tsx
yarn test:jest -u x-pack/solutions/security/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/components/related_detection_rules_callout.test.tsx
yarn test:jest -u src/platform/plugins/shared/ai_assistant_management/selection/public/routes/components/ai_assistant_selection_page.test.tsx
yarn test:jest -u x-pack/platform/plugins/shared/spaces/public/management/spaces_management_app.test.tsx   
yarn test:jest -u x-pack/solutions/security/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/components/event_merging_banner.test.tsx

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts

elasticmachine · 2025-04-23T17:59:02Z

Pinging @elastic/kibana-docs (Team:Docs)

elasticmachine · 2025-04-23T20:10:57Z

Pinging @elastic/fleet (Team:Fleet)

github-actions · 2025-04-25T15:46:40Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

…-fix'

elasticmachine · 2025-04-28T23:53:25Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 8a0ca3c
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-219005-8a0ca3c73d32

Failed CI Steps

FTR Configs #18

Test Failures

[job] [logs] FTR Configs #18 / Actions and Triggers app Connectors General connector functionality should reset connector when canceling an edit

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiAssistantManagementSelection`	67.4KB	69.0KB	+1.6KB
`lists`	114.1KB	115.7KB	+1.6KB
total			+3.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	439.3KB	441.0KB	+1.6KB

History

💛 Build #296332 was flaky aebe7dd
💔 Build #295545 failed fc1fb00
💔 Build #295493 failed ca82ce4

kibanamachine · 2025-04-30T03:34:49Z

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14746136874

kibanamachine · 2025-04-30T03:40:40Z

💔 All backports failed

Status	Branch	Result
❌	9.0	Backport failed because of merge conflicts You might need to backport the following PRs to 9.0: - [Core][UA] Forward-port 8.18 changes into main (#214996)

Manual backport

To create the backport manually run:

node scripts/backport --pr 219005

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit cbf3742)

lcawl · 2025-04-30T04:10:34Z

💚 All backports created successfully

Status	Branch	Result
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `9.0`: - [Use new security URLs in doc link service (#219005)](#219005)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…vice (#223388) This PR replaces the old Security API doc links with API refence links in the Kibana doc link service. [This security-docs PR](elastic/security-docs#6872), which removes outdated Security Detections asciidoc API docs, is failing with the following error: > INFO:build_docs:Bad cross-document links: > INFO:build_docs: Kibana [8.x]: src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts contains broken links to: > INFO:build_docs: - en/security/8.x/rule-api-overview.html > INFO:build_docs: - en/security/8.x/signals-migration-api.htm Replacing these links in the Kibana doc link service should unblock the docs PR. The links were replaced in `main` in [this PR](#219005). --------- Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co>

…vice (elastic#223388) This PR replaces the old Security API doc links with API refence links in the Kibana doc link service. [This security-docs PR](elastic/security-docs#6872), which removes outdated Security Detections asciidoc API docs, is failing with the following error: > INFO:build_docs:Bad cross-document links: > INFO:build_docs: Kibana [8.x]: src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts contains broken links to: > INFO:build_docs: - en/security/8.x/rule-api-overview.html > INFO:build_docs: - en/security/8.x/signals-migration-api.htm Replacing these links in the Kibana doc link service should unblock the docs PR. The links were replaced in `main` in [this PR](elastic#219005). --------- Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co> (cherry picked from commit 3579e5c)

Use new security URLs in doc link service

1c06c74

lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 23, 2025

lcawl mentioned this pull request Apr 23, 2025

Update Kibana doc link service URLs for docs V3 #217722

Closed

12 tasks

Fix breaking change URLs

ec6bde8

lcawl commented Apr 23, 2025

View reviewed changes

src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved

lcawl commented Apr 23, 2025

View reviewed changes

src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved

lcawl commented Apr 23, 2025

View reviewed changes

src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved

lcawl commented Apr 23, 2025

View reviewed changes

src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts Show resolved Hide resolved

lcawl marked this pull request as ready for review April 23, 2025 17:59

lcawl requested a review from a team as a code owner April 23, 2025 17:59

lcawl requested a review from a team April 23, 2025 17:59

lcawl added 2 commits April 23, 2025 11:02

Remove unused doc link keywords

11cb4f2

Merge branch 'main' into security-links

ca82ce4

jmikell821 approved these changes Apr 23, 2025

View reviewed changes

Fix jest errors

b16b837

lcawl requested review from a team as code owners April 23, 2025 20:10

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 23, 2025

Fix related_detection_rules_callout.test.tsx

a3c158f

lcawl requested a review from a team as a code owner April 23, 2025 20:16

lcawl requested review from parkiino and paul-tavares April 23, 2025 20:16

Merge branch 'main' into security-links

fc1fb00

Fix links in ai_assistant_selection_page.test.tsx

5b15e03

lcawl requested a review from a team as a code owner April 25, 2025 15:46

botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 25, 2025

lcawl and others added 4 commits April 25, 2025 08:56

Merge branch 'main' into security-links

a88513b

Fix spaces_management_app.test.tsx and event_merging_banner.test.tsx

7e812d1

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

aebe7dd

…-fix'

Merge branch 'main' into security-links

8a0ca3c

paul-tavares approved these changes Apr 29, 2025

View reviewed changes

neptunian approved these changes Apr 29, 2025

View reviewed changes

lcawl merged commit cbf3742 into elastic:main Apr 30, 2025
9 checks passed

lcawl deleted the security-links branch April 30, 2025 03:34

lcawl added a commit to lcawl/kibana that referenced this pull request Apr 30, 2025

Use new security URLs in doc link service (elastic#219005)

c146c34

(cherry picked from commit cbf3742)

lcawl mentioned this pull request Apr 30, 2025

[9.0] Use new security URLs in doc link service (#219005) #219658

Merged

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Apr 30, 2025

Use new security URLs in doc link service (elastic#219005)

857a7fe

kibanamachine mentioned this pull request Apr 30, 2025

[Detection Engine] Chore: Remove jest snapshots containing mostly EUI components #219026

Merged

1 task

pborgonovi pushed a commit that referenced this pull request Apr 30, 2025

Use new security URLs in doc link service (#219005)

30fa120

mistic added v9.0.2 and removed v9.0.1 labels May 6, 2025

lcawl mentioned this pull request May 7, 2025

[DOCS] Update URLs for apm, monitoring, and observability #218030

Merged

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025

Use new security URLs in doc link service (elastic#219005)

0cac433

natasha-moore-elastic mentioned this pull request Jun 11, 2025

Replace old Security API doc links with API ref links in doc link service #223388

Merged

florent-leborgne mentioned this pull request Jun 18, 2025

[Internal]: Broken Link to AI Docs in Elastic Hosted elastic/docs-content#1772

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Use new security URLs in doc link service#219005

Use new security URLs in doc link service#219005
lcawl merged 12 commits intoelastic:mainfrom
lcawl:security-links

lcawl commented Apr 23, 2025 •

edited by kibanamachine

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Apr 23, 2025

Uh oh!

elasticmachine commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

elasticmachine commented Apr 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

kibanamachine commented Apr 30, 2025

Uh oh!

kibanamachine commented Apr 30, 2025

Uh oh!

lcawl commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Comments

Conversation

lcawl commented Apr 23, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Apr 23, 2025

Uh oh!

elasticmachine commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 25, 2025

🤖 GitHub comments

Uh oh!

elasticmachine commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Uh oh!

kibanamachine commented Apr 30, 2025

Uh oh!

kibanamachine commented Apr 30, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

lcawl commented Apr 30, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

lcawl commented Apr 23, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Apr 28, 2025 •

edited

Loading