Skip to content

Use new enterpriseSearch URLs in link service#219290

Merged
lcawl merged 9 commits intoelastic:mainfrom
lcawl:search-links
Apr 28, 2025
Merged

Use new enterpriseSearch URLs in link service#219290
lcawl merged 9 commits intoelastic:mainfrom
lcawl:search-links

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 25, 2025

Summary

Relates to #217722

This PR updates the URLs in the enterpriseSearch section of the Kibana doc link service.
Quite a few of these URLs are unchanged and I believe this is related to the discontinuation of some of those products. The doc links are still referenced (e.g. from https://github.com/elastic/kibana/blob/main/x-pack/solutions/search/plugins/enterprise_search/public/applications/shared/doc_links/doc_links.ts), however, so I don't think we can remove them yet.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 25, 2025
@lcawl lcawl marked this pull request as ready for review April 25, 2025 17:32
@lcawl lcawl requested a review from a team as a code owner April 25, 2025 17:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl enabled auto-merge (squash) April 28, 2025 15:46
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tweak :)

@leemthompo leemthompo disabled auto-merge April 28, 2025 15:57
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 65.7KB 67.0KB +1.2KB
lists 112.4KB 113.7KB +1.2KB
total +2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 437.7KB 438.9KB +1.2KB

History

@lcawl lcawl merged commit ee065c5 into elastic:main Apr 28, 2025
9 checks passed
@lcawl lcawl deleted the search-links branch April 28, 2025 17:57
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14714503947

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Core][UA] Forward-port 8.18 changes into main (#214996)

Manual backport

To create the backport manually run:

node scripts/backport --pr 219290

Questions ?

Please refer to the Backport tool documentation

@lcawl
Copy link
Contributor Author

lcawl commented Apr 28, 2025

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Apr 28, 2025
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
(cherry picked from commit ee065c5)
lcawl added a commit that referenced this pull request Apr 29, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Use new enterpriseSearch URLs in link service
(#219290)](#219290)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-28T17:57:33Z","message":"Use
new enterpriseSearch URLs in link service (#219290)\n\n\nCo-authored-by:
Liam Thompson
<32779855+leemthompo@users.noreply.github.com>","sha":"ee065c526081c2bf14dd7778da6b5f7332030b82","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","backport:version","v9.1.0","v9.0.1"],"title":"Use
new enterpriseSearch URLs in link
service","number":219290,"url":"https://github.com/elastic/kibana/pull/219290","mergeCommit":{"message":"Use
new enterpriseSearch URLs in link service (#219290)\n\n\nCo-authored-by:
Liam Thompson
<32779855+leemthompo@users.noreply.github.com>","sha":"ee065c526081c2bf14dd7778da6b5f7332030b82"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219290","number":219290,"mergeCommit":{"message":"Use
new enterpriseSearch URLs in link service (#219290)\n\n\nCo-authored-by:
Liam Thompson
<32779855+leemthompo@users.noreply.github.com>","sha":"ee065c526081c2bf14dd7778da6b5f7332030b82"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants