[Security Solution] Fix session view navigation when in alert preview and add preview banner#213455
Merged
christineweng merged 1 commit intoelastic:mainfrom Mar 13, 2025
Merged
Conversation
christineweng
added
release_note:fix
v9.0.0
Team:Threat Hunting:Investigations
christineweng
changed the title
christineweng
force-pushed
the
fix-session-view-link
branch
from
a64d264 to
be1d899
Compare
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
PhilippeOberti
approved these changes
Mar 13, 2025
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
Desk tested and code LGTM, thanks for fixing the issue!
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13842267484 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
… and add preview banner (elastic#213455) ## Summary Before: when in an alert preview, clicking session preview header opens session view in details panel, but the preview persists. This PR addressed the bug by including `isPreviewMode` as an indicator that the panel is opened in preview. Clicking a link in preview should opens a new flyout and preview should not appear. https://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0 Added banner to session viewer in flyout <img width="1468" alt="image" src="https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit a6ceafc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
… and add preview banner (elastic#213455) ## Summary Before: when in an alert preview, clicking session preview header opens session view in details panel, but the preview persists. This PR addressed the bug by including `isPreviewMode` as an indicator that the panel is opened in preview. Clicking a link in preview should opens a new flyout and preview should not appear. https://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0 Added banner to session viewer in flyout <img width="1468" alt="image" src="https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit a6ceafc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2025
… and add preview banner (elastic#213455) ## Summary Before: when in an alert preview, clicking session preview header opens session view in details panel, but the preview persists. This PR addressed the bug by including `isPreviewMode` as an indicator that the panel is opened in preview. Clicking a link in preview should opens a new flyout and preview should not appear. https://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0 Added banner to session viewer in flyout <img width="1468" alt="image" src="https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit a6ceafc)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…review and add preview banner (#213455) (#214469) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)](#213455) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-13T18:43:18Z","message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix session view navigation when in alert preview and add preview banner","number":213455,"url":"https://github.com/elastic/kibana/pull/213455","mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213455","number":213455,"mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…preview and add preview banner (#213455) (#214467) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)](#213455) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-13T18:43:18Z","message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix session view navigation when in alert preview and add preview banner","number":213455,"url":"https://github.com/elastic/kibana/pull/213455","mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213455","number":213455,"mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2025
…review and add preview banner (#213455) (#214468) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)](#213455) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-13T18:43:18Z","message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix session view navigation when in alert preview and add preview banner","number":213455,"url":"https://github.com/elastic/kibana/pull/213455","mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213455","number":213455,"mergeCommit":{"message":"[Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)\n\n## Summary\n\nBefore: when in an alert preview, clicking session preview header opens\nsession view in details panel, but the preview persists.\n\nThis PR addressed the bug by including `isPreviewMode` as an indicator\nthat the panel is opened in preview. Clicking a link in preview should\nopens a new flyout and preview should not appear.\n\n\nhttps://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0\n\nAdded banner to session viewer in flyout\n\n<img width=\"1468\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284\"\n/>\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a6ceafc8916a8f6c121fcad88f9057f92523feb3"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
… and add preview banner (elastic#213455) ## Summary Before: when in an alert preview, clicking session preview header opens session view in details panel, but the preview persists. This PR addressed the bug by including `isPreviewMode` as an indicator that the panel is opened in preview. Clicking a link in preview should opens a new flyout and preview should not appear. https://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0 Added banner to session viewer in flyout <img width="1468" alt="image" src="https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before: when in an alert preview, clicking session preview header opens session view in details panel, but the preview persists.
This PR addressed the bug by including
isPreviewModeas an indicator that the panel is opened in preview. Clicking a link in preview should opens a new flyout and preview should not appear.Screen.Recording.2025-03-06.at.11.55.35.AM.mov
Added banner to session viewer in flyout
Checklist
release_note:*label is applied per the guidelines