Skip to content

[Security Solution] Fix session view navigation when in alert preview and add preview banner #213455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christineweng merged 1 commit into from
Mar 13, 2025
Merged

[Security Solution] Fix session view navigation when in alert preview and add preview banner #213455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lugins/security_solution/public/flyout/document_details/left/components/analyze_graph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const ANALYZER_PREVIEW_BANNER = {
title: i18n.translate(
'xpack.securitySolution.flyout.left.visualizations.analyzer.panelPreviewTitle',
{
defaultMessage: 'Preview analyzer panels',
defaultMessage: 'Preview analyzer panel',
}
),
backgroundColor: 'warning',
Expand Down
10 changes: 10 additions & 0 deletions ...plugins/security_solution/public/flyout/document_details/left/components/session_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import React, { memo, useCallback, useMemo } from 'react';
import { useExpandableFlyoutApi } from '@kbn/expandable-flyout';
import { EuiPanel } from '@elastic/eui';
import type { Process } from '@kbn/session-view-plugin/common';
import { i18n } from '@kbn/i18n';
import type { CustomProcess } from '../../session_view/context';
import { useUserPrivileges } from '../../../../common/components/user_privileges';
import { SESSION_VIEW_TEST_ID } from './test_ids';
Expand All @@ -29,6 +30,14 @@ import { DocumentEventTypes } from '../../../../common/lib/telemetry';

export const SESSION_VIEW_ID = 'session-view';

export const SESSION_VIEWER_BANNER = {
title: i18n.translate('xpack.securitySolution.flyout.preview.sessionViewerTitle', {
defaultMessage: 'Preview session view panel',
}),
backgroundColor: 'warning',
textColor: 'warning',
};

/**
* Session view displayed in the document details expandable flyout left section under the Visualize tab
*/
Expand Down Expand Up @@ -107,6 +116,7 @@ export const SessionView: FC = memo(() => {
scopeId,
jumpToEntityId,
jumpToCursor,
banner: SESSION_VIEWER_BANNER,
},
});
},
Expand Down
2 changes: 1 addition & 1 deletion ...lution/public/flyout/document_details/right/components/session_preview_container.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ describe('SessionPreviewContainer', () => {

const { getByTestId, queryByTestId } = renderSessionPreview({
...mockContextValue,
isPreview: true,
isPreviewMode: true,
});

expect(getByTestId(SESSION_PREVIEW_TEST_ID)).toBeInTheDocument();
Expand Down
1 change: 1 addition & 0 deletions ...ty_solution/public/flyout/document_details/right/components/session_preview_container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export const SessionPreviewContainer: FC = () => {
indexName,
isFlyoutOpen: true,
scopeId,
isPreviewMode,
});

const iconType = useMemo(() => {
Expand Down
2 changes: 2 additions & 0 deletions .../security/plugins/security_solution/public/flyout/document_details/session_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { useSessionViewPanelContext } from './context';
import type { SessionViewPanelTabType } from './tabs';
import * as tabs from './tabs';
import { DocumentDetailsSessionViewPanelKey } from '../shared/constants/panel_keys';
import { SESSION_VIEWER_BANNER } from '../left/components/session_view';

export const allTabs = [tabs.processTab, tabs.metadataTab, tabs.alertsTab];
export type SessionViewPanelPaths = 'process' | 'metadata' | 'alerts';
Expand Down Expand Up @@ -80,6 +81,7 @@ export const SessionViewPanel: FC<Partial<SessionViewPanelProps>> = memo(({ path
sessionStartTime,
scopeId,
investigatedAlertId,
banner: SESSION_VIEWER_BANNER,
},
});
},
Expand Down