Skip to content

[9.0] [Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)#214469

Merged
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-213455
Mar 13, 2025
Merged

[9.0] [Security Solution] Fix session view navigation when in alert preview and add preview banner (#213455)#214469
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-213455

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

… and add preview banner (elastic#213455)

## Summary

Before: when in an alert preview, clicking session preview header opens
session view in details panel, but the preview persists.

This PR addressed the bug by including `isPreviewMode` as an indicator
that the panel is opened in preview. Clicking a link in preview should
opens a new flyout and preview should not appear.

https://github.com/user-attachments/assets/484daa16-adb0-48f2-b14e-a971878817c0

Added banner to session viewer in flyout

<img width="1468" alt="image"
src="https://github.com/user-attachments/assets/e228b35f-938a-4ad1-a97f-818caf36a284"
/>

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit a6ceafc)
@kibanamachine kibanamachine merged commit 57c2670 into elastic:9.0 Mar 13, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #70 / ObservabilityApp Observability Rules page Create rules form "after each" hook for "Should allow the user to select consumers when creating ES query rules"
  • [job] [logs] FTR Configs #70 / ObservabilityApp Observability Rules page Create rules form Should allow the user to select consumers when creating ES query rules

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.8MB 8.8MB +243.0B

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants