[Automatic Import] Fix package name validation#210770
Merged
bhapas merged 2 commits intoelastic:mainfrom Feb 12, 2025
Merged
Conversation
bhapas
added
release_note:fix
backport:prev-minor
Team:Security-Scalability
Contributor
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
P1llus
approved these changes
Feb 12, 2025
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13284652284 |
Contributor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
## Release Note Fix package name validation on Datastream page. ## Summary Closes - elastic#199893 If the package name starts with a number [ Only number , alphabet , underscore are allowed ] then some of the script processors in the pipeline fail with dot annotation since the fields are formed like `ctx.123_abc.something` which fails with `Illegal Argument Exception` in script processor. Hence the package name has additional validation on Data stream page to restrict it to start with an alphabet or underscore instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9c87ded)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 12, 2025
## Release Note Fix package name validation on Datastream page. ## Summary Closes - elastic#199893 If the package name starts with a number [ Only number , alphabet , underscore are allowed ] then some of the script processors in the pipeline fail with dot annotation since the fields are formed like `ctx.123_abc.something` which fails with `Illegal Argument Exception` in script processor. Hence the package name has additional validation on Data stream page to restrict it to start with an alphabet or underscore instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9c87ded) # Conflicts: # x-pack/platform/plugins/shared/integration_assistant/common/constants.ts # x-pack/platform/plugins/shared/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/translations.ts
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 12, 2025
## Release Note Fix package name validation on Datastream page. ## Summary Closes - elastic#199893 If the package name starts with a number [ Only number , alphabet , underscore are allowed ] then some of the script processors in the pipeline fail with dot annotation since the fields are formed like `ctx.123_abc.something` which fails with `Illegal Argument Exception` in script processor. Hence the package name has additional validation on Data stream page to restrict it to start with an alphabet or underscore instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9c87ded) # Conflicts: # x-pack/platform/plugins/shared/integration_assistant/common/constants.ts # x-pack/platform/plugins/shared/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/translations.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 12, 2025
## Release Note Fix package name validation on Datastream page. ## Summary Closes - elastic#199893 If the package name starts with a number [ Only number , alphabet , underscore are allowed ] then some of the script processors in the pipeline fail with dot annotation since the fields are formed like `ctx.123_abc.something` which fails with `Illegal Argument Exception` in script processor. Hence the package name has additional validation on Data stream page to restrict it to start with an alphabet or underscore instead. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9c87ded) # Conflicts: # x-pack/plugins/integration_assistant/common/constants.ts # x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/translations.ts
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Automatic Import] Fix package name validation (#210770)](#210770) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T11:48:20Z","message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix package name validation","number":210770,"url":"https://github.com/elastic/kibana/pull/210770","mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210770","number":210770,"mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
1 task
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
bhapas
added a commit
that referenced
this pull request
Feb 13, 2025
## Summary A bug was introduced with #210770 and this PR fixes that. The Package name generated is validated.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…210916) ## Summary A bug was introduced with elastic#210770 and this PR fixes that. The Package name generated is validated. (cherry picked from commit cf0f338)
bhapas
added a commit
that referenced
this pull request
Feb 13, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Fix package name validation (#210770)](#210770) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T11:48:20Z","message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix package name validation","number":210770,"url":"https://github.com/elastic/kibana/pull/210770","mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210770","number":210770,"mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},{"url":"https://github.com/elastic/kibana/pull/210801","number":210801,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
bhapas
added a commit
that referenced
this pull request
Feb 13, 2025
) # Backport This will backport the following commits from `main` to `8.18`: - [[Automatic Import] Fix package name validation (#210770)](#210770) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T11:48:20Z","message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix package name validation","number":210770,"url":"https://github.com/elastic/kibana/pull/210770","mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210770","number":210770,"mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},{"url":"https://github.com/elastic/kibana/pull/210801","number":210801,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
bhapas
added a commit
that referenced
this pull request
Feb 13, 2025
) # Backport This will backport the following commits from `main` to `8.17`: - [[Automatic Import] Fix package name validation (#210770)](#210770) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T11:48:20Z","message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix package name validation","number":210770,"url":"https://github.com/elastic/kibana/pull/210770","mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210770","number":210770,"mergeCommit":{"message":"[Automatic Import] Fix package name validation (#210770)\n\n## Release Note\r\n\r\nFix package name validation on Datastream page.\r\n\r\n## Summary\r\n\r\nCloses - #199893\r\n\r\nIf the package name starts with a number [ Only number , alphabet ,\r\nunderscore are allowed ] then some of the script processors in the\r\npipeline fail with dot annotation since the fields are formed like\r\n`ctx.123_abc.something` which fails with `Illegal Argument Exception` in\r\nscript processor.\r\n\r\nHence the package name has additional validation on Data stream page to\r\nrestrict it to start with an alphabet or underscore instead.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"9c87ded7d1e1f5c9fe8b3accce1beda01268d5cf"}},{"url":"https://github.com/elastic/kibana/pull/210801","number":210801,"branch":"9.0","state":"OPEN"}]}] BACKPORT-->
kibanamachine
added
v8.17.3
and removed
backport missing
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
…10916) (#211037) # Backport This will backport the following commits from `main` to `9.0`: - [[Automatic Import] Fix generated name for integration title (#210916)](#210916) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-13T16:02:03Z","message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix generated name for integration title","number":210916,"url":"https://github.com/elastic/kibana/pull/210916","mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210916","number":210916,"mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 14, 2025
…210916) ## Summary A bug was introduced with elastic#210770 and this PR fixes that. The Package name generated is validated. (cherry picked from commit cf0f338) # Conflicts: # x-pack/platform/plugins/shared/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/data_stream_step.tsx
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 14, 2025
…210916) ## Summary A bug was introduced with elastic#210770 and this PR fixes that. The Package name generated is validated. (cherry picked from commit cf0f338) # Conflicts: # x-pack/platform/plugins/shared/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/data_stream_step.tsx
bhapas
added a commit
to bhapas/kibana
that referenced
this pull request
Feb 14, 2025
…210916) ## Summary A bug was introduced with elastic#210770 and this PR fixes that. The Package name generated is validated. (cherry picked from commit cf0f338) # Conflicts: # x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/data_stream_step/data_stream_step.tsx
bhapas
added a commit
that referenced
this pull request
Feb 14, 2025
…210916) (#211150) # Backport This will backport the following commits from `main` to `8.18`: - [[Automatic Import] Fix generated name for integration title (#210916)](#210916) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-13T16:02:03Z","message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix generated name for integration title","number":210916,"url":"https://github.com/elastic/kibana/pull/210916","mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211037","number":211037,"state":"MERGED","mergeCommit":{"sha":"badb523efc6e567dc33136f84bae6c240de7ab4c","message":"[9.0] [Automatic Import] Fix generated name for integration title (#210916) (#211037)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Automatic Import] Fix generated name for integration title\n(#210916)](https://github.com/elastic/kibana/pull/210916)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Bharat\nPasupula\",\"email\":\"123897612+bhapas@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-13T16:02:03Z\",\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport:prev-minor\",\"Team:Security-Scalability\",\"Feature:AutomaticImport\",\"v9.1.0\"],\"title\":\"[Automatic\nImport] Fix generated name for integration\ntitle\",\"number\":210916,\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"number\":210916,\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210916","number":210916,"mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bhapas
added a commit
that referenced
this pull request
Feb 14, 2025
…210916) (#211151) # Backport This will backport the following commits from `main` to `8.17`: - [[Automatic Import] Fix generated name for integration title (#210916)](#210916) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-13T16:02:03Z","message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix generated name for integration title","number":210916,"url":"https://github.com/elastic/kibana/pull/210916","mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211037","number":211037,"state":"MERGED","mergeCommit":{"sha":"badb523efc6e567dc33136f84bae6c240de7ab4c","message":"[9.0] [Automatic Import] Fix generated name for integration title (#210916) (#211037)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Automatic Import] Fix generated name for integration title\n(#210916)](https://github.com/elastic/kibana/pull/210916)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Bharat\nPasupula\",\"email\":\"123897612+bhapas@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-13T16:02:03Z\",\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport:prev-minor\",\"Team:Security-Scalability\",\"Feature:AutomaticImport\",\"v9.1.0\"],\"title\":\"[Automatic\nImport] Fix generated name for integration\ntitle\",\"number\":210916,\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"number\":210916,\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210916","number":210916,"mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bhapas
added a commit
that referenced
this pull request
Feb 14, 2025
…10916) (#211149) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Fix generated name for integration title (#210916)](#210916) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-13T16:02:03Z","message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport","v9.1.0"],"title":"[Automatic Import] Fix generated name for integration title","number":210916,"url":"https://github.com/elastic/kibana/pull/210916","mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211037","number":211037,"state":"MERGED","mergeCommit":{"sha":"badb523efc6e567dc33136f84bae6c240de7ab4c","message":"[9.0] [Automatic Import] Fix generated name for integration title (#210916) (#211037)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Automatic Import] Fix generated name for integration title\n(#210916)](https://github.com/elastic/kibana/pull/210916)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Bharat\nPasupula\",\"email\":\"123897612+bhapas@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-13T16:02:03Z\",\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"backport:prev-minor\",\"Team:Security-Scalability\",\"Feature:AutomaticImport\",\"v9.1.0\"],\"title\":\"[Automatic\nImport] Fix generated name for integration\ntitle\",\"number\":210916,\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/210916\",\"number\":210916,\"mergeCommit\":{\"message\":\"[Automatic\nImport] Fix generated name for integration title (#210916)\\n\\n##\nSummary\\r\\n\\r\\nA bug was introduced with #210770 and this PR fixes that.\nThe Package\\r\\nname generated is\nvalidated.\",\"sha\":\"cf0f338d8749c90024b2409fbb7b036469bfab6e\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210916","number":210916,"mergeCommit":{"message":"[Automatic Import] Fix generated name for integration title (#210916)\n\n## Summary\r\n\r\nA bug was introduced with #210770 and this PR fixes that. The Package\r\nname generated is validated.","sha":"cf0f338d8749c90024b2409fbb7b036469bfab6e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…210916) ## Summary A bug was introduced with elastic#210770 and this PR fixes that. The Package name generated is validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note
Fix package name validation on Datastream page.
Summary
Closes - #199893
If the package name starts with a number [ Only number , alphabet , underscore are allowed ] then some of the script processors in the pipeline fail with dot annotation since the fields are formed like
ctx.123_abc.somethingwhich fails withIllegal Argument Exceptionin script processor.Hence the package name has additional validation on Data stream page to restrict it to start with an alphabet or underscore instead.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines