[Lens][Embeddable] Make sure to not serialize searchSessionId#210765
Merged
dej611 merged 2 commits intoelastic:mainfrom Feb 12, 2025
Merged
[Lens][Embeddable] Make sure to not serialize searchSessionId#210765dej611 merged 2 commits intoelastic:mainfrom
dej611 merged 2 commits intoelastic:mainfrom
Conversation
dej611
added
release_note:fix
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
nickofthyme
approved these changes
Feb 12, 2025
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/13289555031 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…c#210765) ## Summary This PR fixes a regression in the `serializeState` function used to pass the embeddable attributes to the dashboard to save the panel. In the refactor this function started to leak the `searchSessionId` in the serialized state and even if not used after worse it could lead to issues and in general it's a waste of disk space. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Release notes It fixes a regression for the serialized state for the Lens embeddable saving attributes who should not be in the serialized state. (cherry picked from commit ab414b4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…c#210765) ## Summary This PR fixes a regression in the `serializeState` function used to pass the embeddable attributes to the dashboard to save the panel. In the refactor this function started to leak the `searchSessionId` in the serialized state and even if not used after worse it could lead to issues and in general it's a waste of disk space. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Release notes It fixes a regression for the serialized state for the Lens embeddable saving attributes who should not be in the serialized state. (cherry picked from commit ab414b4)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…210765) (#210873) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)](#210765) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T15:59:47Z","message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-major","v9.1.0"],"title":"[Lens][Embeddable] Make sure to not serialize searchSessionId","number":210765,"url":"https://github.com/elastic/kibana/pull/210765","mergeCommit":{"message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210765","number":210765,"mergeCommit":{"message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…210765) (#210872) # Backport This will backport the following commits from `main` to `8.18`: - [[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)](#210765) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T15:59:47Z","message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-major","v9.1.0"],"title":"[Lens][Embeddable] Make sure to not serialize searchSessionId","number":210765,"url":"https://github.com/elastic/kibana/pull/210765","mergeCommit":{"message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210765","number":210765,"mergeCommit":{"message":"[Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)\n\n## Summary\n\nThis PR fixes a regression in the `serializeState` function used to pass\nthe embeddable attributes to the dashboard to save the panel. In the\nrefactor this function started to leak the `searchSessionId` in the\nserialized state and even if not used after worse it could lead to\nissues and in general it's a waste of disk space.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Release notes\nIt fixes a regression for the serialized state for the Lens embeddable\nsaving attributes who should not be in the serialized state.","sha":"ab414b4effbb5e6892bf09bf9f22ccbae37d9554"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression in the
serializeStatefunction used to pass the embeddable attributes to the dashboard to save the panel. In the refactor this function started to leak thesearchSessionIdin the serialized state and even if not used after worse it could lead to issues and in general it's a waste of disk space.Checklist
Release notes
It fixes a regression for the serialized state for the Lens embeddable saving attributes who should not be in the serialized state.