Skip to content

[9.0] [Automatic Import] Fix package name validation (#210770)#210801

Merged
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-210770
Feb 12, 2025
Merged

[9.0] [Automatic Import] Fix package name validation (#210770)#210801
kibanamachine merged 1 commit intoelastic:9.0from
kibanamachine:backport/9.0/pr-210770

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

## Release Note

Fix package name validation on Datastream page.

## Summary

Closes - elastic#199893

If the package name starts with a number [ Only number , alphabet ,
underscore are allowed ] then some of the script processors in the
pipeline fail with dot annotation since the fields are formed like
`ctx.123_abc.something` which fails with `Illegal Argument Exception` in
script processor.

Hence the package name has additional validation on Data stream page to
restrict it to start with an alphabet or underscore instead.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 9c87ded)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 12, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) February 12, 2025 11:54
@kibanamachine kibanamachine merged commit 9c5808f into elastic:9.0 Feb 12, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
automaticImport 1.1MB 1.1MB +41.0B

cc @bhapas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants