Skip to content

[8.x] [Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)#210873

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-210765
Feb 12, 2025
Merged

[8.x] [Lens][Embeddable] Make sure to not serialize searchSessionId (#210765)#210873
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-210765

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…c#210765)

## Summary

This PR fixes a regression in the `serializeState` function used to pass
the embeddable attributes to the dashboard to save the panel. In the
refactor this function started to leak the `searchSessionId` in the
serialized state and even if not used after worse it could lead to
issues and in general it's a waste of disk space.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

## Release notes
It fixes a regression for the serialized state for the Lens embeddable
saving attributes who should not be in the serialized state.

(cherry picked from commit ab414b4)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 12, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) February 12, 2025 16:06
@kibanamachine kibanamachine merged commit 06f400a into elastic:8.x Feb 12, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +104.0B
Unknown metric groups

References to deprecated APIs

id before after diff
lens 88 90 +2

cc @dej611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants