[Search]: Fix Number type field to have correct property#210462
Merged
Samiul-TheSoccerFan merged 2 commits intoelastic:mainfrom Feb 11, 2025
Merged
[Search]: Fix Number type field to have correct property#210462Samiul-TheSoccerFan merged 2 commits intoelastic:mainfrom
Samiul-TheSoccerFan merged 2 commits intoelastic:mainfrom
Conversation
Samiul-TheSoccerFan
added
release_note:skip
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
pgayvallet
approved these changes
Feb 11, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13271258240 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
) ## Summary This PR includes the following updates: - Converted `readOnly` fields to `disabled` to ensure consistency across all view-only fields. - Added an `isPreconfigured` check to disable the `num_allocations` field. While `num_allocations` is the only updatable field for `Elasticsearch` services, it cannot be modified if the endpoint is preconfigured. ### Not preconfigured  ### Preconfigured  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dc0ccc4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
) ## Summary This PR includes the following updates: - Converted `readOnly` fields to `disabled` to ensure consistency across all view-only fields. - Added an `isPreconfigured` check to disable the `num_allocations` field. While `num_allocations` is the only updatable field for `Elasticsearch` services, it cannot be modified if the endpoint is preconfigured. ### Not preconfigured  ### Preconfigured  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dc0ccc4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
) ## Summary This PR includes the following updates: - Converted `readOnly` fields to `disabled` to ensure consistency across all view-only fields. - Added an `isPreconfigured` check to disable the `num_allocations` field. While `num_allocations` is the only updatable field for `Elasticsearch` services, it cannot be modified if the endpoint is preconfigured. ### Not preconfigured  ### Preconfigured  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit dc0ccc4)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kapral18
added a commit
to agusruidiazgd/kibana
that referenced
this pull request
Feb 11, 2025
…on-206439 * main: (402 commits) [Search]: Fix Number type field to have correct property (elastic#210462) Change filter for rule monitoring gaps (elastic#209983) Update Logs Explorer deprecation messages (elastic#201307) [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (elastic#210613) [Embeddable] Fix presentation panel styles (elastic#210113) [ci] enable Scout reporter for on-merge-unsupported-ftrs (elastic#210627) [Fix][Synonyms UI]Add navigation link to the Detail breadcrumb. (elastic#209574) chore(dep): bump `store2` from `2.12.0` to `2.14.4` (elastic#210530) [scout] adding test helper `@kbn/scout-oblt` package and uptate onboarding tests (elastic#209761) [Cloud Security] Asset Inventory table flyout controls (elastic#208452) [ML] Fix model deployment check in file uploader (elastic#209585) Updates archive again (elastic#209828) [Security Solution] Added concurrency limits and request throttling to prebuilt rule routes (elastic#209551) [Search] [Onboarding] Update search api to use EventEmitter instead of Provider (elastic#209784) [maps] lazy load map actions (elastic#210252) [Cloud Security] Adding telemetry collection condition based on render condition (elastic#208758) [Solution nav] Use flyout for Stack Management in Search and Observability solutions (elastic#208632) [Search] Fix Add Inference Endpoint API call (elastic#210243) [Agentless Connectors] Integration overview panel (elastic#210222) [Lens] Restore dynamic colouring by value for Last value agg (elastic#209110) ...
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
) (#210690) # Backport This will backport the following commits from `main` to `8.18`: - [[Search]: Fix Number type field to have correct property (#210462)](#210462) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-11T19:47:13Z","message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search]: Fix Number type field to have correct property","number":210462,"url":"https://github.com/elastic/kibana/pull/210462","mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210462","number":210462,"mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…) (#210692) # Backport This will backport the following commits from `main` to `9.0`: - [[Search]: Fix Number type field to have correct property (#210462)](#210462) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-11T19:47:13Z","message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search]: Fix Number type field to have correct property","number":210462,"url":"https://github.com/elastic/kibana/pull/210462","mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210462","number":210462,"mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…) (#210691) # Backport This will backport the following commits from `main` to `8.x`: - [[Search]: Fix Number type field to have correct property (#210462)](#210462) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-11T19:47:13Z","message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search]: Fix Number type field to have correct property","number":210462,"url":"https://github.com/elastic/kibana/pull/210462","mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210462","number":210462,"mergeCommit":{"message":"[Search]: Fix Number type field to have correct property (#210462)\n\n## Summary\r\n\r\nThis PR includes the following updates: \r\n- Converted `readOnly` fields to `disabled` to ensure consistency across\r\nall view-only fields.\r\n- Added an `isPreconfigured` check to disable the `num_allocations`\r\nfield. While `num_allocations` is the only updatable field for\r\n`Elasticsearch` services, it cannot be modified if the endpoint is\r\npreconfigured.\r\n\r\n### Not preconfigured\r\n\r\n\r\n### Preconfigured\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"dc0ccc4b7db1ce7fd449618ffc5c4efb58936326"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the following updates:
readOnlyfields todisabledto ensure consistency across all view-only fields.isPreconfiguredcheck to disable thenum_allocationsfield. Whilenum_allocationsis the only updatable field forElasticsearchservices, it cannot be modified if the endpoint is preconfigured.Not preconfigured
Preconfigured
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.