Skip to content

Change filter for rule monitoring gaps#209983

Merged
nkhristinin merged 2 commits intoelastic:mainfrom
nkhristinin:rule-monitoring-ui
Feb 11, 2025
Merged

Change filter for rule monitoring gaps#209983
nkhristinin merged 2 commits intoelastic:mainfrom
nkhristinin:rule-monitoring-ui

Conversation

@nkhristinin
Copy link
Copy Markdown
Contributor

@nkhristinin nkhristinin commented Feb 6, 2025

Change filter for rule monitoring gaps

Keep only 1 button, and make selection more clear

Screen.Recording.2025-02-06.at.12.21.19.mov

@nkhristinin nkhristinin marked this pull request as ready for review February 10, 2025 16:00
@nkhristinin nkhristinin requested a review from a team as a code owner February 10, 2025 16:00
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:8.18 labels Feb 11, 2025
@nkhristinin
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB -181.0B

History

@vitaliidm
Copy link
Copy Markdown
Contributor

@nkhristinin

one question:
Would lables backport:prev-minor, backport:8.18 backport this PR to 8.19?

@nkhristinin
Copy link
Copy Markdown
Contributor Author

as i see in other PRs backport:prev-minor should backport to 8.x and 8.18

@nkhristinin nkhristinin merged commit 0007203 into elastic:main Feb 11, 2025
2 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13269945337

@nkhristinin
Copy link
Copy Markdown
Contributor Author

@vitaliidm Hm, looks like it didn't work, will create manual backports

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2025
## Change filter for rule monitoring gaps

Keep only 1 button, and make selection more clear

https://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 0007203)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nkhristinin added a commit to nkhristinin/kibana that referenced this pull request Feb 11, 2025
## Change filter for rule monitoring gaps

Keep only 1 button, and make selection more clear

https://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 0007203)
@nkhristinin
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nkhristinin added a commit to nkhristinin/kibana that referenced this pull request Feb 11, 2025
## Change filter for rule monitoring gaps

Keep only 1 button, and make selection more clear

https://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 0007203)
nkhristinin added a commit that referenced this pull request Feb 11, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Change filter for rule monitoring gaps
(#209983)](#209983)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:30:48Z","message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"Change
filter for rule monitoring
gaps","number":209983,"url":"https://github.com/elastic/kibana/pull/209983","mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209983","number":209983,"mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}},{"url":"https://github.com/elastic/kibana/pull/210680","number":210680,"branch":"9.0","state":"OPEN"}]}]
BACKPORT-->
kapral18 added a commit to agusruidiazgd/kibana that referenced this pull request Feb 11, 2025
…on-206439

* main: (402 commits)
  [Search]: Fix Number type field to have correct property (elastic#210462)
  Change filter for rule monitoring gaps (elastic#209983)
  Update Logs Explorer deprecation messages (elastic#201307)
  [APM] Remove `error.id` in `getErrorGroupMainStatistics` query as it's not used (elastic#210613)
  [Embeddable] Fix presentation panel styles (elastic#210113)
  [ci] enable Scout reporter for on-merge-unsupported-ftrs (elastic#210627)
  [Fix][Synonyms UI]Add navigation link to the Detail breadcrumb. (elastic#209574)
  chore(dep): bump `store2` from `2.12.0` to `2.14.4` (elastic#210530)
  [scout] adding test helper `@kbn/scout-oblt` package and uptate onboarding tests (elastic#209761)
  [Cloud Security] Asset Inventory table flyout controls  (elastic#208452)
  [ML] Fix model deployment check in file uploader (elastic#209585)
  Updates archive again (elastic#209828)
  [Security Solution] Added concurrency limits and request throttling to prebuilt rule routes (elastic#209551)
  [Search] [Onboarding] Update search api to use EventEmitter instead of Provider (elastic#209784)
  [maps] lazy load map actions (elastic#210252)
  [Cloud Security] Adding telemetry collection condition based on render condition (elastic#208758)
  [Solution nav] Use flyout for Stack Management in Search and Observability solutions (elastic#208632)
  [Search] Fix Add Inference Endpoint API call (elastic#210243)
  [Agentless Connectors] Integration overview panel (elastic#210222)
  [Lens] Restore dynamic colouring by value for Last value agg (elastic#209110)
  ...
nkhristinin added a commit that referenced this pull request Feb 11, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [Change filter for rule monitoring gaps
(#209983)](#209983)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:30:48Z","message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"Change
filter for rule monitoring
gaps","number":209983,"url":"https://github.com/elastic/kibana/pull/209983","mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209983","number":209983,"mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}},{"url":"https://github.com/elastic/kibana/pull/210680","number":210680,"branch":"9.0","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.19.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 11, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Feb 17, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Change filter for rule monitoring gaps
(#209983)](#209983)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T18:30:48Z","message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0"],"title":"Change
filter for rule monitoring
gaps","number":209983,"url":"https://github.com/elastic/kibana/pull/209983","mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209983","number":209983,"mergeCommit":{"message":"Change
filter for rule monitoring gaps (#209983)\n\n## Change filter for rule
monitoring gaps\r\n\r\nKeep only 1 button, and make selection more
clear\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"0007203278ec42c8b490903f605bbd6117a764b1"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
@kibanamachine kibanamachine added v9.0.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants